Issue Station
Sign In
Tools hereToolbox

hermes - 💡(How to fix) Fix gateway/platforms BasePlatformAdapter and concrete adapters have no unit tests

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
RAW_BUFFERClick to expand / collapse

Problem

gateway/platforms/base.py defines BasePlatformAdapter (ABC) and gateway/platforms/ contains 4 concrete adapters (Discord, Slack, Telegram, WhatsApp). Despite being a core extension point in the gateway architecture, neither BasePlatformAdapter nor any concrete adapter has unit tests.

Expected Outcome

Each platform adapter has unit tests covering its message parsing, formatting, and platform-specific handling, plus tests for BasePlatformAdapter interface compliance.

Suggested Approach

Create tests/gateway/platforms/ directory with:

  • test_base_platform_adapter.py — verify subclasses correctly implement abstract methods (send_message, parse_incoming, etc.)
  • test_telegram_adapter.py — Telegram-specific message parsing and formatting
  • test_slack_adapter.py — Slack-specific formatting (block kit, etc.)
  • test_discord_adapter.py — Discord embed formatting
  • test_whatsapp_adapter.py — WhatsApp message type handling

Suggested Files

  • gateway/platforms/base.py
  • gateway/platforms/telegram.py
  • gateway/platforms/slack.py
  • gateway/platforms/discord.py
  • gateway/platforms/whatsapp.py
  • tests/gateway/platforms/ (new test directory)

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

hermes - 💡(How to fix) Fix gateway/platforms BasePlatformAdapter and concrete adapters have no unit tests