PR #16333: fix(compression): notify gateway users when summary generation fails

• Repository: NousResearch/hermes-agent
• Author: iamagenius00
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/16333

Description (problem / solution / changelog)

Fixes #16650

Problem

When auxiliary compression's summary LLM call fails (e.g. model 404, misconfigured auxiliary.compression.model), the compressor still drops the selected turns and inserts a static fallback placeholder. The dropped context is unrecoverable.

Previously the only signal of this failure was a WARNING in agent.log. Gateway users (Telegram / Discord / Slack / etc.) had no visible signal that context was lost. A user could come back to a session, find earlier work missing, and have no idea why.

Why the existing _emit_warning path didn't catch it

The gateway hygiene path uses a temporary _hyg_agent constructed with quiet_mode=True, _print_fn = no-op, and no status_callback. So _emit_warning (which depends on status_callback) silently no-ops in this code path. The CLI / normal-agent path was already covered.

Reproducible scenario: auxiliary.compression.model set to a model the main provider doesn't serve (e.g. a Google model name routed to Anthropic). Every hygiene-triggered compaction logs Failed to generate context summary: ... 404 ..., the placeholder gets inserted, and the user sees nothing in their chat.

Fix

1. agent/context_compressor.py — track per-compress state:

   • _last_summary_fallback_used: bool
   • _last_summary_dropped_count: int

   Cleared at the top of compress() and on on_session_reset(). Set when summary generation fails and the static fallback is inserted.

2. gateway/run.py hygiene auto-compress — after _compress_context returns, inspect _hyg_agent.context_compressor. If _last_summary_fallback_used is True, send a visible ⚠️ warning to the user via the platform adapter, including the dropped count and the underlying error message.

3. gateway/run.py /compress manual command — append the same warning to the manual /compress reply so users running it explicitly also see the failure.

Acceptance

• ✅ Summary success → no user-visible warning (unchanged).
• ✅ Summary failure on gateway hygiene → user receives a TG/Discord message with dropped count, underlying error, and remediation hint (/reset or check auxiliary.compression).
• ✅ Summary failure on /compress → warning appended to the command reply.
• ✅ CLI status_callback / _emit_warning path is untouched (no behavioural regression).
• ✅ Two new tests in tests/agent/test_context_compressor.py verify tracking fields are set on failure and cleared on subsequent success.

Tests

tests/agent/test_context_compressor.py: 54 passed in 1.73s

New tests:

• TestSummaryFailureTrackingForGatewayWarning::test_compress_records_fallback_and_dropped_count_on_summary_failure
• TestSummaryFailureTrackingForGatewayWarning::test_compress_clears_fallback_flag_on_subsequent_success

Notes

The warning is only sent to the platform that triggered the hygiene compaction (source.platform/source.chat_id). It does not broadcast to other platforms or sessions. The gateway adapter .send call is wrapped in try/except so a warning-delivery failure can't break the compression result.

Changed files

• agent/context_compressor.py (modified, +16/-2)
• gateway/run.py (modified, +41/-0)
• tests/agent/test_context_compressor.py (modified, +66/-0)
• tests/gateway/test_compress_command.py (modified, +58/-0)
• tests/gateway/test_session_hygiene.py (modified, +116/-0)

PR #16771: fix(compression): notify gateway users when summary generation fails (salvage #16333)

• Repository: NousResearch/hermes-agent
• Author: teknium1
• State: closed | merged: True
• Link: https://github.com/NousResearch/hermes-agent/pull/16771

Description (problem / solution / changelog)

Salvage of #16333 by @iamagenius00 onto current main (223 commits behind at submission). Contributor authorship preserved via cherry-pick + rebase merge.

Summary

Gateway users now see a visible ⚠️ warning when context compression's summary LLM call fails. Previously the compressor would drop the selected turns, insert a static fallback placeholder, and leave the user with silently-truncated context — only agent.log had the warning.

Why the existing warning path didn't catch it

_compress_context in run_agent.py already calls self._emit_warning(...) on summary failure, but _emit_warning surfaces via _vprint (silenced by _print_fn = lambda: None) and status_callback (not set). Both the gateway hygiene auto-compress path and the /compress command build temporary AIAgent instances with quiet_mode=True, no-op _print_fn, and no status_callback — so the warning never reached the user.

Changes

• agent/context_compressor.py — track _last_summary_fallback_used + _last_summary_dropped_count per compress call. Cleared at the top of compress() and on on_session_reset(). Set when summary generation returns None and the static fallback is inserted.
• gateway/run.py hygiene auto-compress — after _compress_context returns, inspect the compressor flags and send a visible ⚠️ message to the originating chat (with thread_id metadata preserved).
• gateway/run.py /compress command — append the same warning to the manual command reply.
• Tests: 2 new compressor tests + 1 gateway hygiene test + 1 /compress test.

Acceptance

• Summary success → no user-visible warning (unchanged).
• Summary failure on gateway hygiene → user receives TG/Discord message with dropped count, underlying error, and remediation hint.
• Summary failure on /compress → warning appended to the command reply.
• CLI status_callback / _emit_warning path untouched (no behavioural regression).
• Warning delivery is try/except-wrapped so a send failure can't break the compression result.

Validation

scripts/run_tests.sh tests/agent/test_context_compressor.py tests/gateway/test_session_hygiene.py tests/gateway/test_compress_command.py
81 passed in 1.75s

Closes #16333. Fixes #16650.

Changed files

• agent/context_compressor.py (modified, +16/-2)
• gateway/run.py (modified, +41/-0)
• tests/agent/test_context_compressor.py (modified, +66/-0)
• tests/gateway/test_compress_command.py (modified, +58/-0)
• tests/gateway/test_session_hygiene.py (modified, +116/-0)