hermes - 💡(How to fix) Fix hermes_cli/cron.py background ticker lacks dedicated unit tests [1 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

Error Message

The cron ticker module has unit tests covering: job registration, tick firing at correct intervals, graceful shutdown via stop_event, and error handling when an adapter is unavailable.

Fix Action

Fixed

RAW_BUFFERClick to expand / collapse

Problem

hermes_cli/cron.py implements a background cron ticker (_start_cron_ticker) that schedules periodic tasks in the gateway. It is production code but has no dedicated unit tests covering job scheduling, tick interval handling, stop events, or adapter integration.

Expected Outcome

The cron ticker module has unit tests covering: job registration, tick firing at correct intervals, graceful shutdown via stop_event, and error handling when an adapter is unavailable.

Suggested Approach

Create tests/hermes_cli/test_cron.py:

  • test_cron_ticker_fires_at_interval — mock time, verify job runs after interval
  • test_cron_ticker_stop_event — stop_event set, ticker exits cleanly
  • test_cron_ticker_with_adapter — adapter is called on each tick
  • test_cron_ticker_handles_adapter_error — adapter raises, ticker continues

Suggested Files

  • hermes_cli/cron.py (source)
  • tests/hermes_cli/test_cron.py (new test file)

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

hermes - 💡(How to fix) Fix hermes_cli/cron.py background ticker lacks dedicated unit tests [1 pull requests]