dify - ✅(Solved) Fix improve workflow as tool overlays [1 pull requests, 1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
langgenius/dify#35664Fetched 2026-04-29 06:36:14
View on GitHub
Comments
0
Participants
1
Timeline
4
Reactions
1
Author
Participants
Timeline (top)
cross-referenced ×2closed ×1labeled ×1

Fix Action

Fixed

PR fix notes

PR #35661: fix: improve workflow as tool overlays

Description (problem / solution / changelog)

[!IMPORTANT]

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> <!-- If this PR was created by an automated agent, add `From <Tool Name>` as the final line of the description. Example: `From Codex`. -->

fix https://github.com/langgenius/dify/issues/35664

  • Migrate Workflow as Tool drawer and confirmation modal to the new @langgenius/dify-ui/dialog overlay primitives.
  • Fix Workflow as Tool drawer being covered by the Publish popover.
  • Migrate Tool Input Method selector from deprecated PortalToFollowElem to @langgenius/dify-ui/popover.
  • Close the Method selector dropdown after selecting an option.
  • Avoid duplicate success toast when updating an existing Workflow as Tool.

Screenshots

BeforeAfter
......

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Changed files

  • eslint-suppressions.json (modified, +0/-15)
  • web/app/components/tools/workflow-tool/__tests__/configure-button.spec.tsx (modified, +20/-18)
  • web/app/components/tools/workflow-tool/__tests__/index.spec.tsx (modified, +4/-4)
  • web/app/components/tools/workflow-tool/__tests__/method-selector.spec.tsx (modified, +21/-2)
  • web/app/components/tools/workflow-tool/confirm-modal/__tests__/index.spec.tsx (modified, +5/-6)
  • web/app/components/tools/workflow-tool/confirm-modal/index.tsx (modified, +23/-24)
  • web/app/components/tools/workflow-tool/hooks/__tests__/use-configure-button.spec.ts (modified, +0/-1)
  • web/app/components/tools/workflow-tool/hooks/use-configure-button.ts (modified, +0/-1)
  • web/app/components/tools/workflow-tool/index.tsx (modified, +287/-191)
  • web/app/components/tools/workflow-tool/method-selector.tsx (modified, +38/-32)
RAW_BUFFERClick to expand / collapse

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

latest main

Cloud or Self Hosted

Self Hosted (Source)

Steps to reproduce

<img width="1324" height="1114" alt="Image" src="https://github.com/user-attachments/assets/5e607b3d-197b-491c-b974-4d742cfaee7d" />
  1. the modal layer display incorrect
  2. when choose a tool input method option, the select panel can't auto close
  3. when save the settings, the success toast will display twice

✔️ Expected Behavior

  1. the modal layer display correct
  2. when choose a tool input method option, the select panel can auto close
  3. when save the settings, the success toast will display once

❌ Actual Behavior

No response

extent analysis

TL;DR

The issue can be resolved by investigating and fixing the modal layer display, select panel auto-close, and success toast duplication issues in the self-hosted Dify application.

Guidance

  • Review the code responsible for rendering the modal layer and verify that it is correctly implemented and styled.
  • Check the event listeners and handlers for the tool input method option selection to ensure the select panel is properly closed after selection.
  • Investigate the success toast display logic to prevent duplication, potentially by adding a flag or check to prevent multiple toast displays.

Example

No code snippet can be provided without more context, but the fix may involve modifying the JavaScript code responsible for handling these interactions.

Notes

The issue seems to be related to the self-hosted version of Dify, and the provided image may contain relevant information about the issue. However, without access to the code or more details, it's difficult to provide a more specific solution.

Recommendation

Apply workaround: Investigate and fix the specific issues mentioned, as the problem seems to be related to the custom implementation of the self-hosted version.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

dify - ✅(Solved) Fix improve workflow as tool overlays [1 pull requests, 1 participants]