PR #74028: [AI-assisted] fix(cli): honor fully qualified infer model overrides

• Repository: openclaw/openclaw
• Author: brokemac79
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74028

Description (problem / solution / changelog)

Summary

• Problem: local capability model run --model provider/model could route through agent default selection instead of honoring the fully qualified provider/model override directly.
• Why it matters: explicit probes like github-copilot/... should test the requested provider/model, not the agent fallback/default path.
• What changed: qualified local model run overrides are prepared directly with prepareSimpleCompletionModel; gateway dispatch forwarding remains explicit.
• What did NOT change (scope boundary): unqualified model refs still use the existing agent default selection path.

AI-assisted: yes, built with Codex. I understand the code changes and verified the focused regression locally.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #73921
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: local model-run handling always delegated through agent-aware model preparation, even when the CLI supplied a fully qualified provider/model override.
• Missing detection / guardrail: no test asserted direct local preparation for provider-qualified model run overrides.
• Contributing context (if known): N/A

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
• Target test or file: src/cli/capability-cli.test.ts
• Scenario the test should lock in: local model run with github-copilot/model calls direct simple-completion preparation, and gateway mode forwards the explicit provider/model.
• Why this is the smallest reliable guardrail: it exercises the CLI command plumbing without live provider calls.
• Existing test that already covers this (if any): N/A
• If no new test is added, why not: N/A

User-visible / Behavior Changes

openclaw capability model run --model provider/model now honors fully qualified local provider/model overrides more directly.

Diagram (if applicable)

N/A

Security Impact (required)

• New permissions/capabilities? No
• Secrets/tokens handling changed? No
• New/changed network calls? No
• Command/tool execution surface changed? No
• Data access scope changed? No
• If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

• OS: Windows
• Runtime/container: local Node.js / pnpm workspace
• Model/provider: mocked in unit tests
• Integration/channel (if any): CLI
• Relevant config (redacted): N/A

Steps

1. Run a local model probe with --model github-copilot/<model>.
2. Confirm the CLI prepares that explicit provider/model directly.
3. Run gateway mode and confirm explicit provider/model are forwarded.

Expected

• Fully qualified model overrides select the requested provider/model.

Actual

• Before this change, local mode could go through agent default resolution first.

Evidence

• Failing test/log before + passing after

Focused local validation:

node scripts/test-projects.mjs src/cli/capability-cli.test.ts
Test Files  1 passed (1)
Tests       50 passed (50)

Human Verification (required)

• Verified scenarios: focused CLI regression tests; git diff --check before commit.
• Edge cases checked: provider-qualified local override and gateway override forwarding.
• What you did not verify: live GitHub Copilot provider call; full repo pnpm test / pnpm check.

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? Yes
• Config/env changes? No
• Migration needed? No
• If yes, exact upgrade steps: N/A

Risks and Mitigations

• Risk: changing local model-run path for qualified overrides could miss agent-specific defaults.
  • Mitigation: only provider-qualified refs take the direct path; unqualified refs continue through existing agent selection.

Changed files

• src/cli/capability-cli.test.ts (modified, +91/-0)
• src/cli/capability-cli.ts (modified, +45/-10)