openclaw - ✅(Solved) Fix install.ps1 should not leak Write-Host chatter into Main return values [1 pull requests, 2 comments, 2 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
openclaw/openclaw#72250Fetched 2026-04-27 05:32:32
View on GitHub
Comments
2
Participants
2
Timeline
4
Reactions
0
Timeline (top)
commented ×2closed ×1cross-referenced ×1

The CI run at https://github.com/openclaw/openclaw/actions/runs/24960081278 failed in the core-support-boundary built-artifact shard because test/scripts/install-ps1.test.ts observed Main returning a non-success value in the Windows PowerShell installer fixture.

Root Cause

Summary

The CI run at https://github.com/openclaw/openclaw/actions/runs/24960081278 failed in the core-support-boundary built-artifact shard because test/scripts/install-ps1.test.ts observed Main returning a non-success value in the Windows PowerShell installer fixture.

Fix Action

Fixed

PR fix notes

PR #72281: fix install.ps1 Main return handling in CI

Description (problem / solution / changelog)

Closes #72250

Summary

Testing

  • pnpm test test/scripts/install-ps1.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.full-core-support-boundary.config.ts
  • pnpm build

Changed files

  • scripts/install.ps1 (modified, +1/-1)
RAW_BUFFERClick to expand / collapse

Summary

The CI run at https://github.com/openclaw/openclaw/actions/runs/24960081278 failed in the core-support-boundary built-artifact shard because test/scripts/install-ps1.test.ts observed Main returning a non-success value in the Windows PowerShell installer fixture.

Failing surface

  • scripts/install.ps1
  • test/scripts/install-ps1.test.ts
  • CI job: build-artifacts -> core-support-boundary

Actual

PowerShell host chatter emitted through the script's custom Write-Host wrapper can be observed by the caller and interfere with Main's success return path.

Expected

The installer's Write-Host wrapper should stay side-effect-only and never contribute pipeline output that changes Main's return value.

Evidence

From the failing run:

  • test/scripts/install-ps1.test.ts > install.ps1 failure handling > keeps npm chatter out of Main's success return value
  • AssertionError: expected 1 to be +0

extent analysis

TL;DR

Modify the Write-Host wrapper in scripts/install.ps1 to prevent it from emitting output that interferes with the return value of Main.

Guidance

  • Review the implementation of the custom Write-Host wrapper in scripts/install.ps1 to ensure it does not produce any output that could be captured by the caller.
  • Verify that the wrapper only has side effects and does not contribute to the pipeline output.
  • Check the test case install.ps1 failure handling in test/scripts/install-ps1.test.ts to understand how the Write-Host wrapper's output is being captured and affecting the return value of Main.
  • Consider using a different output stream, such as the verbose or debug stream, for the Write-Host wrapper to prevent it from interfering with the return value.

Example

# Instead of using Write-Host, consider using Write-Verbose
Write-Verbose "Message" -Verbose

Notes

The solution may require changes to the Write-Host wrapper implementation and potentially the test case to ensure that the wrapper's output is properly handled.

Recommendation

Apply workaround: Modify the Write-Host wrapper to use a different output stream, such as the verbose stream, to prevent it from interfering with the return value of Main. This approach allows for a targeted fix without requiring significant changes to the existing codebase.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING