PR #54448: fix: preserve Kimi tool call arguments instead of clearing valid JSON

• Repository: openclaw/openclaw
• Author: vinsew
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/54448

Description (problem / solution / changelog)

Summary

Fixes three related bugs in the Kimi (kimi-coding/k2p5) tool call argument repair pipeline that cause tool calls to fail with empty or undefined arguments:

• tryParseMalformedToolCallArguments treats valid JSON as unfixable: When accumulated streaming JSON is already valid, JSON.parse(raw) succeeds but the function returns undefined — the same signal as "unrepairable". The caller then clears arguments, wiping correct tool parameters.
• clearToolCallArgumentsInMessage assigns {} instead of undefined: The empty object pollutes shared references. Downstream validators see a present-but-empty object and report must have required property 'command' instead of recognizing arguments as absent.
• else branch in wrapStreamRepairMalformedToolCallArguments unconditionally clears arguments: When repair returns undefined, arguments may already be correctly set via content_block_start.input (Kimi's non-incremental streaming path). Clearing here wipes them. The fix lets content_block_stop handle final argument resolution.

Root cause

Kimi k2p5 has two streaming behaviors:

1. Incremental: content_block_start with input: {}, then input_json_delta events build up arguments
2. Non-incremental: content_block_start with full input: {path: "..."}, no input_json_delta at all

The repair wrapper assumed path 1 exclusively. In path 2, partialJson stays empty, tryParseMalformedToolCallArguments("") returns undefined, and the else branch wiped the already-correct arguments.

Changes

Reproduction

With kimi-coding/k2p5:

# Before fix:
Validation failed for tool "exec":
  - command: must have required property 'command'
Received arguments: {}

# Or:
read tool called without path: toolCallId=tool_xxx argsType=undefined

Note on remaining pi-ai issues

Two additional Kimi tool call bugs exist in the upstream @mariozechner/pi-ai package (not addressed here):

• content_block_stop overwrites block.arguments with parseStreamingJson("") → {} even when partialJson is empty
• A "Kimi API bug workaround" in content_block_start converts input: {} to undefined

These require a separate fix in pi-ai. This PR addresses all bugs within OpenClaw's own codebase.

Test plan

• All 95 existing tests in attempt.test.ts pass
• New test: valid JSON arguments are preserved through the repair pipeline
• New test: arguments set by content_block_start.input survive incomplete delta attempts
• Updated test: trailing suffix growing too long preserves last valid repair instead of wiping
• TypeScript type check passes (pnpm tsgo)
• Full lint/format check passes (pnpm check)
• Manual verification with kimi-coding/k2p5 on Telegram

Fixes #54442 Fixes #53747 Refs #54366

🤖 Generated with Claude Code

Changed files

• src/agents/pi-embedded-runner/run/attempt.test.ts (modified, +93/-2)
• src/agents/pi-embedded-runner/run/attempt.ts (modified, +13/-23)

PR #56697: fix(tools): include parameter examples in validation errors to help models self-correct

• Repository: openclaw/openclaw
• Author: Co-Messi
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/56697

Description (problem / solution / changelog)

Summary

Include tool-specific parameter examples in validation error messages so models can self-correct on retry.

Problem

Models like Kimi k2p5 intermittently send empty objects ({}) instead of required tool parameters. The current error message says:

Missing required parameter: path alias. Supply correct parameters before retrying.

This is too vague — the model retries with the same empty payload, creating a loop of 5+ failed attempts.

Fix

Add a TOOL_PARAM_EXAMPLES map for read/write/edit tools. When parameter validation fails, the error now includes a concrete example:

Missing required parameter: path alias. Supply correct parameters before retrying. Example: read({"path": "/absolute/path/to/file"})

This gives the model a template to follow on the next attempt, significantly improving self-correction rates for models with weak tool-call formatting.

One-file change, 14 lines added, 4 modified. No behavior change for well-formed tool calls.

Test plan

• Change is additive — parameterValidationError gains an optional second parameter with no default behavior change
• Existing tool param tests unaffected (validated locally)
• Manual verification: Kimi k2p5 self-corrects faster with example in error response

Fixes #56376 Related: #55005, #55039, #53747, #54366

Changed files

• src/agents/pi-tools.params.ts (modified, +14/-4)

PR #57716: Agents/tools: fix empty required array bug in tool schema alias handling

• Repository: openclaw/openclaw
• Author: Leihb
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/57716

Description (problem / solution / changelog)

AI-Assisted

• This PR was created with assistance from Claude
• Testing: Unit tests updated and passing (25/26), scoped tests validate the fix
• I understand the code changes and have verified they work correctly

Summary

Fixes #44203, #37645, #57551, #55528, #54975, #54366

This PR fixes a critical bug where tool schema required arrays were being incorrectly emptied when a dding parameter aliases (e.g., file_path as alias for path). The addClaudeParamAliasesToSchema f unction was removing original parameter names from required without preserving them, causing LLMs to receive schemas with no required parameters.

Changelog Entry

• Agents/tools: fix empty required array bug in tool schema alias handling. Fixes #44203, #37645.

Problem

The addClaudeParamAliasesToSchema function was removing original parameter names (like path, oldT ext, newText) from the required array but not adding their aliases (like file_path, old_string , new_string). This caused:

1. LLMs received schemas with empty or incomplete required arrays
2. Models didn't know which parameters were actually required
3. Tool calls failed validation with "Missing required parameters" errors
4. Users experienced 100% failure rate for edit tool and other file operations

Related Issues

This bug has been reported multiple times with various symptoms:

• #44203 - Original bug report: Edit tool fails with "Missing required parameters"
• #37645 - Root cause analysis: patchToolSchemaForClaudeCompatibility empties required[] with ex act fix suggestion
• #57551 - Kimi infinite retry loop consuming tokens due to repeated validation failures
• #55528 - Write tool content parameter validation failure
• #54975 - All tools receive empty {} arguments (closed but same root cause)
• #54366 - kimi-coding/k2p5 model tool parameters empty object

Error Messages Users See

[tools] edit failed: Missing required parameters: path alias, oldText alias, newText alias. Supply cor rect parameters before retrying. [tools] read failed: Missing required parameter: path alias. Supply c orrect parameters before retrying.

Solution

1. Preserve canonical keys in required array: The addClaudeParamAliasesToSchema function no lo nger modifies the required array. Original parameter names (e.g., path) remain in required, whil e aliases (e.g., file_path) are only added to properties.

2. Add optional flag to RequiredParamGroup: Allows marking parameter groups as optional for ru ntime validation, supporting edit tool's dual-mode operation (single replacement vs. multi-replacement ).

3. Cross-field validation for edit tool: Added explicit validation to ensure edit tool receives ei ther edits array or both oldText and newText.

Changes

• src/agents/pi-tools.params.ts:

  • Add optional field to RequiredParamGroup type
  • Mark oldText/newText as optional in CLAUDE_PARAM_GROUPS.edit
  • Stop modifying required array in addClaudeParamAliasesToSchema
  • Update assertRequiredParams to skip optional groups
  • Add cross-field validation for edit tool

• src/agents/pi-tools.create-openclaw-coding-tools.adds-claude-style-aliases-schemas-without-dropping .test.ts:

  • Update test assertion to verify path remains in required

Changed files

• src/agents/pi-tools.create-openclaw-coding-tools.adds-claude-style-aliases-schemas-without-dropping.test.ts (modified, +3/-1)
• src/agents/pi-tools.params.ts (modified, +45/-8)