Issue Station
Sign In
Tools hereToolbox

transformers - 💡(How to fix) Fix `**kwargs` not passed through methods of RoFormer models

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
RAW_BUFFERClick to expand / collapse

Hi,

when working with RoFormer models, I've noticed the **kwargs option is not handled correctly. Most classes take in **kwargs but do not pass them further into the model. For example: https://github.com/huggingface/transformers/blob/5206626c48710e69fef3eadfba077cada99f37bb/src/transformers/models/roformer/modeling_roformer.py#L737-L747 This is very annoying since I want to implement a custom attention and send needed inputs through **kwargs.

The fix is trivial and I would be happy to make a PR for this if the members agree.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING