openclaw - 💡(How to fix) Fix Low-risk: Docker Go template injection, thread-ownership URL path injection, TLS env bypass [1 participants]

OPENCLAW_ALLOW_INSECURE_PRIVATE_WS=1 completely disables TLS enforcement for non-loopback WebSocket connections. The error message reveals this bypass mechanism name to anyone who triggers it. Fix: Replace boolean break-glass with narrower mechanisms (e.g., allowlist specific CIDRs). Do not disclose bypass env var names in error messages.

Fix Plan

To address the three low-severity findings, follow these steps:

1. Docker Go Template Injection

• Validate label names against the [a-zA-Z0-9._-]+ pattern using a regular expression:

const labelRegex = /^[a-zA-Z0-9._-]+$/;
if (!labelRegex.test(label)) {
  throw new Error(`Invalid label: ${label}`);
}

2. URL Path Injection

• Use encodeURIComponent() for both channelId and threadTs parameters:

fetch(`${forwarderUrl}/api/v1/ownership/${encodeURIComponent(channelId)}/${encodeURIComponent(threadTs)}`, { ... });

3. TLS Enforcement Bypass

• Replace the boolean break-glass with narrower mechanisms, such as allowlisting specific CIDRs:

const allowedCidrs = ['192.168.1.0/24', '10.0.0.0/8'];
if (allowedCidrs.some(cidr => ipInRange(ipAddress, cidr))) {
  // Allow the connection
} else {
  // Enforce TLS
}

• Remove the disclosure of bypass environment variable names in error messages:

// Instead of throwing an error with the env var name
throw new Error('TLS enforcement bypassed');

Verification

Verify that the fixes work by testing the following scenarios:

• Attempt to inject a crafted label into the Docker Go template and ensure it raises an error.
• Send a request with a crafted channelId or threadTs and verify that the URL path is correctly encoded.
• Set the OPENCLAW_ALLOW_INSECURE_PRIVATE_WS environment variable and verify that TLS enforcement is still applied.
• Test the allowlisting mechanism by connecting from an allowed and a disallowed CIDR.