openclaw - 💡(How to fix) Fix memory-core: narrative session cleanup logs spurious warning when subagent runtime is request-scoped [1 participants]

In dreaming-narrative (bundled as dist/dreaming-narrative-BFx7ugb_.js), generateAndAppendDreamNarrative() correctly falls back when the subagent runtime is request-scoped during subagent.run() — but the finally block still calls subagent.deleteSession(), which throws the same RequestScopedSubagentRuntimeError and gets logged as a warning. The cleanup path does not recognize the error class that the start path handles. 2. Check gateway logs: the fallback path runs (narrative generation used fallback ... because subagent runtime is request-scoped), but immediately after, narrative session cleanup failed is logged — same underlying error class.

• The finally block unconditionally calls params.subagent.deleteSession({ sessionKey }). In the fallback case no session was created, and the call itself throws RequestScopedSubagentRuntimeError. The catch block does not filter on error type, so it emits the misleading cleanup warning. Skip deleteSession entirely when no runId exists, and filter the request-scoped error class in the catch (symmetric with the start path):

•   	params.logger.warn(`memory-core: narrative session cleanup failed for ${params.data.phase} phase: ${formatErrorMessage(cleanupErr)}`);

•   	if (!isRequestScopedSubagentRuntimeError(cleanupErr)) params.logger.warn(`memory-core: narrative session cleanup failed for ${params.data.phase} phase: ${formatErrorMessage(cleanupErr)}`);

TL;DR

The proposed fix involves modifying the generateAndAppendDreamNarrative function to skip deleteSession when no runId exists and filter the RequestScopedSubagentRuntimeError in the catch block.

Guidance

• Verify that the isRequestScopedSubagentRuntimeError function is correctly implemented and available in the same module.
• Apply the proposed patch to the dreaming-narrative.ts file, ensuring to target the source file rather than the compiled bundle.
• Test the modified function to confirm that it correctly handles the RequestScopedSubagentRuntimeError and prevents the misleading cleanup warnings.
• Consider submitting a pull request with the proposed fix to update the source code.

Example

The proposed fix involves modifying the try block to conditionally call deleteSession and filter the error in the catch block:

--- a/src/memory-core/dreaming-narrative.ts
+++ b/src/memory-core/dreaming-narrative.ts
-		try {
+		if (runId !== null) try {
 			await params.subagent.deleteSession({ sessionKey });
 		} catch (cleanupErr) {
-			params.logger.warn(`memory-core: narrative session cleanup failed for ${params.data.phase} phase: ${formatErrorMessage(cleanupErr)}`);
+			if (!isRequestScopedSubagentRuntimeError(cleanupErr)) params.logger.warn(`memory-core: narrative session cleanup failed for ${params.data.phase} phase: ${formatErrorMessage(cleanupErr)}`);
 		}

Notes

The proposed fix assumes that the isRequestScopedSubagentRuntimeError function is correctly implemented and available in the same module. Additionally, the fix should be applied to the source dreaming-narrative.ts file rather than the compiled bundle.

Recommendation

Apply the proposed workaround by modifying the generateAndAppendDreamNarrative function to skip deleteSession when no runId exists and filter the RequestScopedSubagentRuntimeError in the catch block, as it directly addresses the root cause of the issue and prevents the misleading cleanup warnings.