PR #77664: fix(memory): skip embeddings unavailable error when searchMode=search

• Repository: openclaw/openclaw
• Author: mushuiyu886
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/77664

Description (problem / solution / changelog)

Summary

• probeEmbeddingAvailability() in qmd-manager.ts reported a misleading "QMD semantic vectors are unavailable" error when searchMode=search (BM25-only) intentionally disables vector search. The embeddings probe should return { ok: false, error: undefined } in this case since the absence of vectors is by design, not a failure condition.

Verification

• Ran pnpm test extensions/memory-core/src/memory/qmd-manager.test.ts — all 102 tests pass.
• Updated the corresponding test assertion to expect error: undefined when searchMode=search.

Real behavior proof

Behavior or issue addressed: Issue #77645: memory status --deep reports a misleading "QMD semantic vectors are unavailable" error when searchMode=search is configured. The probeEmbeddingAvailability() method unconditionally returns an error string when vectors are not available, even though searchMode=search intentionally skips vector support and only uses BM25 text search.

Real environment tested: Local dev environment, Node 22, running against main branch with the fix applied. Verified the fix by running openclaw memory status --deep equivalent code paths and reading the changed source.

Exact steps or command run after the patch: Applied the change and ran node -e to confirm qmdUsesVectors("search") returns false and probeEmbeddingAvailability() returns { ok: false, error: undefined } instead of the old error string. Ran the focused QMD manager regression suite confirming the assertion expects error: undefined.

Evidence after fix: Ran node -e "require('./extensions/memory-core/dist/...')" to confirm the probe returns { ok: false, error: undefined } when searchMode=search. Console output shows the method no longer reports a misleading error. The source change is a two-line early return in probeEmbeddingAvailability(): if (!qmdUsesVectors(this.qmd.searchMode)) { return { ok: false, error: undefined }; } which skips the vector probe entirely for BM25-only configurations. The regression assertion was updated from error: "QMD semantic vectors are unavailable" to error: undefined.

Observed result after fix: No misleading "vectors unavailable" diagnostic for BM25-only configurations. The probe returns { ok: false, error: undefined } signaling that embeddings are intentionally not used, without reporting it as a failure.

What was not tested: Live gateway with openclaw memory status --deep and a real QMD backend. Verified through source inspection and the existing unit test covering probeEmbeddingAvailability().

Closes #77645

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/memory-core/src/memory/qmd-manager.test.ts (modified, +1/-1)
• extensions/memory-core/src/memory/qmd-manager.ts (modified, +3/-0)

PR #77678: fix(memory): don't report QMD embeddings as unavailable when searchMode=search

• Repository: openclaw/openclaw
• Author: Sanjays2402
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/77678

Description (problem / solution / changelog)

Summary

When QMD is intentionally configured for BM25-only mode via memory.qmd.searchMode = "search", vectors are disabled by design. openclaw memory status --deep previously reported this configuration as an embeddings failure with the misleading line Embeddings error: QMD semantic vectors are unavailable, even though nothing was actually broken. Status now distinguishes "intentionally skipped" from "unavailable" and shows Embeddings: skipped (searchMode=search) with no error line.

Changes

• MemoryEmbeddingProbeResult (in packages/memory-host-sdk and the re-exported plugin-sdk type): added optional skipped?: boolean and skippedReason?: string fields. Backwards compatible — existing consumers that only read ok/error are unaffected.
• QmdMemoryManager.probeEmbeddingAvailability (extensions/memory-core/src/memory/qmd-manager.ts): when qmdUsesVectors(searchMode) is false (i.e. searchMode === "search"), short-circuit and return { ok: false, skipped: true, skippedReason: "searchMode=search" } instead of running the vector probe and emitting the generic "QMD semantic vectors are unavailable" error.
• runMemoryStatus renderer (extensions/memory-core/src/cli.runtime.ts): renders Embeddings: skipped (<reason>) in the muted theme color when the probe reports skipped, and suppresses the Embeddings error line in that case. ok: true and ok: false/non-skipped paths are unchanged.

Testing

• Updated the existing qmd-manager.test.ts case "skips qmd status vector probes for lexical search mode" to assert the new { ok: false, skipped: true, skippedReason: "searchMode=search" } shape (no more bogus error string).
• Added cli.test.ts case "renders embeddings as skipped when QMD probe reports skipped (issue #77645)" covering the renderer: confirms Embeddings: skipped (searchMode=search) is printed and that neither Embeddings: unavailable nor Embeddings error appear.
• Ran scoped vitest suites locally: extensions/memory-core/src/memory/qmd-manager.test.ts (102 tests), extensions/memory-core/src/cli.test.ts (52 tests, including the new one), and extensions/memory-core/src/memory/search-manager.test.ts (30 tests). All pass.

Fixes openclaw/openclaw#77645

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/memory-core/src/cli.runtime.ts (modified, +15/-3)
• extensions/memory-core/src/cli.test.ts (modified, +38/-0)
• extensions/memory-core/src/memory/qmd-manager.test.ts (modified, +4/-1)
• extensions/memory-core/src/memory/qmd-manager.ts (modified, +12/-0)
• packages/memory-host-sdk/src/host/types.ts (modified, +8/-0)
• src/plugin-sdk/memory-core-host-engine-storage.ts (modified, +8/-0)