hermes - 💡(How to fix) Fix NameError: _pool_may_recover_from_rate_limit not imported into extracted agent/conversation_loop.py [2 comments, 3 participants]

Commit 053025238 ("refactor(run_agent): extract run_conversation to agent/conversation_loop.py") moved run_conversation into agent/conversation_loop.py. The rate-limit eager-fallback branch there calls _pool_may_recover_from_rate_limit(...) as a bare, unqualified name, but the function is defined in run_agent.py and is never imported into the extracted module. The branch only executes on a provider 429 with a fallback chain configured, so it stays latent until a rate-limit event.

Affected: origin/main HEAD, agent/conversation_loop.py ~line 2335 (the bare call site).

Traceback (on a 429 from the primary provider):

File "agent/conversation_loop.py", line 2335, in run_conversation
    pool_may_recover = _pool_may_recover_from_rate_limit(
NameError: name '_pool_may_recover_from_rate_limit' is not defined

Suggested fix: route the call through the existing _ra() lazy-import helper, consistent with how other run_agent symbols are accessed post-extraction (avoids a circular import that a top-level from run_agent import ... would risk):

pool_may_recover = _ra()._pool_may_recover_from_rate_limit(