PR #84279: Fix dynamic catchall parameter interpolation in parallel routes

• Repository: vercel/next.js
• Author: wyattjoh
• State: closed | merged: True
• Link: https://github.com/vercel/next.js/pull/84279

Description (problem / solution / changelog)

Fixing a bug

• Tests added with comprehensive e2e test suite for parallel route navigations
• Error handling improved with clearer error messages for missing dynamic parameters

What?

Fixes incorrect parameter interpolation where catchall parameters in parallel routes included unintended prefix segments.

Why?

In parallel routes with dynamic catchall parameters, the parameter interpolation was incorrectly including prefix segments from the route path. For example, with a route structure like /[teamSlug]/@slot/[...catchAll], a request to /vercel/test/path would incorrectly set catchAll = ["vercel", "test", "path"] instead of the correct catchAll = ["test", "path"].

This bug affected the accuracy of dynamic parameter values in parallel routes, leading to incorrect behavior in applications relying on these parameters for routing logic.

How?

• Introduced interpolateParallelRouteParams() function that properly handles path depth traversal for complex route structures
• Refactored parameter interpolation to occur earlier in the render process, ensuring consistency across both postponed and regular rendering scenarios
• Updated the getDynamicParam() function to use pre-interpolated parameters instead of performing inline path parsing
• Added comprehensive e2e tests to cover various parallel route navigation scenarios and parameter interpolation edge cases
• Improved error handling with more descriptive error messages for missing dynamic parameters

The fix ensures that dynamic parameters are correctly extracted based on their position in the route hierarchy, respecting the boundaries defined by parallel route slots.

NAR-335

Changed files

• packages/next/errors.json (modified, +2/-1)
• packages/next/src/build/segment-config/app/app-segments.ts (modified, +1/-1)
• packages/next/src/build/segment-config/app/collect-root-param-keys.ts (modified, +1/-1)
• packages/next/src/build/webpack/loaders/next-root-params-loader.ts (modified, +1/-1)
• packages/next/src/server/app-render/app-render.tsx (modified, +26/-15)
• packages/next/src/server/app-render/create-component-tree.tsx (modified, +1/-1)
• packages/next/src/server/app-render/postponed-state.test.ts (modified, +5/-5)
• packages/next/src/server/app-render/postponed-state.ts (modified, +7/-6)
• packages/next/src/server/app-render/walk-tree-with-flight-router-state.tsx (modified, +1/-1)
• packages/next/src/shared/lib/router/utils/get-dynamic-param.test.ts (modified, +92/-362)
• packages/next/src/shared/lib/router/utils/get-dynamic-param.ts (modified, +105/-54)
• packages/next/src/shared/lib/router/utils/get-segment-param.tsx (renamed, +2/-2)
• packages/next/src/shared/lib/router/utils/parse-loader-tree.ts (renamed, +2/-2)
• test/e2e/app-dir/parallel-route-navigations/app/[teamID]/@slot/[...catchAll]/page.tsx (added, +12/-0)
• test/e2e/app-dir/parallel-route-navigations/app/[teamID]/layout.tsx (added, +21/-0)
• test/e2e/app-dir/parallel-route-navigations/app/[teamID]/sub/folder/page.tsx (added, +9/-0)
• test/e2e/app-dir/parallel-route-navigations/app/[teamID]/sub/other-folder/page.tsx (added, +12/-0)
• test/e2e/app-dir/parallel-route-navigations/app/component.client.tsx (added, +15/-0)
• test/e2e/app-dir/parallel-route-navigations/app/component.tsx (added, +34/-0)
• test/e2e/app-dir/parallel-route-navigations/app/layout.css (added, +10/-0)
• test/e2e/app-dir/parallel-route-navigations/app/layout.tsx (added, +9/-0)
• test/e2e/app-dir/parallel-route-navigations/next.config.js (added, +6/-0)
• test/e2e/app-dir/parallel-route-navigations/parallel-route-navigations.test.ts (added, +140/-0)

PR #8218: meta: upgrade to next.js 16

• Repository: nodejs/nodejs.org
• Author: ovflowd
• State: closed | merged: True
• Link: https://github.com/nodejs/nodejs.org/pull/8218

Description (problem / solution / changelog)

This PR is a draft PR for upgrading to Next.js 16.

• Development Server Works
• Production Build fails

❯ pnpm build

> @node-core/website@ prebuild /home/cwunder/GitHub/nodejs.org/apps/site
> node --run build:blog-data


> @node-core/website@ build /home/cwunder/GitHub/nodejs.org/apps/site
> node --run build:default -- --turbopack

   ▲ Next.js 16.0.0-beta.0 (Turbopack)
   - Experiments (use with caution):
     ✓ globalNotFound
     · optimizePackageImports
     ✓ parallelServerBuildTraces
     ✓ parallelServerCompiles
     ✓ turbopackFileSystemCacheForDev
     ✓ webpackBuildWorker

   Creating an optimized production build ...
 ✓ Compiled successfully in 5.1s
   Skipping validation of types
 ✓ Collecting page data in 654ms    
Error occurred prerendering page "/404". Read more: https://nextjs.org/docs/messages/prerender-error
Error [PageNotFoundError]: Cannot find module for page: /_document
    at ignore-listed frames {
  code: 'ENOENT'
}
Export encountered an error on /_error: /404, exiting the build.
 ⨯ Next.js build worker exited with code: 1 and signal: null
 ELIFECYCLE  Command failed with exit code 1.

Changed files

• .prettierignore (modified, +1/-0)
• apps/site/app/[locale]/error.tsx (modified, +5/-6)
• apps/site/app/[locale]/not-found.tsx (modified, +1/-5)
• apps/site/app/global-error.tsx (removed, +0/-34)
• apps/site/components/withNodeRelease.tsx (modified, +7/-12)
• apps/site/eslint.config.js (modified, +1/-1)
• apps/site/next-env.d.ts (modified, +1/-1)
• apps/site/next.config.mjs (modified, +5/-5)
• apps/site/open-next.config.ts (modified, +2/-3)
• apps/site/package.json (modified, +11/-10)
• apps/site/tsconfig.json (modified, +3/-2)
• apps/site/turbo.json (modified, +10/-2)
• package.json (modified, +2/-2)
• pnpm-lock.yaml (modified, +743/-255)
• pnpm-workspace.yaml (modified, +2/-1)