openclaw - 💡(How to fix) Fix No tests for any cron-cli behavior [1 comments, 2 participants]

Severity: medium / Confidence: high / Category: test-gap Triage: test-gap Detected against: openclaw v2026.5.18 (latest stable at time of scan, 2026-05-18) Tooling: clawpatch 0.3.0 + acpx/claude-sonnet-4-5 via Brad Mills protocol

Evidence

• src/cli/cron-cli/register.cron-add.ts:1-1 (None)

• src/cli/cron-cli/register.cron-edit.ts:1-1 (None)

• src/cli/cron-cli/register.cron-simple.ts:1-1 (None)

Reasoning

The feature manifest lists zero tests. The cron-cli group covers complex conditional logic (session target inference, delivery mode resolution, payload kind selection, schedule parsing, pagination), all of which are untested. The bugs found above (default announce mode, unbounded pagination, timeoutSeconds sign) would all be caught by minimal unit tests.

Recommendation

Add colocated *.test.ts files covering: (1) resolveCronCreateSchedule / resolveCronEditScheduleRequest edge cases, (2) session target inference in registerCronAddCommand, (3) delivery mode defaulting, (4) parseDurationMs and parseCronStaggerMs edge cases, (5) parseCronThreadIdOption boundary values, (6) loadCronJobForShow pagination guard.

Why existing tests miss this

No tests exist at all for this surface.

Suggested regression test

Vitest unit tests for schedule-options.ts, shared.ts parseDurationMs/parseCronStaggerMs, and thread-id-shared.ts parseCronThreadIdOption with table-driven edge cases.

Minimum fix scope

Create src/cli/cron-cli/schedule-options.test.ts and src/cli/cron-cli/shared.test.ts covering at minimum the pure-function utilities and the pagination guard.

Standardized clawpatch finding. Persistent in v2026.5.18 (not resolved by upgrading from v2026.5.12). Finding ID: fnd_sig-feat-cli-command-1de66cf308-_5a9ca92bde.