openclaw - 💡(How to fix) Fix No tests for any file in src/cli#1 group [1 comments, 2 participants]

Severity: medium / Confidence: high / Category: test-gap Triage: test-gap Detected against: openclaw v2026.5.18 (latest stable at time of scan, 2026-05-18) Tooling: clawpatch 0.3.0 + acpx/claude-sonnet-4-5 via Brad Mills protocol

Evidence

• src/cli/argv.ts:1-1 (None)

• src/cli/channel-auth.ts:1-1 (None)

• src/cli/acp-cli.ts:1-1 (None)

Reasoning

The feature manifest lists zero tests. The argv.ts file contains intricate parsing logic (isHelpOrVersionInvocation, getCommandPositionalsWithRootOptions, buildParseArgv, shouldMigrateState) with numerous branching conditions. channel-auth.ts has auth-sensitive flows (login/logout, gateway fallback, config commit). These are high-value targets for regression: a one-character change to the positional-help detection logic or the FLAG_TERMINATOR (see Finding 1) would be invisible without tests. The hardcoded '"--"' bug (Finding 1) and the Commander attribute bug (Finding 3) are both undetectable at present.

Recommendation

Add colocated *.test.ts files for at least: (1) argv.ts covering isHelpOrVersionInvocation, getCommandPathWithRootOptions, buildParseArgv, shouldMigrateState with representative argv vectors; (2) acp-cli.ts covering option parsing including --no-prefix-cwd; (3) channel-options.ts covering cache reset and dedupe behaviour.

Why existing tests miss this

No tests exist; this is the gap being reported.

Suggested regression test

vitest suite in src/cli/argv.test.ts: table-driven tests over known argv vectors for each exported function, covering help/version flags, root-option skipping, FLAG_TERMINATOR boundary, and shouldMigrateState command whitelist.

Minimum fix scope

New test files; no production code change required.

Standardized clawpatch finding. Persistent in v2026.5.18 (not resolved by upgrading from v2026.5.12). Finding ID: fnd_sig-feat-cli-command-17e3589ff2-_f363ab05b3.