openclaw - 💡(How to fix) Fix No tests for node CLI registration or daemon lifecycle [1 comments, 2 participants]

Severity: medium / Confidence: high / Category: test-gap Triage: test-gap Detected against: openclaw v2026.5.18 (latest stable at time of scan, 2026-05-18) Tooling: clawpatch 0.3.0 + acpx/claude-sonnet-4-5 via Brad Mills protocol

Evidence

• src/cli/node-cli/daemon.ts:1-1 (None)

• src/cli/node-cli/register.ts:1-1 (None)

Reasoning

The feature definition lists zero tests. The two owned files cover: port validation logic (resolveNodeDefaults), install idempotency guard, runtime selection validation, all five lifecycle verbs (start/stop/restart/install/uninstall), and status rendering with multiple code paths (not loaded, stopped, missing unit, running). None of these are exercised by automated tests. The silent-fallback port bug (finding 1) and the stdout/stderr inconsistency (finding 2) are direct consequences of this gap.

Recommendation

Add colocated daemon.test.ts and register.test.ts files. Priority scenarios: (1) resolveNodeDefaults with valid/invalid/missing port, (2) runNodeDaemonInstall already-installed short-circuit, (3) runNodeDaemonStatus output routing for each runtime status branch, (4) run action with invalid port. Use narrow mocks for resolveNodeService, loadNodeHostConfig, and buildNodeInstallPlan.

Why existing tests miss this

No tests exist for this surface area at all.

Suggested regression test

See individual findings for targeted regression tests; a broader suite should cover all branches of runNodeDaemonStatus and runNodeDaemonInstall.

Minimum fix scope

New src/cli/node-cli/daemon.test.ts covering the status and install functions with stubbed service and config dependencies.

Standardized clawpatch finding. Persistent in v2026.5.18 (not resolved by upgrading from v2026.5.12). Finding ID: fnd_sig-feat-cli-command-264278dce9-_7b719f2f7c.