openclaw - 💡(How to fix) Fix No tests for parsePort [1 comments, 2 participants]

Severity: low / Confidence: high / Category: test-gap Triage: test-gap Detected against: openclaw v2026.5.18 (latest stable at time of scan, 2026-05-18) Tooling: clawpatch 0.3.0 + acpx/claude-sonnet-4-5 via Brad Mills protocol

Evidence

• src/cli/shared/parse-port.ts:1-8 (parsePort)

export function parsePort(raw: unknown): number | null {

Reasoning

The feature manifest lists tests: []. parsePort sits at a user-input trust boundary and is the sole validation layer before a port value enters the runtime. Without tests, edge cases (null, undefined, 0, 65535, 65536, non-numeric strings, floats, negative numbers) are unverified.

Recommendation

Add a colocated src/cli/shared/parse-port.test.ts covering: null/undefined → null; non-numeric string → null; float → null; 0 → null; 1 → 1; 65535 → 65535; 65536 → null; large integer → null.

Why existing tests miss this

No test file exists for this module.

Suggested regression test

See recommendation above; also verify that the numeric-string '8080' parses correctly to 8080.

Minimum fix scope

New test file src/cli/shared/parse-port.test.ts; no production code change required for this finding alone.

Standardized clawpatch finding. Persistent in v2026.5.18 (not resolved by upgrading from v2026.5.12). Finding ID: fnd_sig-feat-cli-command-1589b7a20d-_a318798e5c.