PR #78112: [AI-assisted] fix(doctor): tolerate malformed crontab output

• Repository: openclaw/openclaw
• Author: brokemac79
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/78112

Description (problem / solution / changelog)

Summary

• Fixes #77773.
• Harden the legacy WhatsApp crontab doctor contribution so malformed, nullish, or non-string crontab output does not abort openclaw doctor.
• Harden terminal note wrapping so unexpected nullish/non-string note messages are coerced before wrapping.
• Add focused regression coverage for malformed crontab output and note message coercion.

Real behavior proof

Behavior or issue addressed: openclaw doctor could crash on partial Linux/Termux-style environments when the legacy cron probe received stdout: undefined and called .split(...). The terminal note wrapper had the same unsafe string assumption for unexpected note messages.

Real environment tested: Local OpenClaw source checkout on branch fix-doctor-cron-termux-77773, commit d7958fbb30, using corepack pnpm and Node from the workspace on Windows/PowerShell.

Exact steps or command run after this patch: Ran a PowerShell here-string containing the TSX snippet below and piped it to corepack pnpm exec tsx - from the patched checkout.

import { noteLegacyWhatsAppCrontabHealthCheck } from "./src/commands/doctor-cron.ts";
import { wrapNoteMessage } from "./src/terminal/note.ts";

const observed = [];
await noteLegacyWhatsAppCrontabHealthCheck({
  platform: "linux",
  readCrontab: async () => ({ stdout: undefined }),
});
observed.push({ case: "undefined crontab stdout", result: "completed without throwing" });
await noteLegacyWhatsAppCrontabHealthCheck({
  platform: "linux",
  readCrontab: async () => ({ stdout: 12345 }),
});
observed.push({ case: "numeric crontab stdout", result: "completed without throwing" });
observed.push({ case: "undefined note message", result: JSON.stringify(wrapNoteMessage(undefined, { maxWidth: 20, columns: 80 })) });
observed.push({ case: "numeric note message", result: wrapNoteMessage(12345, { maxWidth: 20, columns: 80 }) });
console.log(JSON.stringify(observed, null, 2));

Evidence after fix: Copied terminal output from the command above:

[
  {
    "case": "undefined crontab stdout",
    "result": "completed without throwing"
  },
  {
    "case": "numeric crontab stdout",
    "result": "completed without throwing"
  },
  {
    "case": "undefined note message",
    "result": "\"\""
  },
  {
    "case": "numeric note message",
    "result": "12345"
  }
]

Observed result after fix: The legacy cron doctor contribution completed without throwing for stdout: undefined and numeric stdout, and note wrapping returned safe text for nullish/non-string messages.

What was not tested: I did not run on live Termux/Android hardware. The proof exercises the failing OpenClaw doctor contribution boundary and note wrapper in the source checkout with the same malformed values described in the issue.

Verification

• corepack pnpm exec oxfmt --check --threads=1 src/commands/doctor-cron.ts src/commands/doctor-cron.test.ts src/terminal/note.ts src/terminal/table.test.ts CHANGELOG.md
• corepack pnpm exec oxlint src/commands/doctor-cron.ts src/commands/doctor-cron.test.ts src/terminal/note.ts src/terminal/table.test.ts
• corepack pnpm check:changelog-attributions
• git diff --check origin/main...HEAD
• $env:WT_SESSION='1'; corepack pnpm test src/commands/doctor-cron.test.ts src/terminal/table.test.ts
• corepack pnpm exec tsgo -p tsconfig.core.json --incremental --tsBuildInfoFile .artifacts/tsgo-cache/core.tsbuildinfo
• corepack pnpm exec tsgo -p test/tsconfig/tsconfig.core.test.json --incremental --tsBuildInfoFile .artifacts/tsgo-cache/core-test.tsbuildinfo
• corepack pnpm check:changed

AI-assisted

This PR was prepared with Codex assistance. I reviewed the issue, ClawSweeper guidance, changed code, and local verification before opening it.

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/commands/doctor-cron.test.ts (modified, +29/-0)
• src/commands/doctor-cron.ts (modified, +17/-4)
• src/terminal/note.ts (modified, +20/-3)
• src/terminal/table.test.ts (modified, +8/-0)