PR #68110: fix(memory-search): thread cfg through getMemoryEmbeddingProvider so doctor stops emitting plugins.allow and memory-core false positives

• Repository: openclaw/openclaw
• Author: mvanhorn
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/68110

Description (problem / solution / changelog)

Summary

• Problem: When memory is intentionally disabled (plugins.entries.memory-core.enabled: false, plugins.slots.memory: "none"), openclaw doctor --non-interactive emits two false-positive lines:
  • [plugins] plugins.allow is empty; discovered non-bundled plugins may auto-load: ...
  • Error: Bundled plugin public surface access blocked for "memory-core" via memory-core/runtime-api.js: disabled in config
• Why it matters: The reporter has memory intentionally off and a real plugins.allow allowlist. Doctor should emit a clean informational result ("No active memory plugin is registered for the current config."), not fire warnings derived from a synthesized compat config. Runtime behavior is already correct; only the report was wrong.
• What changed: Threaded cfg through the three getMemoryEmbeddingProvider call sites in src/agents/memory-search.ts so the capability-resolution chain sees the real config instead of falling back to a compat view that drops plugins.allow and plugins.entries.
• What did NOT change (scope boundary): No loader changes (src/plugins/loader.ts untouched). No public SDK or config surface changes. getMemoryEmbeddingProvider already accepts an optional second cfg argument; this PR just starts passing it. Runtime memory-search behavior is unchanged.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #68088
• Related #
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: mergeConfig in src/agents/memory-search.ts called getMemoryEmbeddingProvider without cfg at three sites. The capability-resolution chain (listMemoryEmbeddingProviders -> resolvePluginCapabilityProviders -> resolveRuntimePluginRegistry) falls back to a compat config view when cfg is missing. That compat view drops plugins.allow and plugins.entries, which makes the loader see an empty allowlist (first warning) and makes the memory-core activation guard see memory-core as effectively absent (second warning).
• Missing detection / guardrail: The only call site for mergeConfig already had the real cfg in scope (as the outer parameter of resolveMemorySearchConfig), so threading it through was mechanical - there was no test asserting it actually got passed. This PR adds one.
• Contributing context (if known): Reporter supplied a full trace stack, the root-cause analysis, and a verified diff:

  warnWhenAllowlistIsOpen (loader)
    loadOpenClawPlugins (loader)
    resolveRuntimePluginRegistry (loader)
    resolvePluginCapabilityProviders (capability-provider-runtime)
    listMemoryEmbeddingProviders (memory-embedding-provider-runtime)
    getMemoryEmbeddingProvider (memory-embedding-provider-runtime)
    mergeConfig (memory-search)
    resolveMemorySearchConfig (memory-search)
    noteMemorySearchHealth

  The reporter also confirmed locally that the patch eliminates both warnings and doctor ends with the correct informational result. Thanks to the reporter for the root-cause work.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: src/agents/memory-search.test.ts
• Scenario the test should lock in: When resolveMemorySearchConfig(cfg, agentId) runs with the reporter's disabled-memory config shape (plugins.allow: [], plugins.entries["memory-core"].enabled: false, plugins.slots.memory: "none", a non-auto provider), every getMemoryEmbeddingProvider call must receive the real cfg object rather than undefined.
• Why this is the smallest reliable guardrail: The bug was a missing argument, not a missing feature. A spy on the provider lookup that asserts cfg is passed is the tightest possible coverage for this specific regression.
• Existing test that already covers this (if any): None. src/agents/memory-search.test.ts had 23 tests before; this PR adds 1.
• If no new test is added, why not: N/A. New test added (24 passing).

This contribution was developed with AI assistance (Codex).

Changed files

• src/agents/memory-search.test.ts (modified, +33/-1)
• src/agents/memory-search.ts (modified, +6/-4)

PR #68145: fix(memory-search): pass cfg to getMemoryEmbeddingProvider calls (#68088)

• Repository: openclaw/openclaw
• Author: wade-microblueworld
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/68145

Description (problem / solution / changelog)

Summary

Fixes #68088: openclaw doctor --non-interactive emits two false positives when memory is intentionally disabled:

1. plugins.allow is empty warning (spurious — plugins.allow is set in config)
2. memory-core disabled in config error (spurious — doctor synthesizes a compat config that re-enables it)

Root Cause

Three getMemoryEmbeddingProvider() calls inside mergeConfig() and resolveMemorySearchConfig() were invoked without passing cfg. When cfg is omitted, the fallback path drops plugins.allow and plugins.entries, causing doctor to report incorrect state.

Fix

Thread cfg: OpenClawConfig through to all three getMemoryEmbeddingProvider() call sites in src/agents/memory-search.ts.

Testing

Run openclaw doctor --non-interactive with memory intentionally disabled via config. Both spurious warnings should be gone after this fix.

Changed files

• extensions/memory-core/src/dreaming-narrative.ts (modified, +8/-3)
• src/agents/memory-search.ts (modified, +5/-4)
• src/agents/pi-embedded-runner/run/incomplete-turn.ts (modified, +2/-1)
• src/agents/run-wait.ts (modified, +48/-0)
• src/agents/tools/sessions-send-tool.ts (modified, +29/-0)
• src/cli/plugins-update-selection.ts (modified, +5/-0)
• src/cron/service/timer.ts (modified, +34/-12)
• src/logging/subsystem.ts (modified, +2/-2)