Issue Station
Sign In
Tools hereToolbox

codex - 💡(How to fix) Fix Patch approval diff is empty in app-server-backed TUI Ctrl+A review [1 comments, 1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
openai/codex#18122•Fetched 2026-04-17 08:32:29
View on GitHub
Comments
1
Participants
1
Timeline
5
Reactions
0
Author
vcvvvcvcvvvc
Participants
vcvvvcvcvvvc
Timeline (top)
labeled ×4commented ×1

Fix Action

Fix / Workaround

In the app-server-backed TUI, patch approval requests can open with an empty diff body.

When a patch approval is shown and I press Ctrl+A to open the fullscreen diff review, the review pane does not display the patch content even though the file-change content exists elsewhere in the TUI.

  1. Open Codex in any workspace directory.
  2. Ask Codex to create a file, for example context.txt.
  3. Let Codex write any content into that file.
  4. Wait for the patch approval prompt to appear.
  5. Press Ctrl+A to open the approval review.
RAW_BUFFERClick to expand / collapse

What version of Codex CLI is running?

0.117.0-0.121.0

What subscription do you have?

GPT PLUS

Which model were you using?

ALL

What platform is your computer?

MacOS 13.7.8 and Debian12-13

What issue are you seeing?

In the app-server-backed TUI, patch approval requests can open with an empty diff body.

When a patch approval is shown and I press Ctrl+A to open the fullscreen diff review, the review pane does not display the patch content even though the file-change content exists elsewhere in the TUI.

<img width="893" height="594" alt="Image" src="https://github.com/user-attachments/assets/ec686e45-2eed-47bd-b99e-22b5dc545918" /> <img width="893" height="594" alt="Image" src="https://github.com/user-attachments/assets/443ab841-0df4-4a54-b9ff-db6acb7a9aae" /> <img width="893" height="594" alt="Image" src="https://github.com/user-attachments/assets/48472ec0-2f81-4126-b727-5c5815547388" />

What steps can reproduce the bug?

  1. Open Codex in any workspace directory.
  2. Ask Codex to create a file, for example context.txt.
  3. Let Codex write any content into that file.
  4. Wait for the patch approval prompt to appear.
  5. Press Ctrl+A to open the approval review.

Actual result:

  • The approval review does not show the patch diff content.
  • The diff body is empty even though Codex is proposing file changes.

Expected result:

  • The approval review should display the actual patch diff for the pending file change.

What is the expected behavior?

No response

Additional information

I investigated this issue locally and prepared a fix that restores patch diff content in the app-server-backed TUI approval flow.

The fix covers both:

  • the active-thread approval path
  • the inactive-thread / buffered approval path

I also added regression coverage and verified the fix locally.

I understand that external pull requests are invitation-only in this repository. If this approach aligns with the intended solution, I would appreciate an invitation to open a PR and submit the fix formally.

extent analysis

TL;DR

The issue with the empty diff body in the patch approval requests can be resolved by applying a fix that restores patch diff content in the app-server-backed TUI approval flow.

Guidance

  • The issue seems to be related to the display of patch diff content in the approval review pane, which is not showing the actual patch diff for the pending file change.
  • To verify the issue, follow the steps provided in the issue description, which involve opening Codex, creating a file, letting Codex write content into the file, waiting for the patch approval prompt, and pressing Ctrl+A to open the approval review.
  • The fix prepared by the investigator covers both the active-thread approval path and the inactive-thread / buffered approval path, and includes regression coverage.
  • The investigator has verified the fix locally and is seeking an invitation to open a PR and submit the fix formally.

Example

No code snippet is provided as the issue does not include any specific code references.

Notes

The issue seems to be specific to the app-server-backed TUI approval flow, and the fix prepared by the investigator may need to be reviewed and tested further before being merged into the main codebase.

Recommendation

Apply the workaround by waiting for the formal fix to be submitted and merged into the main codebase, as the investigator has already prepared a fix and is seeking an invitation to open a PR.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#ISR setup#authentication setup#request error#file not found#serialization error

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

codex - 💡(How to fix) Fix Patch approval diff is empty in app-server-backed TUI Ctrl+A review [1 comments, 1 participants]