pytorch - 💡(How to fix) Fix [pipelining] Add downstream tests to test pipelining integration with popular HF transformers architectures

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
RAW_BUFFERClick to expand / collapse

🚀 The feature, motivation and pitch

I recently tried using the pipelining module to pipeline models with various popular architectures (GPT2, Gemma, Qwen, Llama, BERT) using implementations in the HF transformers library. I encountered many issues, which I reported. Since, in my view, training large transformer models, such as those in HF transformers, is probably the main use case of the pipelining module, it would make sense that there are some tests to ensure that those models actually work. I'm not familiar with how this would be realized, or if something like this already exists, but in my mind this type of primary use case should have associated end-to-end tests to ensure they work out-of-the-box. This was not the case from my experience starting roughly about a month ago; I had to spend quite some time troubleshooting the pipelining module to actually get a basic "will it run" script to work for all the listed models when using 2.11.

I took a brief look at the tests for the pipelining module under test/distributed/pipelining. I didn't see anything the tested actual models from the HF transformers library, only handwritten unit/integration tests. I know that dynamo/compiler have extensive tests for HF transformers and timm, so I'm wondering if something like that at a smaller scale could be implemented for the pipelining module

Alternatives

No response

Additional context

https://github.com/pytorch/pytorch/issues/184361#issuecomment-4508567998

cc @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @aditvenk @weifengpy

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

pytorch - 💡(How to fix) Fix [pipelining] Add downstream tests to test pipelining integration with popular HF transformers architectures