PR #76151: fix(plugins): replace misleading stale-config warnings for ownership-blocked plugins and deduplicate suspicious-ownership diagnostics

• Repository: openclaw/openclaw
• Author: hclsys
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/76151

Description (problem / solution / changelog)

Problem

When a plugin directory is blocked by file ownership (uid mismatch), the gateway emits two categories of compounding bad UX:

Defect A — misleading "stale config entry" warnings: for every reference to the blocked plugin in config (entries, allow, deny, slots), the gateway emits plugin not found: <id> (stale config entry ignored; remove it from plugins config). This actively misdirects operators into deleting valid config blocks.

Defect B — duplicate "suspicious ownership" warnings: the same diagnostic fires once per discovery scope (scoped result + shared result) rather than once per blocked path per boot, producing 2–3 identical lines.

Addresses #76144.

Root cause

isUnsafePluginCandidate (discovery.ts) pushed a PluginDiagnostic without a pluginId field. Without a pluginId, pushRegistryDiagnostics (validation.ts) could not tell that "plugin not found for id X" corresponded to a blocked-ownership candidate — so pushMissingPluginIssue emitted the stale-config message without checking for block signals.

For Defect B: discoverOpenClawPlugins runs two separate discovery passes (scopedResult, sharedResult) each with their own seen set. The global extensions dir (roots.global) is scanned in sharedResult; if the same path also appears in extraPaths (in scopedResult), the cross-scope merge in mergeDiscoveryResult appended diagnostics unconditionally.

Changes

src/plugins/discovery.ts

• isUnsafePluginCandidate: add idHint?: string param; set pluginId: params.idHint on the pushed diagnostic; inline-dedup prevents same-array duplicates via pluginId+message key
• addCandidate: pass idHint through to isUnsafePluginCandidate; add the resolved path to seen even when blocked, so a second addCandidate call for the same path returns immediately without re-evaluating
• mergeDiscoveryResult: dedup diagnostics by pluginId+message key when merging scopedResult and sharedResult into the final result

src/config/validation.ts

• Before pushMissingPluginIssue: build blockedOwnershipPluginIds from registry diagnostics that have pluginId and contain "suspicious ownership"
• Inside pushMissingPluginIssue: if pluginId is in blockedOwnershipPluginIds, emit "plugin <id> present but blocked by file ownership; run \chown root:root <plugin-path>` to allow load"` instead of the stale-config message

src/plugins/discovery.test.ts

• New test: attaches idHint as pluginId on blocked-ownership diagnostics — asserts diagnostic.pluginId === "my-plugin" when ownershipUid mismatches
• New test: emits blocked-ownership diagnostic only once per path even when seen via multiple discovery paths — passes the same path twice via extraPaths (triggering both the scoped and shared discovery of the same dir), asserts ownershipDiags.length === 1

Test result

53 passed (53) in src/plugins/discovery.test.ts. oxlint: 0 warnings, 0 errors on all changed files.

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/config/validation.ts (modified, +16/-0)
• src/plugins/discovery.test.ts (modified, +55/-0)
• src/plugins/discovery.ts (modified, +23/-6)