hermes - 💡(How to fix) Fix Plugin system lacks webhook delivery extension point — plugins must patch core source code [2 comments, 2 participants]

TL;DR

Adding a delivery_handler to VALID_HOOKS or introducing a register_delivery_handler() API could potentially resolve the issue with custom delivery in the plugin system.

Guidance

• The current workaround involves patching webhook.py at line 87 and using patch_guard for automatic recovery, but this is not sustainable due to potential overwrites during upgrades.
• To properly address the issue, consider proposing an official API change, such as adding delivery_handler to VALID_HOOKS, to support custom delivery without modifying core code.
• Evaluate the feasibility of introducing a register_delivery_handler() function as an official API to allow for more flexible and sustainable custom delivery implementations.
• Assess the impact of such changes on the existing plugin ecosystem and potential backwards compatibility issues.

Notes

The solution hinges on the feasibility of modifying the VALID_HOOKS list or introducing a new API, which may require coordination with the project maintainers or contributors.

Recommendation

Apply workaround: Introduce a register_delivery_handler() API, as it provides a more structured approach to extending the plugin system without directly modifying core files, potentially leading to a more maintainable solution.