hermes - 💡(How to fix) Fix _priority_key raises ValueError: not enough values to unpack (expected 5, got 2)

Bug Description

_priority_key in _execute_tool_calls_concurrent() unpacks the wrong structure, causing an intermittent ValueError.

Root Cause

_execute_tool_calls_concurrent() builds:

indexed_results = list(enumerate(zip(parsed_calls, results)))

Each element has shape (idx, (parsed_5tuple, result_6tuple)) — outer idx + a 2-element pair.

The _priority_key inner function at line ~10089 tries to unpack item[1] directly as the 5-element parsed_call tuple:

idx, (tc, name, args, block_result, blocked_by_guardrail) = item

But item[1] is (parsed_5tuple, result_6tuple) — a 2-element tuple. This raises:

ValueError: not enough values to unpack (expected 5, got 2)

Fix

# Before (broken)
idx, (tc, name, args, block_result, blocked_by_guardrail) = item

# After (fixed)
idx, (parsed_call, _) = item
_, name, _, _, _ = parsed_call

Trigger Condition

Only fires when multiple tool calls run concurrently (the _execute_tool_calls_concurrent path) AND results exist for priority sorting. Single-tool batches or the sequential path are unaffected — explains the intermittent appearance.

Reproduction

Run any query that triggers 2+ concurrent tool calls (e.g. MCP search tools, parallel file reads). The error surfaces at the first tool batch entering the sorting path.

Affected Providers

All providers — this is generic Hermes code, not provider-specific.