TL;DR

Change the visibility of PrivateUse1ProfilerRegistry::registerWithKineto() from public to private or protected to prevent external callers from invoking it without proper synchronization.

Guidance

• Review the implementation of PrivateUse1ProfilerRegistry to ensure that all methods accessing shared state (factory_, registered_with_kineto_) acquire the mutex_ lock as needed.
• Verify that all legitimate callers of registerWithKineto() already hold the mutex_ lock before invoking the method.
• Consider adding a check at the beginning of registerWithKineto() to assert that the mutex_ lock is held by the caller, to help catch any misuse.
• Evaluate whether the public API contract (registerFactory, onKinetoInit) can be modified to eliminate the need for registerWithKineto() to be public.

Example

// Change the method declaration to private
class PrivateUse1ProfilerRegistry {
private:
    void registerWithKineto();
};

Notes

The fix assumes that the registerWithKineto() method is only intended to be used internally by the PrivateUse1ProfilerRegistry class. If there are legitimate external callers that need to invoke this method, additional synchronization mechanisms may be required.

Recommendation

Apply workaround: Change the visibility of PrivateUse1ProfilerRegistry::registerWithKineto() to prevent external callers from invoking it without proper synchronization, as this is the most straightforward way to prevent the data race and undefined behavior.