PR #23368: fix(oneshot): pass fallback_providers from profile config to AIAgent

• Repository: NousResearch/hermes-agent
• Author: uzunkuyruk
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/23368

Description (problem / solution / changelog)

What does this PR do?

Kanban workers are spawned as hermes -p <profile> chat -q ..., which goes through the oneshot path in hermes_cli/oneshot.py. The AIAgent was constructed without a fallback_model argument, so any fallback_providers configured in a profile's config.yaml was silently ignored — workers had no fallback chain even when one was explicitly set.

Fix: reads fallback_providers / fallback_model from the already-loaded profile cfg and passes it to AIAgent as fallback_model, mirroring the same normalization already used in the interactive CLI path (cli.py:2478).

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)

References

Fixes #23362

Checklist

• I've read the Contributing Guide
• My commit messages follow Conventional Commits
• My PR contains only changes related to this fix

Changed files

• hermes_cli/oneshot.py (modified, +26/-4)
• tools/process_registry.py (modified, +1/-1)

PR #23421: refactor(agent): decompose AIAgent constructor into config dataclasses (Phase 1)

• Repository: NousResearch/hermes-agent
• Author: dusterbloom
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/23421

Description (problem / solution / changelog)

Summary

Phase 1 of the agent core decomposition proposed in the architecture audit (#17154) and aligned with the middleware direction from #626.

The 60-parameter AIAgent.__init__ is the root cause of several recurring bugs where subagents and background agents miss critical config (see #15882, #11811, #18961, #23362). This PR introduces four focused dataclasses that group those parameters by responsibility:

Design principles

• SOLID: Single responsibility per class, Open/Closed via new fields, Interface Segregation (consumers depend only on what they need), Dependency Inversion (AIAgent depends on abstract config)
• DRY: Validation, serialization, defaults live once per class
• TDD: RED-GREEN-RED-GREEN cycle, 25 tests written before implementation
• Zero regressions: 3974 existing tests pass

Backward compatibility

Old-style positional params still work. Config objects take precedence when both are provided:

# Old way (still works)
agent = AIAgent(model="claude-sonnet-4", provider="openrouter", max_iterations=30)

# New way (config objects)
agent = AIAgent(
    provider_config=ProviderConfig(model="claude-sonnet-4", provider="openrouter"),
    budget_config=BudgetConfig(max_iterations=30),
)

Test plan

• 19 dataclass contract tests (creation, validation, serialization, roundtrip, auto-detection)
• 6 AIAgent integration tests (config objects accepted, backward compat, precedence)
• 3974 existing tests pass with zero regressions (1 pre-existing flaky failure excluded: test_same_key_replaces_stale_loop_entry)

Future phases

This is Phase 1. Subsequent phases (separate PRs):

• Phase 2: Extract AgentLoop from run_conversation() into agent/loop.py
• Phase 3: Provider-as-strategy (push all provider routing into adapters)
• Phase 4: Event-driven lifecycle (EventBus replacing scattered callback invocations)
• Phase 5: Decompose cli.py (11k LOC → focused modules)
• Phase 6: AgentHarness stable interface for plugins

Relates to #626, #17154, #3823, #21172, #15882, #11811, #18961, #23362

Changed files

• agent/config.py (added, +263/-0)
• run_agent.py (modified, +120/-0)
• tests/agent/test_config.py (added, +337/-0)