openclaw - 💡(How to fix) Fix Proxy signal handlers not removed after normal command completion [1 comments, 2 participants]

Severity: low / Confidence: medium / Category: maintainability Triage: risk Detected against: openclaw v2026.5.18 (latest stable at time of scan, 2026-05-18) Tooling: clawpatch 0.3.0 + acpx/claude-sonnet-4-5 via Brad Mills protocol

Evidence

• src/cli/run-main.ts:None-None (runCli)

onSigterm = () => shutdown(143);
onSigint = () => shutdown(130);
onExit = () => killStartedProxy();
process.once("SIGTERM", onSigterm);
process.once("SIGINT", onSigint);
process.once("exit", onExit);

Reasoning

When a proxy is started, onSigterm and onSigint are registered with process.once. The shutdown callback they invoke calls stopStartedProxy() then process.exit(exitCode). After the main command body completes, stopStartedProxy is called to tear down the proxy (setting proxyHandle = null), but the onSigterm / onSigint listeners are never explicitly removed. If SIGTERM or SIGINT arrives during the async teardown phase (memory manager close, harness disposal), the stale handler will call process.exit, skipping the remaining cleanup. The process.once guarantee means each fires at most once, so there is no repeated-execution risk, but the forced exit could race with in-flight teardown I/O.

Reproduction

Start a CLI command that triggers proxy launch, then send SIGTERM during the async teardown window (e.g. closeCliMemoryManagers). Teardown steps after the signal handler's process.exit call are skipped.

Recommendation

Remove the SIGTERM/SIGINT listeners once the command completes and stopStartedProxy has returned:

if (onSigterm) process.off("SIGTERM", onSigterm);
if (onSigint) process.off("SIGINT", onSigint);

Place this before the await-chain for teardown, inside the finally block.

Why existing tests miss this

Signal-during-teardown race conditions are difficult to unit test and no tests are listed for run-main.ts.

Minimum fix scope

Add explicit process.off calls for onSigterm and onSigint in the finally/teardown block of runCli in src/cli/run-main.ts.

Standardized clawpatch finding. Persistent in v2026.5.18 (not resolved by upgrading from v2026.5.12). Finding ID: fnd_sig-feat-cli-command-0c37e1d71a-_327cf2a1fb.