Issue Station
Sign In
Tools hereToolbox

dify - ✅(Solved) Fix [Refactor/Chore] Remove unused Ruff ignore rules [1 pull requests, 1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
langgenius/dify#35101•Fetched 2026-04-14 05:56:40
View on GitHub
Comments
0
Participants
1
Timeline
3
Reactions
1
Author
WH-2099WH-2099
Participants
WH-2099WH-2099
Assignees
WH-2099WH-2099
Timeline (top)
assigned ×1closed ×1cross-referenced ×1

Remove unused ignore entries from api/.ruff.toml, including global ignore rules with zero current hits and stale per-file-ignores entries that no longer match any live file or diagnostic.

Root Cause

Remove unused ignore entries from api/.ruff.toml, including global ignore rules with zero current hits and stale per-file-ignores entries that no longer match any live file or diagnostic.

Fix Action

Fixed

PR fix notes

PR #35102: chore: remove unused Ruff ignore rules

Description (problem / solution / changelog)

Summary

Fixes #35101

Removes unused global ignore rules and stale per-file-ignores entries from api/.ruff.toml. The deleted entries currently suppress no Ruff diagnostics, and some of the per-file ignores point to files that no longer exist in the repository.

Screenshots

BeforeAfter
N/AN/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Changed files

  • api/.ruff.toml (modified, +0/-15)
RAW_BUFFERClick to expand / collapse

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Remove unused ignore entries from api/.ruff.toml, including global ignore rules with zero current hits and stale per-file-ignores entries that no longer match any live file or diagnostic.

Motivation

Unused Ruff suppressions make the lint configuration harder to trust and maintain. Cleaning them up keeps the backend lint rules aligned with the current codebase and reduces noise for future maintenance.

Additional Context

The cleanup was validated by re-running Ruff counts without the configured ignores to confirm the removed entries currently have zero matches.

extent analysis

TL;DR

Remove unused ignore entries from api/.ruff.toml to maintain a clean and trustworthy lint configuration.

Guidance

  • Review the api/.ruff.toml file to identify global ignore rules with zero current hits and stale per-file-ignores entries.
  • Remove the unused ignore entries to keep the lint configuration aligned with the current codebase.
  • Re-run Ruff counts without the configured ignores to validate the cleanup and confirm the removed entries have zero matches.
  • Consider automating the cleanup process to regularly remove unused ignore entries and maintain a clean lint configuration.

Notes

This guidance assumes that the Ruff configuration is correctly set up and that the removal of unused ignore entries will not introduce any new linting issues.

Recommendation

Apply workaround: Remove unused ignore entries from api/.ruff.toml to maintain a clean and trustworthy lint configuration, as this will help reduce noise for future maintenance and keep the backend lint rules aligned with the current codebase.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#api#ssr#conversation history#tool integration#LLM response

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

dify - ✅(Solved) Fix [Refactor/Chore] Remove unused Ruff ignore rules [1 pull requests, 1 participants]