dify - 💡(How to fix) Fix [1.14.0 regression] file_service.upload_file fails with "Upload file <uuid> not found" when scoped FileAccessController is active [1 pull requests]

# CURRENT (buggy)
if not upload_file.source_url:
    upload_file.source_url = file_helpers.get_signed_file_url(upload_file_id=upload_file.id)
    # ↑ Calls _assert_upload_file_access() which queries DB → row not yet inserted → raises "not found"

with self._session_maker(expire_on_commit=False) as session:
    session.add(upload_file)
    session.commit()  # ← Commit happens AFTER

_assert_upload_file_access() in file_runtime.py only fires when current_scope() is not None, which is the case during workflow runtime execution. So the
bug only manifests when:
1. A workflow is being executed (FileAccessController scope is active), AND
2. That execution calls file_service.upload_file() on a fresh new file.

This is why /v1/files/upload (no scope) sometimes works while internal workflow upload (with scope) always fails.


Suggested fix

Swap the order: commit first, then generate source_url:

with self._session_maker(expire_on_commit=False) as session:
    session.add(upload_file)
    session.commit()  # ← commit FIRST so the row exists for assertion

if not upload_file.source_url:
    upload_file.source_url = file_helpers.get_signed_file_url(upload_file_id=upload_file.id)
    with self._session_maker(expire_on_commit=False) as session:
        session.merge(upload_file)
        session.commit()


Related

Closes / supersedes #35764 (same root cause, different surface symptom).


Affected scope

- ❌ Workflow runtime internal file uploads
- ❌ Workflow Tool execution that returns file outputs
- ✅ Knowledge Base / Dataset upload (verified working)
- ✅ Existing pgvector embedding / RAG search


Reproduction frequency

6 occurrences in 6 hours under normal usage.


Environment

Docker Compose deployment, GCE Ubuntu 22.04, external Cloud SQL pgvector 0.8.1, Cloud Run reverse proxy.