openclaw - 💡(How to fix) Fix resolveBuiltInModelSuppression runs the same 48-plugin load twice back-to-back via independent caches [1 comments, 2 participants]

Environment

• openclaw 2026.4.26

Summary

During a single message dispatch, the 48-bundled-provider load for "built-in model suppression" runs twice, back-to-back (~125s + ~125s = ~250s wasted) when both catalog-hook and compat-hook paths are triggered. The two paths maintain independent caches and neither sees the other's result.

Reproduction

1. Enable multiple agents so both catalog-hook and compat-hook paths fire (observed with two feishu bots + bot-identity retry during the same dispatch)
2. Observe two back-to-back load-miss key=f6f6fef581 events (identical cacheKey) in the log:

02:03:15 load-miss key=f6f6fef581
  from: at resolveProviderPluginsForCatalogHooks (provider-runtime:283)
        <- at resolveProviderBuiltInModelSuppression (provider-runtime:627)
        <- at resolveBuiltInModelSuppression (model-suppression:92)
02:05:18 load-done key=f6f6fef581 elapsedMs=123427

02:05:19 load-miss key=f6f6fef581  <-- same key, 1s after previous done
  from: at resolveProviderCompatHookPlugins (provider-runtime:343)
        <- at applyProviderResolvedModelCompatWithPlugins (provider-runtime:369)
        <- at normalizeResolvedModel (model:188)
02:07:25 load-done key=f6f6fef581 elapsedMs=125639

Root Cause

• resolveProviderPluginsForCatalogHooks (provider-runtime L260) caches in catalogHookProvidersCache keyed by {workspaceDir, plugins}.
• resolveProviderPluginsForHooks (provider-runtime L63) caches in its own cacheBucket keyed by buildHookProviderCacheKey which includes providerRefs.
• Both eventually call resolvePluginProviders with cache: false, so the loader's LRU cache is also bypassed.
• When one path populates its cache, the other path does not benefit.

The catalog-hook path is meant for "list all providers"; the compat-hook path is for "get compat hooks for a specific resolved model". When both trigger for the same set of provider plugins, they duplicate work.

Suggested Fix

Either: (a) Let resolveProviderPluginsForHooks consult catalogHookProvidersCache as a fallback when its own bucket misses, or (b) Share a single result cache keyed by (workspaceDir, cfg, onlyPluginIds) at a higher level than both paths.

Impact

Up to ~125s per dispatch when both paths fire (observed on multi-agent gateway). On single-agent dispatch only the first path runs.

Related: #73729, #73728