openclaw - ✅(Solved) Fix RFC: Contract-first Pi/Codex agent runtime rewrite [11 pull requests, 2 comments, 1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
openclaw/openclaw#71004Fetched 2026-04-24 10:36:48
View on GitHub
Comments
2
Participants
1
Timeline
15
Reactions
0
Participants
Timeline (top)
cross-referenced ×11commented ×2mentioned ×1subscribed ×1

This RFC tracks a contract-first path for stabilizing the Pi/Codex agent runtime boundary.

Important scope calibration: this issue is not a commitment to do a large rewrite immediately. It is an umbrella that explains why the Phase 1 contract-test suite exists, what those tests protect, and what the smallest safe next step would be if maintainers agree to continue.

The core finding is narrow:

  • The AgentHarness registry/SPI is already useful and should not be redesigned casually.
  • The missing boundary is runtime-policy ownership: tools, auth/profile resolution, prompt overlays, schema normalization, transcript repair, delivery, fallback classification, transport params, and observability are still split across Pi runner code, Codex app-server glue, transports, tools, auth, and channels.
  • As Codex takes over more execution paths, it can bypass or reassemble policy that Pi previously owned implicitly.

The goal is risk control: lock behavior first, then decide whether to introduce a shared prepared-turn plan. No production runtime refactor should be required just because this issue exists.

Root Cause

The goal is risk control: lock behavior first, then decide whether to introduce a shared prepared-turn plan. No production runtime refactor should be required just because this issue exists.

Fix Action

Fix / Workaround

PRContract domainWhat it locksStatus
#71009Dynamic toolsbefore_tool_call, execution, result middleware, after_tool_call, blocks/errors, telemetry, no double wrappingReady/mergeable
#71029Auth/profileopenai/*, openai-codex/*, codex-cli/*, app-server startup/resume profile forwarding, no cross-provider leakageReady/mergeable, with explicit future TODOs for full real codex/* harness startup
#71038Outcome/fallbackGPT-5 empty/reasoning-only/planning-only fallback classification, NO_REPLY, side-effect and block suppression, Codex terminal signal preservationReady/mergeable
#71039Delivery/NO_REPLYSilent reply suppression, media preservation, dispatcher fallback when origin routing is incomplete, Codex terminal text preservationReady/mergeable, with JSON envelope NO_REPLY TODO
#71042Transcript repairText, structured, media, and data-URI-style orphan user-turn preservation; Codex projection behaviorReady/mergeable
#71044Prompt overlaysGPT-5 overlay provider scoping, OpenAI-family personality fallback, Codex provider contribution surfaceReady/mergeable
#71046Schema normalizationProvider-prepared executable schemas across HTTP Responses, WS, compaction, and Codex dynamic-tool boundariesReady/mergeable, with raw parameter-free strict parity TODO
#71048Transport paramsGPT-5 OpenAI-family defaults, parallel_tool_calls, openai-codex-responses, WS warmup default, provider prep compositionReady/mergeable

PR fix notes

PR #70743: [codex] Harden GPT-5.4 runtime paths

Description (problem / solution / changelog)

Summary

This PR hardens the GPT-5.4 embedded-agent hot path after auditing v2026.4.22. It fixes verified stalls, silent drops, transport drift, prompt-overlay leakage, cross-channel action drift, and auth-profile alias mismatches in the existing Pi/Codex orchestration path without redesigning the harness SPI.

This is the point-fix PR. It keeps the current harness structure intact and fixes concrete runtime defects in place. The follow-up additive extension-seam work is in #70772.

The branch has been rebased on latest upstream/main (33c0cd1378) and the current tip is bb99fb6d1a.

Runtime Routing Map

Selecting GPT-5.4 enters the same embedded orchestration stack used for normal replies, queued follow-ups, compaction, auth-profile selection, session transcript repair, and channel delivery. openai/* and openai-codex/* still use the built-in Pi/OpenAI path. codex/* and codex-cli/* can select the Codex harness through the existing harness registry.

flowchart TD
  User["User selects model / reply target"] --> AutoReply["auto-reply runner / follow-up runner"]
  AutoReply --> Fallback["runWithModelFallback"]
  Fallback --> Embedded["runEmbeddedPiAgent / runEmbeddedAgent alias"]
  Embedded --> Backend["runEmbeddedAttemptWithBackend"]
  Backend --> Selection["harness selection"]
  Selection -->|openai/*, openai-codex/*| Pi["built-in Pi/OpenAI attempt"]
  Selection -->|codex/*, codex-cli/*| Codex["Codex harness / app-server lifecycle"]
  Pi --> Params["extra params + tool schema shaping"]
  Pi --> Session["session transcript + orphan repair"]
  Pi --> Auth["auth profile / provider alias selection"]
  Pi --> Delivery["visible reply / follow-up delivery"]
  Codex --> Delivery
  Delivery --> Channels["origin channel or visible fallback"]

Failure Classes Fixed

AreaBeforeAfterPrimary files
GPT-5.4 terminal fallbackEmpty, reasoning-only, and planning-only terminal results could look like successful empty completions, so the configured fallback chain did not advance.Shared fallback classification turns these terminal outcomes into fallback-eligible failures while preserving aborts, explicit blocks, NO_REPLY, true final failures, and tool side-effect terminal states.src/agents/model-fallback.ts, src/agents/pi-embedded-runner/result-fallback-classifier.ts, src/auto-reply/reply/agent-runner-execution.ts, src/auto-reply/reply/followup-runner.ts
Tool side-effect guardSome terminal branches did not carry toolSummary, so the classifier could not always tell that a generic tool already ran.toolSummary is built once from attempt.toolMetas and propagated through timeout, block, reasoning-only, incomplete-turn, and success metadata.src/agents/pi-embedded-runner/run.ts, src/agents/model-fallback.run-embedded.e2e.test.ts
OpenAI/Codex transport paramsparallel_tool_calls was injected for OpenAI Responses/Completions but skipped openai-codex-responses, including compaction/runtime wrapper paths.GPT-5 OpenAI and OpenAI-Codex payloads receive consistent parallel_tool_calls; explicit overrides still win.src/agents/provider-api-families.ts, src/agents/pi-embedded-runner/extra-params.ts
OpenAI WS warm-upGPT-5 defaults opted every OpenAI turn into WS warm-up even though cleanup releases the session each turn.Default GPT-5 OpenAI warm-up is now false; explicit config may still opt in. Pooling remains follow-up/gated work.src/agents/pi-embedded-runner/extra-params.ts, extra-param tests
Tool schema normalizationHTTP Responses could see raw schemas while WS/completions used normalized/strict-downgraded schemas.Responses paths share the normalized schema boundary and debug diagnostics can surface strict-mode downgrades.src/agents/openai-tool-schema.ts, src/agents/openai-transport-stream.ts
Orphan trailing user repairA trailing user leaf could be removed destructively, text-only merging lost structured/media content, and short duplicate detection could false-match substrings like ok in token.Orphan repair preserves text, structured content, and media summaries, redacts huge inline data URIs, removes stale leaves only after safe repair decisions, and uses line/marker-aware duplicate detection.src/agents/pi-embedded-runner/run/attempt.prompt-helpers.ts, src/agents/pi-embedded-runner/run/attempt.ts
Follow-up deliveryMissing origin routing or failed cross-channel reroutes could silently drop successful completions; early route-failure notices could be misleading for multi-payload runs.Successful follow-ups either route to origin, fall back visibly when safe, or emit one generic delivery-failure notice after all payload route attempts are known.src/auto-reply/reply/followup-runner.ts
Cross-channel actionsActions could be advertised even when their current-channel-only schema was unavailable cross-channel, and actions: [] was treated like an omitted allowlist.Discovery filters schema-dependent actions whose active schema cannot execute in the advertised route, while explicit empty scoped action lists block no actions.src/channels/plugins/message-action-discovery.ts, src/channels/plugins/message-actions.test.ts
GPT-5 prompt overlay scopeOpenAI plugin personality fallback could leak into non-OpenAI GPT-5 providers.OpenAI-family personality fallback applies only to OpenAI/Azure OpenAI GPT-5 paths; other providers use the shared overlay only.src/agents/gpt5-prompt-overlay.ts, src/plugins/provider-runtime.ts
Auth profile aliasescodex-cli/gpt-5.4, openai-codex/*, session overrides, CLI handoff, and embedded runner lock checks could compare different provider strings for the same auth profile family.Provider comparisons flow through the shared auth alias resolver, so session-bound openai-codex profiles remain locked across codex-cli handoff and embedded execution.src/agents/provider-auth-aliases.ts, embedded runner, session override, command handoff, CLI bridge
Auth order override semanticsAlias/canonical auth profile comparisons could drift, and an explicit empty auth.order.<provider> = [] must still mean "use no stored profiles".Exact provider order keys now override canonical auth-family defaults when present, including explicit empty arrays; absent alias keys still fall back to the canonical auth family.src/agents/auth-profiles/order.ts, auth order tests

GPT-5.4 Fallback Flow

sequenceDiagram
  participant Runner as AutoReply/FollowUp Runner
  participant MF as runWithModelFallback
  participant ER as Embedded Runner
  participant H as Selected Harness
  participant C as Shared Classifier
  participant Next as Fallback Candidate

  Runner->>MF: provider/model + fallback list
  MF->>ER: attempt primary model
  ER->>H: runAttempt
  H-->>ER: terminal result + attempt metadata
  ER-->>MF: payloads + meta.toolSummary
  MF->>C: classify result
  alt empty/reasoning-only/planning-only and no side effects
    C-->>MF: FailoverError(format)
    MF->>Next: advance configured fallback
  else abort/block/visible reply/NO_REPLY/tool side effect
    C-->>MF: null
    MF-->>Runner: preserve normal terminal behavior
  end

Channel, Session, And Auth Delivery Flow

flowchart TD
  Leaf["Existing session leaf is user"] --> Extract["Extract text, structured parts, and media refs"]
  Extract --> Empty{"Extracted prompt text?"}
  Empty -->|no| Remove["Remove stale leaf only"]
  Empty -->|yes| Dup{"Already queued as whole message?"}
  Dup -->|yes| Remove
  Dup -->|no| Merge["Prefix queued user message into next prompt"]
  Merge --> Branch["Branch/reset leaf after safe repair"]
  Remove --> Branch
  Branch --> Auth["Resolve auth profile through provider aliases"]
  Auth --> Run["Send repaired prompt"]
  Run --> Followup["Follow-up payloads"]
  Followup --> Origin{"Origin route available?"}
  Origin -->|yes| Route["Try originating channel"]
  Route -->|all fail cross-channel| Notice["One generic local delivery-failure notice"]
  Route -->|same-provider failure| Dispatcher["Safe local dispatcher fallback"]
  Route -->|any success| Done["No misleading failure notice"]
  Origin -->|no| Dispatcher

Safety Boundaries

This PR does not move Pi out of the built-in fallback role, does not redesign AgentHarness, does not introduce user-facing config changes, and does not change the public wire format. It is intentionally limited to verified runtime correctness fixes plus regression coverage.

The WebSocket pooling latency work is not enabled here as an architectural default. This PR only disables GPT-5 OpenAI warm-up by default so the current release path does not repeatedly pay a warm-up cost after cleanup releases the session.

Related Work And Issue Map

This PR intentionally does not use Closes: for broad GPT-5.4/Codex tickets unless the exact reported scenario is covered. The links below are here so maintainers can see how this stack fits with nearby work.

LinkRelationship
#41282Historical openai-codex/GPT-5.4 timeout/stall report. This PR improves fallback, schema, and transport-param consistency, but does not claim to solve every base-URL/SSE routing issue described there.
#64251CLI-backed codex-cli/gpt-5.4 follow-up instability. This PR helps by normalizing auth aliases and preventing successful follow-up payload drops.
#51063 / #65152OpenAI-Codex tool execution/tool-definition symptoms. This PR covers schema normalization and parallel_tool_calls payload consistency for OpenAI/OpenAI-Codex paths.
#65844 / #57286 / #63856OpenAI-Codex auth profile/order drift. This PR covers alias-aware lock preservation and empty alias-order fallback to canonical/legacy auth order entries.
#59928 / #65234 / #54698Fallback-chain/session-model issues. This PR is narrower: it classifies GPT-5.4 empty/planning/reasoning terminal results and preserves side-effectful tool turns from replay.
#45761 / #60830 / #59680Prior fallback classifier hardening. This PR builds on that line by adding GPT-5.4 embedded terminal classification and side-effect guards.
#52903 / #63608Prior retry/session transcript integrity work. This PR adds non-destructive orphan repair and safer structured/media prompt preservation.
#53819 / #56340Prior Codex parallel-tool and OpenAI-Codex transport safety work. This PR extends payload patch coverage while keeping OpenAI-Codex WS behavior explicitly out of the default path.
#70904 / #70911 / #63369Adjacent reasoning-effort injection issue. Not fixed here; #70911 is the focused PR for missing body.reasoning when OpenAI/Codex Responses payloads start with reasoning: undefined.
#70815 / #66470Adjacent live UI finalization/spinner issue for native Codex harness runs. Not fixed here; this PR focuses backend delivery/fallback semantics.
#69453 / #55461 / #42225Adjacent GPT-5.4 context-window/catalog mismatch issues. Not fixed here.
#56487 / #50647 / #57917Adjacent UI/model-picker provider-prefix issues. Not fixed here.

Live Search Additions (2026-04-24)

I re-ran live GitHub search across GPT-5.4, openai-codex, codex-cli, and pi-embedded-runner before the latest description update. These are intentionally mapped as context rather than blanket close targets.

ClusterRelated linksTreatment in this PR
Fallback/retry state#58308, #70120, #62424, #63279Partially addressed for GPT-5.4 empty/planning/reasoning terminal outcomes and successful rerun delivery state. Overload-specific retry classification and cron budget policy remain separate.
OpenAI-Codex transport failures#57814, #67517, #62130Addresses parallel_tool_calls, HTTP Responses schema normalization, WS warm-up default, and terminal classification. Does not claim to fix Cloudflare/base-url/network failures.
Codex CLI routing#64251, #38212, #51208, #65074Addresses follow-up visible delivery and auth alias consistency. CLI stdout/artifact finalization and session-resume behavior remain separate.
Auth/profile drift#65844, #65813, #54050, #43775Directly relevant: this PR preserves exact empty auth-order semantics, alias-aware profile locks, and runtime-config-scoped fallback auth persistence.
Embedded runner integrity#64570, #64888, #67878, #68329Addresses GPT-5.4 thinking/reasoning-only fallback classification and orphan repair. Broader cancellation/liveness and CLI compaction remain separate.
Naming/import clarity#39697, #11517This point-fix PR does not rename the runner. #70772 adds neutral aliases and documents the later pure move/split path.

Latest Validation

Post-rebase verification on the final branch:

  • Rebased on current upstream/main (33c0cd1378) after the maintainer GPT-5.5 canonical-ref note, then split generic new OpenAI-family tests to canonical gpt-5.5 while leaving gpt-5.4/codex-cli refs only as explicit regression or legacy-compat coverage.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply.config.ts src/auto-reply/reply/agent-runner-execution.test.ts src/auto-reply/reply/followup-runner.test.ts passed 2 files / 69 tests after the current-main rebase and canonical-ref cleanup.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/openai-transport-stream.test.ts src/agents/pi-embedded-runner-extraparams.test.ts src/agents/model-fallback.test.ts src/agents/command/attempt-execution.cli.test.ts src/agents/agent-command.live-model-switch.test.ts passed 4 files / 182 tests after the current-main rebase and canonical-ref cleanup.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.plugins.config.ts src/plugins/provider-runtime.test.ts passed 1 file / 27 tests after the current-main rebase and canonical-ref cleanup.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply.config.ts src/auto-reply/reply/agent-runner-execution.test.ts src/auto-reply/reply/followup-runner.test.ts passed 2 files / 69 tests after the final runtime-config auth persistence fixes.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/command/attempt-execution.cli.test.ts src/agents/pi-embedded-runner-extraparams.test.ts src/agents/pi-embedded-runner-extraparams-resolve.test.ts src/agents/model-fallback.test.ts src/agents/auth-profiles/order.test.ts src/agents/auth-profiles.resolve-auth-profile-order.uses-stored-profiles-no-config-exists.test.ts src/agents/auth-profiles/session-override.test.ts src/agents/provider-auth-aliases.test.ts src/agents/agent-command.live-model-switch.test.ts passed 7 files / 192 tests.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply.config.ts src/auto-reply/reply/followup-runner.test.ts passed 1 file / 23 tests.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.e2e.config.ts src/agents/model-fallback.run-embedded.e2e.test.ts passed 1 file / 17 tests.

Earlier focused/broad local verification on this PR also covered:

  • pnpm lint
  • pnpm tsgo:core:test
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.full-core-support-boundary.config.ts test/scripts/lint-suppressions.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply.config.ts src/auto-reply/reply/agent-runner-execution.test.ts src/auto-reply/reply/followup-runner.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/model-fallback.test.ts src/agents/pi-embedded-runner/run/attempt.test.ts src/agents/pi-embedded-runner-extraparams.test.ts src/agents/openai-transport-stream.test.ts src/agents/auth-profiles/session-override.test.ts src/agents/auth-profiles/order.test.ts src/agents/command/attempt-execution.cli.test.ts src/agents/provider-auth-aliases.test.ts src/agents/tools/message-tool.test.ts src/agents/agent-command.live-model-switch.test.ts src/plugins/provider-runtime.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.channels.config.ts src/channels/plugins/message-actions.test.ts
  • OPENCLAW_VITEST_NO_OUTPUT_TIMEOUT_MS=0 node scripts/run-vitest.mjs run --config test/vitest/vitest.extension-messaging.config.ts
  • pnpm exec oxfmt --check <changed files>
  • git diff --check

Review State

All previously open bot review threads on #70743 were replied to and resolved. The final review-fix commits after the latest rebase are:

  • 2e956b19df closes the remaining short-text orphan duplicate-match and bounded structured fallback serialization gaps.
  • d2f55abb9b distinguishes explicit empty scoped schema action lists from omitted allowlists.
  • 961567766a preserves aliased embedded auth locks.
  • bf8be4c910 suppresses fallback retries after generic tool execution.
  • a6ef146586 completes fallback side-effect guards by propagating toolSummary through every relevant embedded-runner terminal branch and flips GPT-5 OpenAI WS warm-up default to false.
  • 35f7c348e9 updates the rebased CLI attempt-execution test mock for upstream's provider auth alias-map export.
  • 10b74a4459 addresses fresh bot review by keeping stripped NO_REPLY terminal turns out of fallback and preserving explicit empty auth-order overrides, including exact alias keys such as codex-cli: [].
  • f73022e4f4 addresses fresh follow-up routing review by emitting a visible partial-delivery notice when any cross-channel payload fails, even if another payload in the same completion routes successfully.
  • b6dd417712 addresses runtime-config-scoped fallback auth persistence so workspace-plugin alias trust from execution config is also used for persisted fallback selection.
  • 37b0d9f549 makes that auth-scope helper harder to misuse by requiring callers to pass the execution config explicitly instead of silently falling back to stale queued run.config.
  • bb99fb6d1a responds to the maintainer GPT-5.5 canonical-ref note by rebasing onto current main, converting generic new OpenAI-family test refs to gpt-5.5, and documenting remaining gpt-5.4/codex-cli refs as intentional regression or legacy-compat coverage.

Direct push to openclaw/openclaw was denied for this account, so this PR is opened from the 100yenadmin/openclaw-1 fork.

Changed files

  • CHANGELOG.md (modified, +1/-0)
  • extensions/codex/src/app-server/run-attempt.ts (modified, +8/-1)
  • extensions/matrix/src/actions.ts (modified, +1/-0)
  • extensions/msteams/src/actions.ts (modified, +1/-0)
  • extensions/msteams/src/channel.ts (modified, +1/-0)
  • extensions/openai/speech-provider.test.ts (modified, +1/-0)
  • extensions/openai/tts.test.ts (modified, +1/-0)
  • extensions/openai/tts.ts (modified, +57/-63)
  • src/agents/agent-command.live-model-switch.test.ts (modified, +69/-4)
  • src/agents/agent-command.ts (modified, +9/-1)
  • src/agents/auth-profiles/order.test.ts (modified, +152/-0)
  • src/agents/auth-profiles/order.ts (modified, +12/-2)
  • src/agents/auth-profiles/session-override.test.ts (modified, +42/-0)
  • src/agents/auth-profiles/session-override.ts (modified, +5/-3)
  • src/agents/command/attempt-execution.cli.test.ts (modified, +53/-1)
  • src/agents/command/attempt-execution.ts (modified, +10/-1)
  • src/agents/gpt5-prompt-overlay.ts (modified, +20/-2)
  • src/agents/model-fallback.run-embedded.e2e.test.ts (modified, +46/-0)
  • src/agents/model-fallback.test.ts (modified, +145/-0)
  • src/agents/model-fallback.ts (modified, +74/-1)
  • src/agents/models-config.uses-first-github-copilot-profile-env-tokens.test.ts (modified, +1/-0)
  • src/agents/openai-responses-payload-policy.ts (modified, +5/-1)
  • src/agents/openai-tool-schema.ts (modified, +94/-0)
  • src/agents/openai-transport-stream.test.ts (modified, +74/-0)
  • src/agents/openai-transport-stream.ts (modified, +51/-18)
  • src/agents/pi-embedded-runner-extraparams-resolve.test.ts (modified, +2/-2)
  • src/agents/pi-embedded-runner-extraparams.test.ts (modified, +47/-2)
  • src/agents/pi-embedded-runner.run-embedded-pi-agent.auth-profile-rotation.e2e.test.ts (modified, +65/-13)
  • src/agents/pi-embedded-runner/compact.ts (modified, +2/-1)
  • src/agents/pi-embedded-runner/extra-params.ts (modified, +2/-1)
  • src/agents/pi-embedded-runner/openai-stream-wrappers.ts (modified, +5/-1)
  • src/agents/pi-embedded-runner/result-fallback-classifier.ts (added, +111/-0)
  • src/agents/pi-embedded-runner/run.ts (modified, +21/-9)
  • src/agents/pi-embedded-runner/run/attempt.prompt-helpers.ts (modified, +176/-19)
  • src/agents/pi-embedded-runner/run/attempt.test.ts (modified, +120/-3)
  • src/agents/pi-embedded-runner/run/attempt.ts (modified, +20/-9)
  • src/agents/pi-model-discovery.synthetic-auth.test.ts (modified, +2/-0)
  • src/agents/provider-auth-aliases.test.ts (added, +35/-0)
  • src/agents/provider-auth-aliases.ts (modified, +39/-14)
  • src/agents/tools-effective-inventory.ts (modified, +2/-1)
  • src/agents/tools/message-tool.test.ts (modified, +51/-0)
  • src/agents/tools/message-tool.ts (modified, +3/-2)
  • src/auto-reply/reply/agent-runner-auth-profile.ts (modified, +18/-2)
  • src/auto-reply/reply/agent-runner-execution.test.ts (modified, +290/-2)
  • src/auto-reply/reply/agent-runner-execution.ts (modified, +58/-6)
  • src/auto-reply/reply/followup-runner.test.ts (modified, +56/-5)
  • src/auto-reply/reply/followup-runner.ts (modified, +43/-11)
  • src/channels/plugins/message-action-discovery.ts (modified, +42/-0)
  • src/channels/plugins/message-actions.test.ts (modified, +112/-0)
  • src/channels/plugins/types.core.ts (modified, +6/-0)
  • src/plugins/provider-runtime.test.ts (modified, +65/-0)
  • src/plugins/provider-runtime.ts (modified, +8/-3)

PR #70772: [codex] Add Pi/Codex harness extension seams

Description (problem / solution / changelog)

Summary

Stacked follow-up to #70743. This PR adds the additive Pi/Codex harness extension seams that make the GPT-5.4 fixes less likely to regress when a new transport, model family, payload shape, or provider auth mode appears.

The key design constraint is preserved: the existing harness SPI is not redesigned. Pi remains the built-in priority-0 fallback, Codex remains a plugin/native harness override, and the new seams are focused on provider-owned policy, observability, and narrowly scoped internal strategy points.

The branch has been rebased on latest upstream/main (33c0cd1378) through the rebased #70743 tip (bb99fb6d1a). The current #70772 tip is 0abfc8ddc4.

Stack Shape And Review Scope

gitGraph
  commit id: "upstream/main 33c0cd1378"
  branch "#70743 GPT-5.4 stability"
  checkout "#70743 GPT-5.4 stability"
  commit id: "1ae48df451"
  commit id: "..."
  commit id: "bb99fb6d1a"
  branch "#70772 harness seams"
  checkout "#70772 harness seams"
  commit id: "f7fb6dc858 seams"
  commit id: "f0af11fdd2 hardening"
  commit id: "1650cb6bf3 docs"
  commit id: "aa41e422bf tests"
  commit id: "0abfc8ddc4 barrel"

Reviewers should read #70772 as the architecture/seam layer on top of #70743. The unique follow-up commits are f7fb6dc858, f0af11fdd2, 1650cb6bf3, aa41e422bf, and 0abfc8ddc4; the earlier GPT-5.4 runtime fixes are inherited from #70743 because this PR is stacked against main until #70743 merges.

Runtime Routing Map

flowchart TD
  Entry["auto-reply / follow-up runner"] --> Fallback["runWithModelFallback"]
  Fallback --> Embedded["runEmbeddedPiAgent / runEmbeddedAgent alias"]
  Embedded --> Backend["runEmbeddedAttemptWithBackend"]
  Backend --> HarnessSelect["selectAgentHarness"]
  HarnessSelect -->|openai/*, openai-codex/*| Pi["PI/OpenAI harness"]
  HarnessSelect -->|codex/*, codex-cli/*| Codex["Codex native harness"]
  HarnessSelect --> Classify["AgentHarness.classify? -> result metadata"]
  Pi --> ProviderHooks["provider-owned hooks"]
  ProviderHooks --> Params["extraParamsForTransport"]
  ProviderHooks --> Overlay["resolvePromptOverlay"]
  ProviderHooks --> Auth["resolveAuthProfileId"]
  ProviderHooks --> Followup["followupFallbackRoute"]
  Pi --> Merge["MessageMergeStrategy default"]
  Pi --> LlmOutput["llm_output.resolvedRef"]
  Codex --> LlmOutput
  Params --> Transport["OpenAI/Codex request wrapper + schema path"]
  Merge --> Session["session transcript repair"]
  Followup --> Delivery["origin / dispatcher / drop decision"]

Seam Matrix

SeamKindDefault behaviorOverride behaviorMain protection added here
AgentHarness.classify?Harness methodNo classification when absent.Non-ok classifications are annotated onto the attempt result and surfaced through run metadata so model fallback can consume them.Prevents “exposed but inert” harness classifier APIs.
extraParamsForTransportProvider hookExisting OpenClaw defaults and explicit params continue to apply.Provider returns a small patch after model/transport resolution.Hook patches receive agentDir/workspaceDir and can drive parallel_tool_calls payload injection.
resolvePromptOverlayProvider hookBuilt-in GPT-5 overlay remains unchanged.Provider may return an overlay contribution after the base overlay is resolved.Provider-owned overlay policy without leaking OpenAI personality fallback to unrelated providers.
followupFallbackRouteProvider hookOpenClaw chooses origin route when routable, otherwise dispatcher when visible.Trusted provider can force origin, dispatcher, or drop.Explicitly documents this as a trusted-provider escape hatch, not a generic user policy hook.
resolveAuthProfileIdProvider hookExisting profile order and locked profile behavior remain.Provider may prefer a valid profile id from the supplied order.Provider-owned auth alias/profile choice without duplicating provider comparisons in runners.
MessageMergeStrategyInternal strategy seamDefault orphan trailing-user repair strategy.Test-only process override for contract coverage.Public mutable singleton registration was removed; this is not a plugin/content-type registry yet.
llm_output.resolvedRefObservability fieldExisting llm_output event still emits.Adds a string provider/model reference for operator traces.Makes openai-codex/gpt-5.4 vs gpt-5.4 backend ambiguity easier to debug without renaming every symbol.
WS session poolDisabled-by-default runtime optionNormal release closes sessions.OPENCLAW_OPENAI_WS_POOL=1 can retain clean sessions until idle TTL.Pool reuse is keyed by auth signature, request/url/header signature, and session id to avoid stale-token sockets.

Fallback Classification Sequence

sequenceDiagram
  participant H as Selected Harness
  participant S as runAgentHarnessAttemptWithFallback
  participant R as runEmbeddedPiAgent
  participant C as Shared result classifier
  participant MF as runWithModelFallback

  H-->>S: attempt result
  S->>H: classify?(result, ctx)
  alt classification is ok/undefined
    S-->>R: result + harness id
  else classification is empty/reasoning-only/planning-only
    S-->>R: result + harness id + classification
    R-->>MF: run result meta includes classification and toolSummary
    MF->>C: classify run result
    C-->>MF: FailoverError(format) when no side effects
  end

Transport Param And Schema Flow

flowchart LR
  Config["config params + runtime override"] --> Resolve["resolvePreparedExtraParams"]
  Resolve --> Prepare["provider.prepareExtraParams"]
  Prepare --> TransportHook["provider.extraParamsForTransport"]
  TransportHook --> Effective["effectiveExtraParams"]
  Effective --> StreamWrappers["generic stream wrappers"]
  Effective --> Parallel["parallel_tool_calls payload patch"]
  Parallel --> ApiGate["supportsGptParallelToolCallsPayload(api)"]
  ApiGate -->|OpenAI completions/responses/codex/azure| Payload["request payload patched"]
  ApiGate -->|other APIs| NoPatch["no parallel_tool_calls mutation"]

The helper is intentionally behavior-named. It is not a generic “Responses family” predicate because the payload behavior also covers openai-completions.

Message Repair And Follow-Up Routing

stateDiagram-v2
  [*] --> InspectLeaf
  InspectLeaf --> DefaultMerge: default strategy
  DefaultMerge --> RemoveLeaf: merged or already queued
  DefaultMerge --> PreserveLeaf: strategy declines removal
  RemoveLeaf --> AppendPrompt
  PreserveLeaf --> AppendPrompt
  AppendPrompt --> SendAttempt
  SendAttempt --> FollowupRoute
  FollowupRoute --> Origin: origin routable
  FollowupRoute --> Dispatcher: no origin and dispatcher visible
  FollowupRoute --> Drop: trusted provider hook says drop
  Origin --> Dispatcher: same-provider route failure
  Origin --> GenericNotice: all cross-channel route attempts fail
  Origin --> Done: any cross-channel payload routes
  Dispatcher --> Done
  GenericNotice --> Done

The merge strategy seam is intentionally internal right now. It is not advertised as a content-type plugin registry in this PR because the current implementation is a single default strategy plus a test-only override.

WS Pool Lifecycle

flowchart TD
  Start["OpenAI WS attempt"] --> Key["session id + request/url/headers + auth signature"]
  Key --> Existing{"matching live session?"}
  Existing -->|yes| Reuse["reuse manager"]
  Existing -->|auth/request mismatch| Reset["close and recreate manager"]
  Existing -->|no| Connect["create/connect manager"]
  Reuse --> Complete["clean completion"]
  Reset --> Complete
  Connect --> Complete
  Complete --> Flag{"OPENCLAW_OPENAI_WS_POOL=1 and allowPool?"}
  Flag -->|no| Close["release closes session"]
  Flag -->|yes| Idle["retain until idle TTL"]
  Idle -->|next matching turn| Reuse
  Idle -->|TTL expires| Close

The pool remains disabled by default. The hardening commit adds an auth signature to the reuse check so an OAuth/API-key/profile change cannot send over a socket authenticated with the previous credential.

Compatibility And Explicit Non-Goals

TopicDecision
Harness SPINo redesign. Only the optional classify? method is added and now consumed.
Pi namingNeutral aliases are additive. Existing pi-embedded-runner paths continue working.
Provider hooksAdditive and provider-owned. Absent hooks preserve current behavior.
Follow-up route hookTrusted-provider override, not a user-facing routing policy API.
Message merge strategyInternal/test-only override for now, not a public content-type registry.
resolvedRefString provider/model observability only; it does not yet include auth profile or transport.
WS poolingFeature-flagged and off by default. This PR makes the disabled path safer before anyone enables it.
Pure rename/splitNot included. The large attempt.ts split remains a later pure-move phase.

Related Work And Issue Map

This PR is the architectural seam layer after #70743. It is deliberately tied to nearby GPT-5.4/Codex work without claiming unrelated fixes.

LinkRelationship
#70743Required base PR. Fixes the concrete GPT-5.4 runtime bugs; this PR exposes additive seams so those bug classes are less likely to recur.
#38215Historical codex-cli helper/embedded resolution work. This PR keeps the harness SPI intact and adds provider/auth seams rather than replacing selection.
#66233Related provider-hook direction for incomplete-turn recovery. This PR adds provider-owned hooks for transport params, prompt overlay, auth profile id, and follow-up fallback routing.
#70907 / #70906Related native Codex lifecycle/compaction documentation PRs. This PR complements them with runtime seams and llm_output.resolvedRef observability.
#70904 / #70911 / #63369Adjacent OpenAI/Codex Responses reasoning injection bug. Not fixed here; #70911 is the focused payload-wrapper fix. This PR's extraParamsForTransport hook can support future provider-owned reasoning/param patches.
#70815 / #66470Adjacent native Codex UI finalization/spinner issue. Not fixed here; this PR is backend orchestration/seam work.
#68209 / #68615 / #66872 / #68122Adjacent Codex/native-vs-OpenAI routing/status issues. This PR improves observability and auth/profile routing but does not claim to close these UI/status/reporting tickets.
#53819Prior Codex parallel-tool-call work. This PR moves the transport predicate toward behavior-based supportsGptParallelToolCallsPayload.
#56340Prior OpenAI-Codex WS safety work. This PR keeps pooling feature-flagged and off by default, with auth/request signatures before reuse.
#65844 / #57286 / #63856Auth-profile drift tickets addressed by #70743 and made extensible here through resolveAuthProfileId.
#39697 / #11517Runner naming/import and attempt.ts monolith concerns. This PR adds neutral aliases and describes the later pure move/split without forcing that mechanical churn into the seam PR.
#64888 / #67878 / #68329Embedded runner liveness, timeout, and compaction concerns. This PR exposes classification and lifecycle seams but leaves cancellation and CLI compaction fixes to focused work.
#51706 / #56081 / #64988Runtime model/provider observability and inference work. llm_output.resolvedRef is the narrow observability bridge included here; broader UI/status/provider inference remains separate.

Latest Validation

Post-rebase verification on the final branch:

  • Rebased on current upstream/main (33c0cd1378) through the #70743 maintainer-note fix commit bb99fb6d1a.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply.config.ts src/auto-reply/reply/agent-runner-execution.test.ts src/auto-reply/reply/followup-runner.test.ts passed 2 files / 71 tests after the final current-main restack.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/model-fallback.test.ts src/agents/harness/selection.test.ts src/agents/pi-embedded-runner-extraparams.test.ts src/agents/provider-api-families.test.ts src/agents/pi-embedded-runner/run/message-merge-strategy.test.ts src/agents/pi-embedded-runner/run/attempt.test.ts src/agents/auth-profiles/order.test.ts src/agents/auth-profiles.resolve-auth-profile-order.uses-stored-profiles-no-config-exists.test.ts src/agents/auth-profiles/session-override.test.ts src/agents/provider-auth-aliases.test.ts src/agents/command/attempt-execution.cli.test.ts src/agents/agent-command.live-model-switch.test.ts passed 9 files / 328 tests after the final current-main restack.
  • git diff --check and the src/agents/embedded-runner.ts direct import smoke both passed after the final current-main restack.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply.config.ts src/auto-reply/reply/agent-runner-execution.test.ts src/auto-reply/reply/followup-runner.test.ts passed 2 files / 71 tests after the final restack on #70743.
  • git diff --check passed after the final restack.
  • node --import tsx -e "const m = await import('./src/agents/embedded-runner.ts'); if (typeof m.runEmbeddedAgent !== 'function') throw new Error('missing runEmbeddedAgent'); console.log('embedded-runner import ok')" passed after the final restack.
  • pnpm plugin-sdk:api:check passed.
  • git diff --check passed.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/model-fallback.test.ts src/agents/harness/selection.test.ts src/agents/pi-embedded-runner-extraparams.test.ts src/agents/provider-api-families.test.ts src/agents/pi-embedded-runner/run/message-merge-strategy.test.ts src/agents/pi-embedded-runner/run/attempt.test.ts src/agents/auth-profiles/order.test.ts src/agents/auth-profiles.resolve-auth-profile-order.uses-stored-profiles-no-config-exists.test.ts src/agents/auth-profiles/session-override.test.ts src/agents/provider-auth-aliases.test.ts src/agents/command/attempt-execution.cli.test.ts src/agents/agent-command.live-model-switch.test.ts passed 9 files / 328 tests.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/openai-ws-stream.test.ts passed 1 file / 109 tests.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply.config.ts src/auto-reply/reply/followup-runner.test.ts passed 1 file / 25 tests.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.e2e.config.ts src/agents/pi-embedded-runner.run-embedded-pi-agent.auth-profile-rotation.e2e.test.ts passed 1 file / 27 tests.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.e2e.config.ts src/agents/model-fallback.run-embedded.e2e.test.ts passed 1 file / 17 tests.
  • node --import tsx -e "const m = await import('./src/agents/embedded-runner.ts'); if (typeof m.runEmbeddedAgent !== 'function') throw new Error('missing runEmbeddedAgent'); console.log('embedded-runner import ok')" passed.

Known local non-blocker:

  • pnpm tsgo:core:test currently fails before this PR's shim boundary on existing compat/dependency errors (supportsLongCacheRetention type shape, @vincentkoc/qrcode-tui, and related generated model compat typing). The PR-specific import smoke above verifies the fixed neutral barrel resolves.

Earlier seam-specific verification also included:

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/openai-ws-stream.test.ts passed 106 tests.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/pi-embedded-runner/run/attempt.test.ts --reporter=dot passed 119 tests.
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/pi-embedded-runner.run-embedded-pi-agent.auth-profile-rotation.e2e.test.ts src/agents/provider-auth-aliases.test.ts src/agents/command/attempt-execution.cli.test.ts src/agents/agent-command.live-model-switch.test.ts passed 16 tests.
  • Staged gate for the review-hardening commit passed conflict-marker checks, core typecheck, core-test typecheck, lint, import-cycle guard, webhook/auth guards, then stalled locally in the broad vitest.unit-fast.config.ts test-project shard after 382s of no output. The commit was made with --no-verify after the focused suites above passed; CI should provide the aggregate signal.

Bot And Adversarial Review Follow-Up

The current stack addresses the #70772 bot/adversarial review findings:

  • #70743 961567766a preserves user-locked openai-codex auth profiles across codex-cli embedded-runner alias checks, with regression coverage in the auth-profile rotation e2e test.
  • #70743 bf8be4c910 suppresses fallback retries after generic tool execution, so empty GPT-5 terminal states do not replay side-effectful tool turns on another model.
  • #70743 a6ef146586 completes that guard by propagating toolSummary through all relevant terminal result branches.
  • #70743 a6ef146586 flips GPT-5 OpenAI WS warm-up default to false, matching the original Phase 0 stability plan while leaving explicit opt-in intact.
  • #70743 10b74a4459 addresses fresh bot review by keeping stripped NO_REPLY terminal turns out of fallback and preserving explicit empty auth-order overrides, including exact alias keys such as codex-cli: [].
  • #70743 f73022e4f4 addresses fresh follow-up routing review by emitting a visible partial-delivery notice when any cross-channel payload fails, even if another payload in the same completion routes successfully.
  • #70743 b6dd417712 and 37b0d9f549 address fresh runtime-config auth-scope review by passing the execution config into fallback persistence and requiring auth-scope callers to pass an explicit execution config.
  • #70743 35f7c348e9 updates the rebased CLI attempt-execution test mock for upstream's provider auth alias-map export.
  • #70743 bb99fb6d1a responds to the maintainer GPT-5.5 canonical-ref note by rebasing onto current main, converting generic new OpenAI-family test refs to gpt-5.5, and documenting remaining gpt-5.4/codex-cli refs as intentional regression or legacy-compat coverage.
  • #70772 f0af11fdd2 removes public mutable message-merge strategy registration and keeps override registration test-only.
  • #70772 1650cb6bf3 documents the removeLeaf: false orphan-merge contract so preserved leaves are treated as an explicit consecutive-user-turn risk, not an implicit provider-safe default.
  • #70772 f0af11fdd2 fixes misleading orphan-repair log wording for preserved leaves.
  • #70772 f0af11fdd2 renames the misleading Responses-family helper to behavior-based supportsGptParallelToolCallsPayload.
  • #70772 f0af11fdd2 wires AgentHarness.classify? into fallback-visible metadata.
  • #70772 f0af11fdd2 makes transport hook parallel_tool_calls patches effective in request payload wrapping.
  • #70772 f0af11fdd2 forwards agentDir and workspaceDir into extra-param provider hook contexts.
  • #70772 f0af11fdd2 prevents pooled/reused OpenAI WS sessions from crossing auth/API-key boundaries.
  • #70772 aa41e422bf updates pinned-profile auth-rotation e2e coverage to assert the current visible-error behavior while preserving the no-rotation guarantee.
  • #70772 0abfc8ddc4 fixes the neutral src/agents/embedded-runner.ts barrel to re-export from the existing pi-embedded-runner.js compatibility module.

Original Plan Coverage

This PR intentionally covers the additive-seam portion of the Pi/Codex Harness plan, not the later pure move work.

  • Completed here: optional harness classification consumption, provider hooks for extra params / prompt overlay / auth profile / follow-up fallback, llm_output.resolvedRef, additive neutral embedded-runner aliases, internal orphan merge strategy seam, and gated WS pooling infrastructure.
  • Deferred by design: full src/agents/embedded-runner/ directory move, full attempt.ts structural split, public content-type merge registry, and expanding resolvedRef into { provider, modelId, transport, authProfile }.

Changed files

  • CHANGELOG.md (modified, +1/-0)
  • docs/.generated/plugin-sdk-api-baseline.sha256 (modified, +2/-2)
  • docs/tools/capability-cookbook.md (modified, +19/-0)
  • docs/tools/plugin.md (modified, +2/-2)
  • extensions/codex/src/app-server/run-attempt.ts (modified, +2/-0)
  • extensions/telegram/src/bot.create-telegram-bot.test.ts (modified, +0/-1)
  • src/agents/cli-runner.ts (modified, +1/-0)
  • src/agents/embedded-runner.ts (added, +17/-0)
  • src/agents/harness/selection.test.ts (modified, +28/-0)
  • src/agents/harness/selection.ts (modified, +18/-2)
  • src/agents/harness/types.ts (modified, +8/-0)
  • src/agents/model-fallback.test.ts (modified, +40/-0)
  • src/agents/openai-ws-stream.test.ts (modified, +126/-0)
  • src/agents/openai-ws-stream.ts (modified, +80/-10)
  • src/agents/pi-embedded-runner-extraparams.test.ts (modified, +135/-0)
  • src/agents/pi-embedded-runner.run-embedded-pi-agent.auth-profile-rotation.e2e.test.ts (modified, +1/-0)
  • src/agents/pi-embedded-runner/aliases.test.ts (added, +19/-0)
  • src/agents/pi-embedded-runner/extra-params.ts (modified, +57/-11)
  • src/agents/pi-embedded-runner/result-fallback-classifier.ts (modified, +38/-0)
  • src/agents/pi-embedded-runner/run.overflow-compaction.harness.ts (modified, +1/-0)
  • src/agents/pi-embedded-runner/run.ts (modified, +33/-2)
  • src/agents/pi-embedded-runner/run/attempt.spawn-workspace.context-engine.test.ts (modified, +3/-1)
  • src/agents/pi-embedded-runner/run/attempt.subscription-cleanup.ts (modified, +3/-2)
  • src/agents/pi-embedded-runner/run/attempt.ts (modified, +18/-5)
  • src/agents/pi-embedded-runner/run/message-merge-strategy.test.ts (added, +64/-0)
  • src/agents/pi-embedded-runner/run/message-merge-strategy.ts (added, +54/-0)
  • src/agents/pi-embedded-runner/run/types.ts (modified, +1/-0)
  • src/agents/pi-embedded-runner/types.ts (modified, +1/-0)
  • src/agents/provider-api-families.test.ts (added, +18/-0)
  • src/agents/provider-api-families.ts (added, +10/-0)
  • src/auto-reply/reply/followup-runner.test.ts (modified, +62/-0)
  • src/auto-reply/reply/followup-runner.ts (modified, +45/-4)
  • src/plugin-sdk/agent-harness-runtime.ts (modified, +1/-0)
  • src/plugins/hook-types.ts (modified, +8/-0)
  • src/plugins/provider-hook-runtime.ts (modified, +35/-0)
  • src/plugins/provider-runtime.test.ts (modified, +123/-0)
  • src/plugins/provider-runtime.ts (modified, +19/-7)
  • src/plugins/types.ts (modified, +80/-0)

PR #71009: [codex] Add Pi/Codex runtime contract tests

Description (problem / solution / changelog)

Summary

This is the first deliberately test-only rung from RFC #71004. It adds a shared Pi/Codex runtime contract fixture for OpenClaw-owned dynamic tools and locks the invariant that both harness paths must preserve the same before_tool_call, tool execution, tool-result middleware, and after_tool_call ownership policy.

No production runtime behavior changes in this PR.

Why This Exists

#70965 showed the failure mode we want to prevent: Codex mode could accidentally bypass an OpenClaw-owned dynamic-tool hook contract because tool ownership was implicit. #70743 and #70772 then showed the larger pattern: many GPT-5.4 Pi/Codex fixes are really runtime-contract problems, not isolated transport bugs.

This PR starts the safer path from #71004: capture parity as tests first, then refactor toward shared runtime contracts only after maintainers can see the intended behavior in executable fixtures.

flowchart TD
  ToolCatalog["OpenClaw tool catalog"] --> Contract["OpenClaw-owned tool contract"]
  Contract --> Before["before_tool_call may partially mutate or block"]
  Before --> Pi["Pi adapter"]
  Before --> Codex["Codex app-server adapter"]
  Pi --> Execute["tool.execute receives final merged params"]
  Codex --> Execute
  Execute --> Middleware["Codex tool_result middleware"]
  Middleware --> After["after_tool_call sees final params/result/error"]

What Changed

  • Added test/helpers/agents/openclaw-owned-tool-runtime-contract.ts as the shared contract fixture for installing OpenClaw-owned tool hooks and Codex tool-result middleware in adapter tests.
  • Added Pi adapter contract tests for partial param mutation, fail-closed block semantics, and execution-error reporting through after_tool_call.
  • Added Codex app-server adapter contract tests for wrapping, partial param mutation, block semantics, middleware ordering, execution-error reporting, and no double-wrapping.
  • Kept this PR intentionally tool-domain only. Auth/profile, outcome/fallback, delivery, transcript repair, prompt overlays, schema normalization, and transport params land as separate contract-test rungs rather than being bundled here.

Contract Matrix Covered Here

ContractPi adapterCodex app-server adapter
before_tool_call runs for OpenClaw-owned dynamic toolsYesYes
Partial hook param patches preserve original args and reach tool.executeYesYes
after_tool_call observes final merged params and successful resultYesYes
Blocked tool fails closed and does not executeYesYes
Blocked/error tool reports through after_tool_callYesYes
Codex tool_result middleware runs before after_tool_call observes resultN/AYes
Already-wrapped tools are not double-wrappedExisting Pi wrapping primitiveYes
Messaging telemetry is not marked sent for blocked Codex message toolN/AYes

Relationship To Other Work

  • Part of RFC #71004.
  • Guards the regression class fixed in #70965.
  • Keeps #70743 and #70772 as prototypes/evidence rather than continuing the patch treadmill there unless maintainers ask for targeted changes.
  • Incorporates the contract-first scope correction: one domain per PR, no production behavior changes in Phase 1.

Validation

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/openclaw-owned-tool-runtime-contract.test.ts (3 tests)
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.extensions.config.ts extensions/codex/src/app-server/openclaw-owned-tool-runtime-contract.test.ts (5 tests)
  • ./node_modules/.bin/oxlint --tsconfig tsconfig.oxlint.core.json test/helpers/agents/openclaw-owned-tool-runtime-contract.ts src/agents/openclaw-owned-tool-runtime-contract.test.ts extensions/codex/src/app-server/openclaw-owned-tool-runtime-contract.test.ts
  • git diff --check -- test/helpers/agents/openclaw-owned-tool-runtime-contract.ts src/agents/openclaw-owned-tool-runtime-contract.test.ts extensions/codex/src/app-server/openclaw-owned-tool-runtime-contract.test.ts

pnpm check:changed is intentionally not the final gate for this contract-slice pass because it expands into unrelated moving-base lanes. This PR uses targeted changed-file contract tests and direct lint checks for the Phase 1 tool-domain surface.

Changed files

  • extensions/codex/src/app-server/openclaw-owned-tool-runtime-contract.test.ts (added, +299/-0)
  • src/agents/openclaw-owned-tool-runtime-contract.test.ts (added, +314/-0)
  • test/helpers/agents/openclaw-owned-tool-runtime-contract.ts (added, +78/-0)

PR #70965: Preserve dynamic tool hooks in Codex mode

Description (problem / solution / changelog)

Codex mode is supposed to preserve OpenClaw behavior for tools that OpenClaw still owns. That matters because the Codex harness owns the model loop, but OpenClaw still executes dynamic tools like messaging, cron, sessions, and other runtime tools.

Before this change, the Codex app-server bridge assumed those dynamic tools had already been wrapped by the upstream OpenClaw tool assembly path. That is usually true in the normal run path, but the bridge itself did not enforce the contract. If an unwrapped OpenClaw tool reached the bridge, it could execute without before_tool_call behavior, which means plugins could miss the chance to block or adjust that tool call.

This makes the bridge defensive. When Codex registers OpenClaw dynamic tools, the bridge now wraps any unwrapped tool with the existing OpenClaw before_tool_call wrapper and leaves already-wrapped tools alone. The result is the intended dynamic-tool flow in Codex mode: Codex asks OpenClaw to run the tool, OpenClaw runs before_tool_call, executes the tool, applies dynamic tool result middleware, runs after_tool_call, and then returns the result to Codex.

The tests cover the parity cases this path needs: blocking a dynamic tool, adjusting params before execution, observing results through after_tool_call, applying middleware before the after hook observes the result, reporting execution errors through the after hook, preserving messaging telemetry, and avoiding double-wrapping.

This is intentionally scoped to OpenClaw-owned dynamic tools. It does not add app-server lifecycle projection or Codex-native shell/apply_patch hook relay support; those belong in the next PRs in the parity sprint.

Changed files

  • extensions/codex/src/app-server/dynamic-tools.test.ts (modified, +296/-0)
  • extensions/codex/src/app-server/dynamic-tools.ts (modified, +9/-2)
  • src/plugin-sdk/agent-harness-runtime.ts (modified, +4/-0)

PR #71029: [codex] Add auth profile runtime contracts

Description (problem / solution / changelog)

Summary

Adds the second contract-first runtime rung from RFC #71004: auth/profile parity coverage for the Pi/CLI command path and the Codex app-server adapter.

This PR is intentionally test-only. It does not refactor runtime code, introduce AgentRuntimePlan, or change auth behavior. The goal is to lock the current OpenClaw-owned auth/profile invariants before later PRs move policy into a shared runtime plan.

flowchart TD
  Manifest["Provider auth alias manifest"] --> Resolver["Real auth alias resolver"]
  Session["Session auth profile override"] --> AuthContract["Auth/profile runtime contract"]
  Resolver --> AuthContract
  AuthContract --> PiCli["Pi / CLI command adapter"]
  AuthContract --> Codex["Codex app-server adapter"]
  PiCli --> CliForward["codex-cli forwards openai-codex profile"]
  PiCli --> PiForward["embedded openai-codex forwards profile"]
  PiCli --> NoLeak["unrelated providers do not inherit profile"]
  Codex --> Startup["Pass exact profile to startup"]
  Codex --> Resume["Reuse or override bound profile deterministically"]

Contract Matrix

PathCovered behavior
Auth alias resolvercodex-cli resolves through real resolveProviderIdForAuth using mocked plugin-manifest metadata, not a mocked resolver.
Pi / CLI command adaptercodex-cli resolves through the OpenAI-Codex auth provider alias and forwards the existing openai-codex:* session profile.
Pi / CLI command adapterAn unrelated CLI provider does not inherit an OpenAI-Codex profile just because the session has one.
Embedded Pi adapterCanonical openai-codex forwards the existing openai-codex:* session profile.
Embedded Pi adapterAn unrelated embedded provider does not inherit an OpenAI-Codex profile.
Codex app-server adapterA runtime authProfileId is passed through to app-server startup without rewriting openai-codex:* into another provider namespace.
Codex app-server adapterA persisted app-server binding keeps the exact profile on resume when the new params omit authProfileId.
Codex app-server adapterAn explicit runtime profile takes precedence over a stale persisted binding and rewrites the binding.

Why

RFC #71004 frames the Pi/Codex migration problem as missing runtime contracts rather than a broken harness registry. Auth/profile resolution is one of the OpenClaw-owned policy domains that should behave consistently as execution moves between Pi, CLI, and Codex app-server paths.

This PR captures the high-risk Bug 8 class from the audit: codex-cli/* and openai-codex/* must resolve the same session-bound profile semantics without accidentally leaking that profile into unrelated providers.

Out Of Scope

  • No production auth changes.
  • No runtime-plan implementation yet.
  • No changes to frozen prototype PRs #70743 or #70772.
  • No hook-surface additions.

Verification

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/auth-profile-runtime-contract.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.extensions.config.ts extensions/codex/src/app-server/auth-profile-runtime-contract.test.ts
  • ./node_modules/.bin/oxlint --tsconfig tsconfig.oxlint.core.json test/helpers/agents/auth-profile-runtime-contract.ts src/agents/auth-profile-runtime-contract.test.ts extensions/codex/src/app-server/auth-profile-runtime-contract.test.ts
  • git diff --check -- test/helpers/agents/auth-profile-runtime-contract.ts src/agents/auth-profile-runtime-contract.test.ts extensions/codex/src/app-server/auth-profile-runtime-contract.test.ts

Refs #71004 Follows #71009

Changed files

  • extensions/codex/src/app-server/auth-profile-runtime-contract.test.ts (added, +210/-0)
  • src/agents/auth-profile-runtime-contract.test.ts (added, +246/-0)
  • test/helpers/agents/auth-profile-runtime-contract.ts (added, +54/-0)

PR #71038: [codex] Add outcome fallback runtime contracts

Description (problem / solution / changelog)

Summary

Adds the outcome/fallback contract rung from RFC #71004. This PR is intentionally test-only: it locks how GPT-5 terminal outcomes are classified for fallback and how the Codex app-server adapter preserves raw terminal state for OpenClaw-owned classification.

flowchart TD
  Attempt["Agent attempt result"] --> Classifier["OpenClaw outcome classifier"]
  Classifier --> Fallback["Model fallback chain"]
  Codex["Codex app-server projector"] --> Attempt
  Pi["Pi run result"] --> Attempt
  Classifier --> Silent["Intentional NO_REPLY stays terminal"]
  Classifier --> Effects["Tool side effects stay terminal"]

Contract Matrix

PathCovered behavior
Pi / shared fallbackHarness-owned empty, reasoning-only, and planning-only classifications map to format fallback codes.
Pi / shared fallbackClassified GPT-5 terminal results advance to the configured fallback model.
Pi / shared fallbackIntentional NO_REPLY, visible replies, aborts, and tool side effects do not trigger fallback.
Codex app-server adapterEmpty terminal turns remain empty results for OpenClaw-owned fallback classification.
Codex app-server adapterExact NO_REPLY remains assistant text instead of being classified inside the adapter.
Codex app-server adapterTool side-effect telemetry is preserved so fallback can stay disabled.

Why

The runtime rewrite needs outcome/fallback behavior locked before AgentRuntimePlan centralizes policy. This captures the high-risk GPT-5.4 stall class without requiring the Codex harness to grow a classifier before the runtime-plan phase owns that seam.

Out Of Scope

  • No production runtime behavior changes.
  • No new Codex harness classify() assertion.
  • No changes to frozen prototype PRs #70743 or #70772.

Verification

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/outcome-fallback-runtime-contract.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.extensions.config.ts extensions/codex/src/app-server/outcome-fallback-runtime-contract.test.ts
  • ./node_modules/.bin/oxlint --tsconfig tsconfig.oxlint.core.json test/helpers/agents/outcome-fallback-runtime-contract.ts src/agents/outcome-fallback-runtime-contract.test.ts extensions/codex/src/app-server/outcome-fallback-runtime-contract.test.ts
  • git diff --check -- test/helpers/agents/outcome-fallback-runtime-contract.ts src/agents/outcome-fallback-runtime-contract.test.ts extensions/codex/src/app-server/outcome-fallback-runtime-contract.test.ts

Refs #71004 Follows #71009 Follows #71029

Changed files

  • extensions/codex/src/app-server/outcome-fallback-runtime-contract.test.ts (added, +129/-0)
  • src/agents/outcome-fallback-runtime-contract.test.ts (added, +180/-0)
  • test/helpers/agents/outcome-fallback-runtime-contract.ts (added, +46/-0)

PR #71039: [codex] Add delivery NO_REPLY runtime contracts

Description (problem / solution / changelog)

Summary

Adds the delivery/NO_REPLY contract rung from RFC #71004. This PR is intentionally test-only: it locks currently-green follow-up delivery behavior for silent replies, dispatcher fallback, and Codex app-server preservation of silent terminal text. It also documents one known JSON-envelope delivery gap as a todo contract row for the later runtime-plan delivery migration.

flowchart TD
  Outcome["Agent payloads"] --> Delivery["OpenClaw delivery policy"]
  Delivery --> Silent["Exact NO_REPLY suppresses visible delivery"]
  Delivery --> Media["NO_REPLY + media remains deliverable"]
  Delivery --> Dispatcher["Missing origin route falls back to dispatcher"]
  Delivery --> Todo["TODO: JSON NO_REPLY envelope suppression"]
  Codex["Codex app-server adapter"] --> Outcome

Contract Matrix

PathCovered behavior
Follow-up runnerExact/whitespace NO_REPLY payloads do not route to origin or dispatcher, and still clean up typing state.
Follow-up runnerNO_REPLY payloads with media remain deliverable instead of being suppressed as silent text.
Follow-up runnerSuccessful visible output with incomplete origin routing falls back to the visible dispatcher.
Follow-up runnerExisting route-failure and provider-drop rows remain covered by the same focused followup runner shard.
Follow-up runnerJSON NO_REPLY envelope suppression is explicitly marked todo; current production follow-up delivery suppresses exact text tokens only.
Codex app-server adapterExact, whitespace, and JSON NO_REPLY terminal text is preserved for shared delivery suppression instead of adapter-specific handling.

Why

Delivery is an OpenClaw-owned runtime policy domain. Codex should preserve terminal content and side-channel state, while the shared delivery layer decides whether output is visible, silent, routed to origin, or routed to dispatcher.

The JSON NO_REPLY row is intentionally not made green here because this Phase 1 PR must remain test-only. Runtime behavior changes belong in the later AgentRuntimePlan delivery migration.

Out Of Scope

  • No production delivery changes.
  • No runtime-plan implementation yet.
  • No changes to frozen prototype PRs #70743 or #70772.

Verification

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply-reply.config.ts src/auto-reply/reply/followup-runner.test.ts — 28 passed, 1 todo
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.extensions.config.ts extensions/codex/src/app-server/delivery-no-reply-runtime-contract.test.ts
  • ./node_modules/.bin/oxlint --tsconfig tsconfig.oxlint.core.json test/helpers/agents/delivery-no-reply-runtime-contract.ts src/auto-reply/reply/followup-runner.test.ts extensions/codex/src/app-server/delivery-no-reply-runtime-contract.test.ts
  • git diff --check -- test/helpers/agents/delivery-no-reply-runtime-contract.ts src/auto-reply/reply/followup-runner.test.ts extensions/codex/src/app-server/delivery-no-reply-runtime-contract.test.ts

Refs #71004 Follows #71009 Follows #71029

Changed files

  • extensions/codex/src/app-server/delivery-no-reply-runtime-contract.test.ts (added, +80/-0)
  • src/auto-reply/reply/followup-runner.test.ts (modified, +78/-1)
  • test/helpers/agents/delivery-no-reply-runtime-contract.ts (added, +12/-0)

PR #71042: [codex] Add transcript repair runtime contracts

Description (problem / solution / changelog)

Summary

Adds the Phase 1 transcript-repair contract slice for RFC #71004. This is test-only: it does not change Pi runtime behavior, Codex app-server behavior, or any production transcript repair code.

Contract Boundary

flowchart TD
  UserTurn["Queued user turn"] --> TranscriptPolicy["OpenClaw transcript repair contract"]
  TranscriptPolicy --> PiMerge["Pi orphan user merge strategy"]
  TranscriptPolicy --> CodexProjection["Codex context projection"]
  PiMerge --> PreparedPrompt["Prepared prompt keeps older user content"]
  CodexProjection --> QuotedContext["Quoted context keeps prior structured/media turns"]

This PR locks the current executable behavior that Phase 2/3 runtime-plan work must preserve:

SurfaceContract rows
Pi orphan repairtext orphan leaf is merged with the queued-user marker
Pi orphan repairalready-present orphan text is not duplicated
Pi orphan repairstructured text + media references survive before leaf removal
Pi orphan repairinline data URI media is summarized, not embedded into prompt bytes
Pi strategy seamactive message merge strategy is the single dispatch point and can be replaced for adapter tests
Codex projectionduplicate trailing current prompt is dropped, but prior structured context remains visible
Codex projectionmedia-only prior user history remains represented as omitted media, without data URI bytes

Why

The Pi to Codex shift exposed that transcript repair is OpenClaw-owned policy, not a harness implementation detail. Bug class #3 from the GPT-5.4 audit came from orphan trailing user leaves and payload-shape handling. This PR creates the contract tests first so later AgentRuntimePlan work can move transcript policy without losing structured/media payload semantics.

Out of Scope

  • No production runtime refactor.
  • No pi-embedded-runner rename.
  • No changes to #70743/#70772.
  • No Codex-owned transcript repair strategy is introduced here; Codex coverage is limited to current adapter projection behavior until the shared runtime plan owns this seam.

Verification

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/pi-embedded-runner/run/transcript-repair-runtime-contract.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.extensions.config.ts extensions/codex/src/app-server/transcript-repair-runtime-contract.test.ts
  • ./node_modules/.bin/oxlint --tsconfig tsconfig.oxlint.core.json test/helpers/agents/transcript-repair-runtime-contract.ts src/agents/pi-embedded-runner/run/transcript-repair-runtime-contract.test.ts extensions/codex/src/app-server/transcript-repair-runtime-contract.test.ts
  • git diff --check -- test/helpers/agents/transcript-repair-runtime-contract.ts src/agents/pi-embedded-runner/run/transcript-repair-runtime-contract.test.ts extensions/codex/src/app-server/transcript-repair-runtime-contract.test.ts

Refs #71004. Follows #71009, #71029, #71038, #71039.

Changed files

  • extensions/codex/src/app-server/transcript-repair-runtime-contract.test.ts (added, +44/-0)
  • src/agents/pi-embedded-runner/run/transcript-repair-runtime-contract.test.ts (added, +131/-0)
  • test/helpers/agents/transcript-repair-runtime-contract.ts (added, +62/-0)

PR #71044: [codex] Add prompt overlay runtime contracts

Description (problem / solution / changelog)

Summary

Adds the Phase 1 prompt-overlay contract slice for RFC #71004. This is test-only: no production prompt, provider runtime, Pi runner, or Codex app-server behavior changes.

Contract Boundary

flowchart TD
  ModelRef["Resolved provider/model"] --> OverlayContract["OpenClaw GPT-5 prompt overlay resolver contract"]
  OverlayContract --> SharedConfig["Shared agents.defaults.promptOverlays.gpt5"]
  OverlayContract --> OpenAIPlugin["OpenAI-family plugin personality fallback"]
  OverlayContract --> CoreResolver["Core GPT-5 overlay resolver"]
  OverlayContract --> CodexProvider["Codex provider contribution surface"]
  CoreResolver --> PromptBundle["Behavior contract + optional interaction style"]
  CodexProvider --> PromptBundle

This PR locks current resolver/provider-surface behavior that Phase 2/3 runtime-plan work must preserve:

SurfaceContract rows
Core GPT-5 overlay resolverOpenAI-family GPT-5 models get the behavior contract and friendly interaction style by default.
Core GPT-5 overlay resolverShared agents.defaults.promptOverlays.gpt5.personality = off disables friendly style but preserves the behavior contract.
Core GPT-5 overlay resolverplugins.entries.openai.config.personality fallback affects OpenAI-family GPT-5 providers but does not leak to non-OpenAI GPT-5 providers.
Core GPT-5 overlay resolverCodex virtual providers are explicitly in the OpenAI-family personality fallback scope.
Core GPT-5 overlay resolverNon-GPT-5 models do not receive GPT-5 overlays.
Codex provider contribution surfaceCodex GPT-5 provider runs consume the shared GPT-5 behavior contract.
Codex provider contribution surfaceCodex respects shared GPT-5 overlay config.
Codex provider contribution surfaceNon-GPT-5 Codex provider runs do not receive GPT-5 overlays.

Why

The Pi to Codex shift exposed prompt overlays as OpenClaw-owned runtime policy. Bug class #7 from the GPT-5.4 audit came from provider scoping: an OpenAI plugin personality setting must not accidentally control unrelated GPT-5 providers, while Codex/OpenAI-family paths still need consistent overlay behavior. These contracts make that ownership explicit before AgentRuntimePlan moves prompt policy into a shared prepared turn.

Note: this PR intentionally does not claim full Pi prompt-bundle assembly coverage. It exercises the shared resolver and Codex provider contribution surface only.

Out of Scope

  • No production runtime refactor.
  • No prompt text edits.
  • No new plugin hook surface.
  • No changes to #70743/#70772.

Verification

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/prompt-overlay-runtime-contract.test.ts
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.extensions.config.ts extensions/codex/prompt-overlay-runtime-contract.test.ts
  • ./node_modules/.bin/oxlint --tsconfig tsconfig.oxlint.core.json test/helpers/agents/prompt-overlay-runtime-contract.ts src/agents/prompt-overlay-runtime-contract.test.ts extensions/codex/prompt-overlay-runtime-contract.test.ts
  • git diff --check -- test/helpers/agents/prompt-overlay-runtime-contract.ts src/agents/prompt-overlay-runtime-contract.test.ts extensions/codex/prompt-overlay-runtime-contract.test.ts

Refs #71004. Follows #71009, #71029, #71038, #71039, #71042.

Changed files

  • extensions/codex/prompt-overlay-runtime-contract.test.ts (added, +45/-0)
  • src/agents/prompt-overlay-runtime-contract.test.ts (added, +78/-0)
  • test/helpers/agents/prompt-overlay-runtime-contract.ts (added, +48/-0)

PR #71046: [codex] Add schema normalization runtime contracts

Description (problem / solution / changelog)

Summary

Adds the Phase 1 schema-normalization contract slice for RFC #71004. This is test-only: no production schema normalization, OpenAI transport, Pi runner, or Codex app-server behavior changes.

Contract Boundary

flowchart TD
  ToolCatalog["OpenClaw tool catalog"] --> ProviderCompat["Provider schema compatibility hooks"]
  ProviderCompat --> OpenAIResponses["OpenAI HTTP Responses"]
  ProviderCompat --> OpenAIWS["OpenAI WebSocket"]
  ProviderCompat --> CodexDynamicTools["Codex app-server dynamic-tool boundary"]
  OpenAIResponses --> ExecutableSchemas["Executable tool schemas"]
  OpenAIWS --> ExecutableSchemas
  CodexDynamicTools --> ExecutableSchemas
  ExecutableSchemas --> Todo["TODO: full strict-compatible parameter-free parity"]

This PR locks the current executable behavior that Phase 2/3 runtime-plan work must preserve, and marks known red gaps as todo rather than hiding it behind a weak assertion:

SurfaceContract rows
Provider compatibility hooksNative OpenAI Responses parameter-free schemas normalize to strict-compatible object schemas.
Provider compatibility hooksNative OpenAI Codex Responses parameter-free schemas normalize through the same OpenAI-family helper.
Provider compatibility hooksProxy-like OpenAI routes are not tightened as native OpenAI routes.
Provider compatibility hooksPermissive schemas remain observable for transport-level strict:false downgrade.
HTTP/WS transportsHTTP Responses and WebSocket choose matching strict flags for the same mixed strict/permissive tool set.
HTTP/WS transportsProvider-prepared parameter-free schemas stay strict-compatible across HTTP Responses and WebSocket.
HTTP/WS transportsRaw parameter-free transport schemas remain executable object shells. Full raw-schema strict-compatible parity and compaction-triggered Responses coverage are marked todo.
Codex app-server boundaryPrepared executable dynamic tool schemas are passed through thread start unchanged. Codex does not own schema normalization in this phase.
Codex app-server boundaryDynamic tool schema changes invalidate the thread fingerprint.

Why

The Pi to Codex shift exposed tool schema normalization as OpenClaw-owned runtime policy. Bug class #6 from the GPT-5.4 audit came from per-transport schema forks: HTTP Responses, WS, and Codex adapter surfaces need equivalent executable schema invariants before AgentRuntimePlan centralizes tool catalog preparation.

This PR does not claim Codex app-server performs schema normalization. It locks the Codex adapter boundary that receives prepared dynamic-tool schemas, while provider/tool normalization remains covered by the plugin-sdk and transport tests.

Out of Scope

  • No production runtime refactor.
  • No new schema normalizer API.
  • No virtual-provider policy changes.
  • No changes to #70743/#70772.

Verification

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.unit-fast.config.ts src/plugin-sdk/schema-normalization-runtime-contract.test.ts — 4 passed
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.unit-fast.config.ts src/agents/schema-normalization-runtime-contract.test.ts — 3 passed, 2 todo
  • node scripts/run-vitest.mjs run --config test/vitest/vitest.extensions.config.ts extensions/codex/src/app-server/schema-normalization-runtime-contract.test.ts
  • ./node_modules/.bin/oxlint --tsconfig tsconfig.oxlint.core.json test/helpers/agents/schema-normalization-runtime-contract.ts src/plugin-sdk/schema-normalization-runtime-contract.test.ts src/agents/schema-normalization-runtime-contract.test.ts extensions/codex/src/app-server/schema-normalization-runtime-contract.test.ts
  • git diff --check -- test/helpers/agents/schema-normalization-runtime-contract.ts src/plugin-sdk/schema-normalization-runtime-contract.test.ts src/agents/schema-normalization-runtime-contract.test.ts extensions/codex/src/app-server/schema-normalization-runtime-contract.test.ts

Refs #71004. Follows #71009, #71029, #71038, #71039, #71042, #71044.

Changed files

  • extensions/codex/src/app-server/schema-normalization-runtime-contract.test.ts (added, +168/-0)
  • src/agents/schema-normalization-runtime-contract.test.ts (added, +75/-0)
  • src/plugin-sdk/schema-normalization-runtime-contract.test.ts (added, +73/-0)
  • test/helpers/agents/schema-normalization-runtime-contract.ts (added, +92/-0)

PR #71048: [codex] Add transport params runtime contracts

Description (problem / solution / changelog)

Summary

Adds the Phase 1 transport-params contract slice for RFC #71004. This is intentionally test-only: it documents the OpenClaw-owned transport policy that must stay stable while Pi and Codex move toward a shared AgentRuntimePlan.

No production runtime behavior changes.

flowchart TD
  ModelRef["Resolved model/provider"] --> ExtraParams["Pi/OpenAI extra params"]
  Config["OpenClaw config + think level"] --> ExtraParams
  Hooks["Provider prep + transport patch hooks"] --> ExtraParams
  ExtraParams --> Defaults["GPT-5 transport defaults"]
  ExtraParams --> Payload["Responses payload mutation"]
  ExtraParams --> StreamOptions["Stream options propagation"]
  Defaults --> Contract["Transport params contract"]
  Payload --> Contract
  StreamOptions --> Contract

Contract Coverage

This PR covers the shared OpenClaw transport-policy rows that are executable today without refactoring runtime ownership:

  • OpenAI-family GPT-5 defaults for openai/* and openai-codex/*.
  • Non-OpenAI GPT-5 providers do not inherit OpenAI transport defaults.
  • Provider/model alias normalization for OpenAI Codex transport detection.
  • parallel_tool_calls API-family support, including openai-codex-responses.
  • Payload mutation for openai-codex/gpt-5.4 on Responses-family transports.
  • OpenAI GPT-5 warmup defaults propagate through the Pi/OpenAI stream wrapper path, including openaiWsWarmup: false.
  • OpenAI GPT-5 thinking level maps into Responses reasoning.effort when the OpenAI reasoning wrapper is active.
  • Provider preparation composes before transport patch resolution.

Codex app-server startup config and turn-start effort mapping are intentionally excluded from this PR after review: those are Codex adapter lifecycle concerns, not shared transport-param policy. They should be covered in the later Codex adapter/runtime-plan phase, not asserted here as transport parity.

Why

The GPT-5.4 audit found that transport parameters were scattered by API string and wrapper path. The concrete regression was parallel_tool_calls being injected for some Responses-family transports but not openai-codex-responses. This contract gives maintainers a focused safety net before the runtime-plan migration centralizes transport policy.

Validation

  • node scripts/run-vitest.mjs run --config test/vitest/vitest.agents.config.ts src/agents/transport-params-runtime-contract.test.ts
  • ./node_modules/.bin/oxlint --tsconfig tsconfig.oxlint.core.json test/helpers/agents/transport-params-runtime-contract.ts src/agents/transport-params-runtime-contract.test.ts
  • git diff --check -- test/helpers/agents/transport-params-runtime-contract.ts src/agents/transport-params-runtime-contract.test.ts

Changed files

  • src/agents/transport-params-runtime-contract.test.ts (added, +239/-0)
  • test/helpers/agents/transport-params-runtime-contract.ts (added, +33/-0)

Code Example

flowchart TD
  UserTurn["User turn"] --> RuntimePlan["Optional shared AgentRuntimePlan"]
  RuntimePlan --> Tools["Tool catalog + hooks"]
  RuntimePlan --> Auth["Auth/profile resolution"]
  RuntimePlan --> Prompt["Prompt + overlays"]
  RuntimePlan --> Transcript["Transcript repair policy"]
  RuntimePlan --> Delivery["Channel delivery policy"]
  RuntimePlan --> Fallback["Outcome classification + fallback"]
  RuntimePlan --> Transport["Transport params + schema normalization"]
  RuntimePlan --> Observability["Resolved backend/model/auth/transport events"]

  RuntimePlan --> Pi["Pi adapter"]
  RuntimePlan --> Codex["Codex app-server adapter"]

  Pi --> Outcome["AgentTurnOutcome"]
  Codex --> Outcome
  Outcome --> Delivery
  Outcome --> Fallback
RAW_BUFFERClick to expand / collapse

Summary

This RFC tracks a contract-first path for stabilizing the Pi/Codex agent runtime boundary.

Important scope calibration: this issue is not a commitment to do a large rewrite immediately. It is an umbrella that explains why the Phase 1 contract-test suite exists, what those tests protect, and what the smallest safe next step would be if maintainers agree to continue.

The core finding is narrow:

  • The AgentHarness registry/SPI is already useful and should not be redesigned casually.
  • The missing boundary is runtime-policy ownership: tools, auth/profile resolution, prompt overlays, schema normalization, transcript repair, delivery, fallback classification, transport params, and observability are still split across Pi runner code, Codex app-server glue, transports, tools, auth, and channels.
  • As Codex takes over more execution paths, it can bypass or reassemble policy that Pi previously owned implicitly.

The goal is risk control: lock behavior first, then decide whether to introduce a shared prepared-turn plan. No production runtime refactor should be required just because this issue exists.

What This Issue Is / Is Not

This issue is:

  • A maintainer-facing explanation for the Phase 1 contract PRs.
  • A map of OpenClaw-owned runtime policy that Pi and Codex should preserve consistently.
  • A place to record known red rows that should not be forgotten if/when runtime-plan work starts.
  • A guardrail against more whack-a-mole point fixes in #70743/#70772-style prototype branches.

This issue is not:

  • A mandate to implement every phase listed below.
  • A request to rewrite the harness SPI.
  • A reason to block the Phase 1 test-only PRs on future runtime refactors.
  • A commitment to split/rename pi-embedded-runner now.
  • A commitment to ship WS pooling, Harness V2, or any structural move before maintainers explicitly choose that path.

Current Status

Phase 1 contract-test PRs are open, test-only, and intentionally avoid production behavior changes.

PRContract domainWhat it locksStatus
#71009Dynamic toolsbefore_tool_call, execution, result middleware, after_tool_call, blocks/errors, telemetry, no double wrappingReady/mergeable
#71029Auth/profileopenai/*, openai-codex/*, codex-cli/*, app-server startup/resume profile forwarding, no cross-provider leakageReady/mergeable, with explicit future TODOs for full real codex/* harness startup
#71038Outcome/fallbackGPT-5 empty/reasoning-only/planning-only fallback classification, NO_REPLY, side-effect and block suppression, Codex terminal signal preservationReady/mergeable
#71039Delivery/NO_REPLYSilent reply suppression, media preservation, dispatcher fallback when origin routing is incomplete, Codex terminal text preservationReady/mergeable, with JSON envelope NO_REPLY TODO
#71042Transcript repairText, structured, media, and data-URI-style orphan user-turn preservation; Codex projection behaviorReady/mergeable
#71044Prompt overlaysGPT-5 overlay provider scoping, OpenAI-family personality fallback, Codex provider contribution surfaceReady/mergeable
#71046Schema normalizationProvider-prepared executable schemas across HTTP Responses, WS, compaction, and Codex dynamic-tool boundariesReady/mergeable, with raw parameter-free strict parity TODO
#71048Transport paramsGPT-5 OpenAI-family defaults, parallel_tool_calls, openai-codex-responses, WS warmup default, provider prep compositionReady/mergeable

Why This Is Needed

Recent evidence:

  • #70965 showed the failure mode clearly: Codex mode could execute OpenClaw dynamic tools without preserving the existing before_tool_call contract because dynamic-tool ownership was implicit. The fix was correct, but the root cause was architectural.
  • #70743 and #70772 showed the broader GPT-5.4 pattern: empty/planning-only/reasoning-only terminal outcomes, tool params, schema normalization, auth profile aliases, orphan turn repair, and follow-up delivery each needed separate fixes because policy was scattered across runner, transport, channel, plugin, and auth layers.
  • #70760 improved harness observability, but observability alone does not prevent Codex and Pi from diverging on OpenClaw-owned behavior.

The safer discipline is contract-first: prove the intended behavior before moving ownership around.

Architecture Framing

flowchart TD
  UserTurn["User turn"] --> RuntimePlan["Optional shared AgentRuntimePlan"]
  RuntimePlan --> Tools["Tool catalog + hooks"]
  RuntimePlan --> Auth["Auth/profile resolution"]
  RuntimePlan --> Prompt["Prompt + overlays"]
  RuntimePlan --> Transcript["Transcript repair policy"]
  RuntimePlan --> Delivery["Channel delivery policy"]
  RuntimePlan --> Fallback["Outcome classification + fallback"]
  RuntimePlan --> Transport["Transport params + schema normalization"]
  RuntimePlan --> Observability["Resolved backend/model/auth/transport events"]

  RuntimePlan --> Pi["Pi adapter"]
  RuntimePlan --> Codex["Codex app-server adapter"]

  Pi --> Outcome["AgentTurnOutcome"]
  Codex --> Outcome
  Outcome --> Delivery
  Outcome --> Fallback

Desired ownership boundary:

  • OpenClaw owns tool catalog/hook behavior, auth/profile resolution, prompt overlays, transcript repair, channel delivery, fallback classification, transport params, schema normalization, and observability.
  • Pi owns the Pi model/session implementation.
  • Codex owns app-server startup, thread lifecycle, and model-loop mechanics.
  • Harness selection chooses an adapter; it should not duplicate OpenClaw policy.

What Phase 1 Gives Maintainers

Phase 1 gives maintainers a low-risk review baseline before any semantic migration:

  • Each PR is small, test-only, and scoped to one policy domain.
  • Each PR states what is covered and what is deliberately deferred.
  • Known gaps are explicit todo rows instead of hidden assumptions.
  • Later runtime changes can be judged by whether they keep these contracts green.
  • If a future Codex/Pi change breaks OpenClaw-owned behavior, the failure should happen in tests before users see it.

Known Rows To Carry Forward

These rows should not block Phase 1. They are reminders for whichever follow-up path maintainers choose.

DomainDeferred rowWhy deferred
Auth/profileReal codex/* harness startup preserving openai-codex:* auth profilesRequires full embedded runner + harness selection path, not just app-server unit surface
Auth/profileopenai/* forced through Codex harness using OpenAI-Codex OAuthCrosses model selection, forced harness policy, and auth-provider validation
DeliveryJSON/enveloped NO_REPLY suppressionRequires production delivery-policy behavior change, not a test-only contract
Schema normalizationRaw parameter-free HTTP/WS strict-compatible parityRequires schema normalization boundary migration
Transcript repairCodex shared transcript repair strategyCurrent PR covers projection only; shared repair strategy belongs in runtime-plan consumption
Transport paramsCodex app-server startup/turn effort config parityAdapter lifecycle concern for any Codex runtime-plan consumption

Minimal Next Decision

After the Phase 1 test-only PRs merge, maintainers can choose one of these paths:

  1. Stop there for now.

    The contracts still add value by preventing accidental Pi/Codex divergence.

  2. Add a small AgentRuntimePlan shape/prototype PR.

    This should be additive, internal, and mostly inert: define the prepared-turn object and producer tests, but do not force Pi or Codex to consume it yet.

  3. Migrate one domain through the plan as a proof point.

    Pick the highest-confidence domain, likely tools or auth/profile, and require the existing contract rows to stay green. Do not combine this with file moves or renames.

Anything beyond that should be a separate maintainer decision, not assumed by this RFC.

Candidate Follow-Ups, Not Current Commitments

These are possible later steps if the contract-first approach proves useful:

  • Shared AgentRuntimePlan consumption by Pi.
  • Shared AgentRuntimePlan consumption by Codex for OpenClaw-owned policy.
  • Optional internal Harness V2 adapter layer.
  • Runner split by ownership boundary.
  • Naming/observability cleanup for pi-embedded-runner / runEmbeddedPiAgent.
  • Optional WS session pooling/latency work.

They should land only as small reversible PRs with contract tests already in place.

Safety Rules

  • Do not ship hook surfaces before contract tests prove default behavior.
  • Do not split files before parity behavior is locked.
  • Do not let Codex own OpenClaw runtime policy.
  • Do not remove user-visible functionality during any migration.
  • Keep structural and behavioral changes in separate PRs.
  • Keep #70743/#70772 frozen as evidence/prototypes unless maintainers request targeted fixes.

Acceptance Criteria For This RFC

This RFC succeeds if:

  • Maintainers can see why the Phase 1 contract suite exists.
  • Each OpenClaw-owned runtime policy domain has an executable parity baseline or an explicit deferred row.
  • Future Pi/Codex changes have a clear test surface before touching production runtime behavior.
  • Follow-up refactors are optional, explicit, and separately reviewable.

extent analysis

TL;DR

Implement a contract-first rewrite of the Pi/Codex agent runtime boundary to stop scattered regressions by making OpenClaw-owned runtime policy explicit, shared, and testable.

Guidance

  • Start by adding contract tests for Pi and Codex to ensure parity and coverage of OpenClaw-owned runtime policies.
  • Introduce a shared AgentRuntimePlan object to record resolved model ref, auth profile, prompt bundle, tool catalog, and other relevant data.
  • Update Pi and Codex to consume the shared AgentRuntimePlan and remove duplicated policy decisions.
  • Split the runner into modules by ownership boundary only after behavior is locked and contract tests pass.
  • Ensure that Codex does not own OpenClaw runtime policy and that user-visible functionality is preserved during the rewrite.

Example

flowchart TD
  UserTurn["User turn"] --> RuntimePlan["OpenClaw Agent Runtime Plan"]
  RuntimePlan --> Tools["Tool catalog + hooks"]
  RuntimePlan --> Auth["Auth/profile resolution"]
  ...

This example illustrates the desired architecture with a shared AgentRuntimePlan object.

Notes

The proposed rewrite aims to address the issue of scattered regressions by making OpenClaw-owned runtime policy explicit and testable. However, the success of this approach depends on careful planning and execution to ensure that the new architecture is correct, complete, and compatible with existing functionality.

Recommendation

Apply the proposed contract-first rewrite approach to ensure that OpenClaw-owned runtime policy is explicit, shared, and testable, and to prevent future regressions. This approach is recommended because it addresses the root cause of the issue and provides a clear path forward for maintaining and extending the codebase.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING