vllm - 💡(How to fix) Fix [RFC]: Request to clarify attribution/authorship for the RISC-V CPU backend PR chain (#20292, #32405, #36538, #36578) [1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
vllm-project/vllm#38974Fetched 2026-04-08 02:44:39
View on GitHub
Comments
0
Participants
1
Timeline
8
Reactions
0
Author
Participants
Timeline (top)
labeled ×2project_v2_item_status_changed ×2added_to_project_v2 ×1closed ×1

Root Cause

Regarding authorship, the core follow-on implementation after #20292 was originally developed by me during my internship at ISCAS. After I left, that work was further continued and submitted as #32405. Because of this history, I believe the current public record should be clarified so that earlier implementation work is not omitted from the attribution chain.

RAW_BUFFERClick to expand / collapse

Motivation.

I am opening this RFC to request clarification of the attribution/authorship history for the RISC-V CPU backend work.

This is not a request to remove the merged functionality. The motivation is to ensure that the development history for this work is recorded accurately and transparently.

The concern is that the visible PR chain does not fully reflect the implementation lineage. In particular:

  • #32405 explicitly stated that it continues and extends the work from #20292.
  • Later PRs #36538 and #36578 continued the same line of RISC-V CPU backend work, but the visible attribution chain no longer acknowledged #32405.
  • As a result, the current merged record may give future readers an incomplete understanding of who implemented the earlier follow-on work and how the final merged result evolved.

Regarding authorship, the core follow-on implementation after #20292 was originally developed by me during my internship at ISCAS. After I left, that work was further continued and submitted as #32405. Because of this history, I believe the current public record should be clarified so that earlier implementation work is not omitted from the attribution chain.

Proposed Change.

I would like maintainers to consider the following project-level change in how this PR chain is documented:

  1. Add an explicit maintainer note, PR update, or linked issue comment that documents the implementation lineage for the RISC-V CPU backend PR chain: #20292 -> #32405 -> #36538 -> #36578.
  2. Acknowledge that #36538 / #36578 carried forward earlier implementation work rather than presenting the merged result as entirely new work in the final PR.
  3. Where possible, distinguish between:
    • earlier follow-on implementation work,
    • later fixes/rebasing/integration changes,
    • and the final merge-ready adjustments.
  4. More generally, establish the expectation that when a later PR substantially carries forward a closed or superseded PR, the earlier implementation chain should be explicitly credited in the final visible record.

I am not requesting code removal or revert. I am requesting an attribution/authorship clarification so that the project history is more accurate for maintainers, contributors, and future readers.

Feedback Period.

No response

CC List.

@hansu2022

Any Other Things.

I recognize that this is not a traditional architecture RFC. I am using the RFC template because the current issue categories do not appear to provide a better project-level venue for discussing attribution/authorship clarification after the final PR has already been merged.

I am happy to help clarify which parts belonged to the original follow-on implementation and which parts were later fixes, rebasing work, or integration changes.

I am raising this as an RFC because the final PR in this chain has already been merged, so this is now a project-level question about attribution and contribution history rather than a review comment on a single open PR.

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

extent analysis

TL;DR

Add an explicit maintainer note or PR update to document the implementation lineage for the RISC-V CPU backend PR chain.

Guidance

  • Review the PR chain (#20292, #32405, #36538, #36578) to understand the implementation lineage and identify areas where earlier work was carried forward.
  • Consider adding a maintainer note or linked issue comment to acknowledge the earlier implementation work and distinguish it from later fixes, rebasing, and integration changes.
  • Establish a project-level expectation for explicitly crediting earlier implementation chains in the final visible record when a later PR substantially carries forward a closed or superseded PR.

Notes

This guidance is focused on clarifying attribution and authorship, rather than modifying the merged code.

Recommendation

Apply a workaround by adding an explicit maintainer note or PR update to document the implementation lineage, as this will help to accurately reflect the development history without requiring code changes.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING