PR #63903: fix(memory-core): limit dreaming narrative fallback to request-scoped subagent runtime errors

• Repository: openclaw/openclaw
• Author: MonkeyLeeT
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/63903

Description (problem / solution / changelog)

Summary

• Problem: scheduled Dreaming can hit request-scoped subagent runtime errors and skip diary output.
• Why it matters: we should preserve DREAMS.md output for that specific scheduled/runtime mismatch.
• What changed: fallback is now limited to the canonical request-scoped runtime error, with shared constant wiring across throw/check sites.
• What did NOT change: non-request-scope subagent.run failures still follow existing best-effort warning behavior (no fallback diary write).

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #63832
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: scheduled Dreaming used a subagent runtime path that can be request-scoped only.
• Missing guardrail: narrative fallback path was not scoped tightly to that specific runtime-unavailable condition.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: extensions/memory-core/src/dreaming-narrative.test.ts
• Scenario locked in: request-scoped runtime error triggers fallback diary write; other run failures do not.

User-visible / Behavior Changes

• Scheduled Dreaming now writes fallback diary text only for request-scoped subagent runtime unavailability.

Security Impact (required)

• New permissions/capabilities? No
• Secrets/tokens handling changed? No
• New/changed network calls? No
• Command/tool execution surface changed? No
• Data access scope changed? No

Human Verification (required)

• Verified scenarios: request-scoped fallback path, non-request failure path, existing narrative flow tests.
• Edge case checked: nested cause text no longer triggers fallback path.
• Not verified in this PR: live cron run on a real gateway instance.

Risks and Mitigations

• Risk: request-scoped discriminator drift across boundaries.
  • Mitigation: shared exported constant (SUBAGENT_RUNTIME_REQUEST_SCOPE_ERROR_MESSAGE) used by both runtime throw and memory-core check.
• Risk: diary writes through symlinked DREAMS.md.
  • Mitigation: appendNarrativeEntry now uses guarded atomic write path.

Changed files

• extensions/memory-core/src/dreaming-narrative.ts (modified, +50/-0)

---

PR #64156: fix(memory-core): harden request-scoped dreaming fallback

• Repository: openclaw/openclaw
• Author: mbelinky
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/64156

Description (problem / solution / changelog)

Summary

• Problem: scheduled dreaming can hit request-scoped subagent runtime errors and skip DREAMS.md narrative output.
• Why it matters: cron-driven dreaming should degrade cleanly only for that specific runtime mismatch, without broad fallback matching or path leakage.
• What changed:
  • added a shared request-scoped subagent runtime error code/class in the plugin runtime seam
  • limited narrative fallback to that typed/stable signal instead of generic message matching
  • kept non-request-scope failures on the existing warn-and-stop path
  • removed workspace-path leakage from the fallback warning

Change Type

• Bug fix
• Security hardening

Scope

• Memory / storage
• API / contracts

Linked Issue/PR

• Closes #63832
• Supersedes #63903

Root Cause

The narrative fallback path was trying to detect a request-scoped subagent runtime failure too loosely. That made the seam brittle and left the runtime throw/check sites coupled by message text rather than a stable contract.

Regression Test Plan

• Unit test
• Target files:
  • extensions/memory-core/src/dreaming-narrative.test.ts
  • src/plugins/runtime/index.test.ts
• Locked scenarios:
  • direct request-scoped runtime failure triggers fallback diary write
  • stable error code triggers fallback diary write
  • nested generic causes do not trigger fallback
  • warning log does not leak workspace path

Verification

Authoritative mb-server gate passed:

• pnpm test -- extensions/memory-core/src/dreaming-narrative.test.ts src/plugins/runtime/index.test.ts

Risks and Mitigations

• Risk: drift between runtime throw site and fallback detection.
  • Mitigation: shared exported error code/class.
• Risk: overbroad fallback classification.
  • Mitigation: only direct typed/code-matched failures fall back now.

Changed files

• CHANGELOG.md (modified, +2/-0)
• docs/.generated/plugin-sdk-api-baseline.sha256 (modified, +2/-2)
• extensions/memory-core/src/dreaming-narrative.test.ts (modified, +83/-1)
• extensions/memory-core/src/dreaming-narrative.ts (modified, +91/-5)
• src/plugin-sdk/error-runtime.ts (modified, +13/-0)
• src/plugins/runtime/index.ts (modified, +2/-1)