openclaw - 💡(How to fix) Fix Security: dangerouslyAllowNameMatching enables user impersonation via display name spoofing [2 comments, 2 participants]

Fix Plan

To address the authorization bypass vulnerability, we will remove the dangerouslyAllowNameMatching feature and ensure that authorization decisions are based on stable platform user IDs only.

Step-by-Step Solution

• Remove the dangerouslyAllowNameMatching feature from the codebase.
• Update the authorization logic to use stable platform user IDs for matching authorized users.
• Add prominent warnings in the configuration and runtime logs to alert administrators about the potential risks of using display names for authorization.

Example Code Changes

// Before
if (dangerouslyAllowNameMatching && displayName === authorizedUserDisplayName) {
  // Grant access
}

// After
if (platformUserId === authorizedUserPlatformUserId) {
  // Grant access
}

In the updated code, we removed the dangerouslyAllowNameMatching check and instead verified the platformUserId against the authorizedUserPlatformUserId.

Verification

To verify that the fix worked, test the authorization logic with different scenarios, including:

• An attacker attempting to impersonate an authorized user by setting their display name to match.
• An authorized user accessing the system with their stable platform user ID.

Extra Tips

• Always prioritize using stable and unique identifiers for authorization decisions.
• Regularly review and update your codebase to ensure that security features are not compromised by user-controllable inputs.