openclaw - 💡(How to fix) Fix Security: SSRF in fal image generation provider (fetchImageBuffer) [1 comments, 2 participants]

Summary

fetchImageBuffer(url) in the fal image generation provider performs a bare fetch(url) with no SSRF protection, no hostname allowlist, and no private network check.

async function fetchImageBuffer(url) {
    const response = await fetch(url);  // no SSRF guard
    ...
}

The URL originates from the fal API response (payload.images[].url). Other similar fetchers in the codebase correctly use fetchWithSsrFGuard or fetchWithGuard with allowPrivateNetwork: false.

Impact

If a compromised or malicious fal endpoint returns an internal/private URL (e.g., http://169.254.169.254/... for cloud metadata, or http://localhost:18789/... for the gateway), the server will fetch it, potentially leaking internal data.

Location

dist/image-generation-provider-DBhbTVWi.js:94

Suggested Fix

Replace fetch(url) with fetchWithSsrFGuard(url, { allowPrivateNetwork: false }) consistent with other image fetchers in the codebase.

Audit Method

Pattern A (consistency comparison) — other image fetchers use SSRF guards, this one does not.