openclaw - ✅(Solved) Fix Slack: Cannot read properties of undefined (reading 'includes') when sending replies [2 pull requests, 2 comments, 2 participants]

ogulcansarioglu · 2026-03-18T22:56:59Z

[openclaw] PR 52785: fix: ignore non-string mention patterns during mention gating - Repository: openclaw/openclaw - Author: ogulcansarioglu - State: closed |… # PR #52785: fix: ignore non-string mention patterns during mention gating - Repository: openclaw/openclaw - Author: ogulcansarioglu - State: closed | merged: False - Link: https://github.com/openclaw/openclaw/pull/52785 ## Description (problem / solution / changelog) ## Summary - harden mention pattern normalization to ignore non-string `messages.groupChat.mentionPatterns` entries before `.includes`-based normalization - add a regression test covering mixed valid/invalid mention pattern entries and note the behavior in `CHANGELOG.md` - open as a draft because this is still a hypothesis fix for #50060; the issue's quoted stack does not cleanly match the current or tagged source code we verified ## Why The reported Slack crash is `Cannot read properties of undefined (reading 'includes')` during mention-triggered handling. While the exact stack in #50060 does not match the current repo source, mention gating still had one realistic `.includes` risk: `normalizeMentionPattern()` assumed every configured mention pattern was a string. This patch makes that path robust by dropping invalid entries instead of crashing the gating pipeline. ## Evidence gathered - verified the currently cited paths in the issue are already guarded in source/tagged code: - `extensions/slack/src/format.ts` - `src/auto-reply/reply/reply-payloads.ts` - `src/utils/directive-tags.ts` - verified `2026.3.13-1` also already guards the issue's quoted `.includes` sites - issue file names like `extensionAPI.js` / `loader-*.js` do not map cleanly to this repo tree, so there may be a packaged-artifact or misreported-stack mismatch ## Testing - [x] AI-assisted PR - [x] Lightly tested - [ ] Fully tested - [x] I understand what the code does - [ ] Prompts/session logs included Commands run: - `npx pnpm@10.23.0 install --frozen-lockfile` - `npx pnpm@10.23.0 test:contracts:channels` ✅ - `npx pnpm@10.23.0 test -- --run src/auto-reply/inbound.test.ts` ⚠️ pre-existing failures in the file unrelated to this patch - `npx pnpm@10.23.0 test:extension slack` ⚠️ pre-existing Slack/plugin-sdk mock failures unrelated to this patch ## Known blockers / caveats - targeted inbound test file already has unrelated failures around provider mention stripping / requireMention behavior - Slack extension lane currently has unrelated pre-existing failures from missing exports in plugin-sdk test mocks - a workspace dependency prepare step emitted unrelated type errors during install, but dependency installation completed and the repo test commands were runnable afterward - this draft should stay in draft until we confirm the production stack or decide this hardening is still worth merging independently Closes #50060 ## Changed files - `.agents/skills/openclaw-ghsa-maintainer/SKILL.md` (removed, +0/-87) - `.agents/skills/openclaw-parallels-smoke/SKILL.md` (removed, +0/-72) - `.agents/skills/openclaw-pr-maintainer/SKILL.md` (removed, +0/-75) - `.agents/skills/openclaw-release-maintainer/SKILL.md` (removed, +0/-74) - `.agents/skills/openclaw-test-heap-leaks/SKILL.md` (removed, +0/-71) - `.agents/skills/openclaw-test-heap-leaks/agents/openai.yaml` (removed, +0/-4) - `.agents/skills/openclaw-test-heap-leaks/scripts/heapsnapshot-delta.mjs` (removed, +0/-265) - `.agents/skills/security-triage/SKILL.md` (removed, +0/-108) - `.dockerignore` (modified, +1/-1) - `.github/ISSUE_TEMPLATE/bug_report.yml` (modified, +25/-21) - `.github/actions/ensure-base-commit/action.yml` (modified, +2/-6) - `.github/actions/setup-node-env/action.yml` (modified, +1/-1) - `.github/labeler.yml` (modified, +0/-11) - `.github/pull_request_template.md` (modified, +1/-1) - `.github/workflows/auto-response.yml` (modified, +1/-3) - `.github/workflows/ci.yml` (modified, +449/-263) - `.github/workflows/codeql.yml` (modified, +1/-1) - `.github/workflows/docker-release.yml` (modified, +1/-9) - `.github/workflows/install-smoke.yml` (modified, +16/-98) - `.github/workflows/openclaw-npm-release.yml` (modified, +1/-1) - `.github/workflows/sandbox-common-smoke.yml` (modified, +0/-2) - `.github/workflows/stale.yml` (modified, +2/-2) - `.github/workflows/workflow-sanity.yml` (modified, +1/-7) - `.gitignore` (modified, +2/-1) - `AGENTS.md` (modified, +158/-50) - `CHANGELOG.md` (modified, +1/-0) - `CONTRIBUTING.md` (modified, +2/-5) - `Dockerfile` (modified, +1/-11) - `README.md` (modified, +2/-2) - `apps/android/README.md` (modified, +4/-66) - `apps/android/app/build.gradle.kts` (modified, +4/-24) - `apps/android/app/src/main/AndroidManifest.xml` (modified, +0/-1) - `apps/android/app/src/main/java/ai/openclaw/app/MainViewModel.kt` (modified, +1/-11) - `apps/android/app/src/main/java/ai/openclaw/app/NodeRuntime.kt` (modified, +40/-57) - `apps/android/app/src/main/java/ai/openclaw/app/PermissionRequester.kt` (modified, +21/-79) - `apps/android/app/src/main/java/ai/opencla

openclaw2026-03-18 22:56:59

ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

GitHub issue URL

Helpful · Quick feedback

GitHub stats

openclaw/openclaw#50060•Fetched 2026-04-08 00:59:40

View on GitHub

Comments

Participants

Timeline

Reactions

Author

ogulcansarioglu

Participants

Hollychou924

ogulcansarioglu

Timeline (top)

commented ×2cross-referenced ×2

Error Message

This error is sent back to the user as a Slack message, making the bot unusable.

Similar issue #43163 (cron trim error)

Root Cause

The functions escapeSlackMrkdwnContent() and escapeSlackMrkdwnText() call text.includes() without null-safety checks. When the text is undefined (e.g., messages with attachments but no text body, or certain Slack event types), the code throws a TypeError.

Additionally, payload.text.includes("[[") in the deliver files can crash when payload.text is undefined.

Code Example

Cannot read properties of undefined (reading 'includes')

---

// Before
if (text.includes("<")) { ... }

// After  
if (text?.includes("<")) { ... }

// Also for deliver files
if (payload.text?.includes("[[")) { ... }

RAW_BUFFERClick to expand / collapse

Bug Description

When the Slack bot tries to reply to a message, it crashes with:

Cannot read properties of undefined (reading 'includes')

This error is sent back to the user as a Slack message, making the bot unusable.

Root Cause

Additionally, payload.text.includes("[[") in the deliver files can crash when payload.text is undefined.

Files Affected

extensionAPI.js - escapeSlackMrkdwnContent + escapeSlackMrkdwnText
loader-*.js - same functions
pi-embedded-*.js - same functions
reply-*.js - same functions
deliver-*.js - payload.text.includes("[[")

Suggested Fix

Add optional chaining:

// Before
if (text.includes("<")) { ... }

// After  
if (text?.includes("<")) { ... }

// Also for deliver files
if (payload.text?.includes("[[")) { ... }

Environment

OpenClaw 2026.3.13
Slack channel plugin (stock)

Similar issue #49094 (WhatsApp peer.js has same pattern)
Similar issue #43163 (cron trim error)

extent analysis

Fix Plan

To resolve the issue, we need to add null-safety checks using optional chaining to the affected functions. Here are the concrete steps:

In extensionAPI.js, loader-*.js, pi-embedded-*.js, and reply-*.js, update the escapeSlackMrkdwnContent() and escapeSlackMrkdwnText() functions to use optional chaining:

// Before
if (text.includes("<")) { 
  // ...
}

// After
if (text?.includes("<")) { 
  // ...
}

In deliver-*.js, update the payload.text.includes("[[") line to use optional chaining:

// Before
if (payload.text.includes("[[")) { 
  // ...
}

// After
if (payload.text?.includes("[[")) { 
  // ...
}

Verification

To verify that the fix worked, test the Slack bot by sending messages with and without text bodies, as well as messages with attachments. The bot should no longer crash and should respond correctly.

Extra Tips

Make sure to update all instances of the affected functions in the specified files.
Consider adding additional null-safety checks to other parts of the codebase to prevent similar issues in the future.
Review similar issues (#49094 and #43163) to ensure that the same pattern is not present in other parts of the codebase.

Vote matrix · Quick signals

Works

Did the solution work? Tap to confirm.

Easy Fix

Was it a quick fix?

Time Saver

Did it save you time?

Blocking

Was it severely blocking?

Common Issue

Are others likely hitting this too?

Flaky / Intermittent

Is it intermittent?

Verified / Reproducible

Can you reproduce it reliably?

#api #ssr #installation #tensor shape #autograd error #GPU setup #container setup #orchestration issue #cache issue

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

openclaw - ✅(Solved) Fix Slack: Cannot read properties of undefined (reading 'includes') when sending replies [2 pull requests, 2 comments, 2 participants]

Recommended Tools

GitHub issue graph ai analysis

Error Message

Root Cause

Fix Action

Fixed

PR fix notes

PR #52785: fix: ignore non-string mention patterns during mention gating

Description (problem / solution / changelog)

Summary

Why

Evidence gathered

Testing

Known blockers / caveats

Changed files

PR #52895: fix: ignore non-string mention patterns during mention gating

Description (problem / solution / changelog)

Summary

Why

Testing

Notes

Changed files

Code Example

Bug Description

Root Cause

Files Affected

Suggested Fix

Environment

Related

extent analysis

Fix Plan

Verification

Extra Tips

Still need to ship something?

RELATED_DISCOVERY

TRENDING