PR #29027: fix(core): Set terminal execution status when pruning unsaved runs

• Repository: n8n-io/n8n
• Author: jeanibarz
• State: open | merged: False
• Link: https://github.com/n8n-io/n8n/pull/29027

Description (problem / solution / changelog)

Summary

Sub-workflows that finish successfully with "Save successful production executions = Do not save" (or error with error-saving disabled) used to leave their DB row at status='running' until the next pruning hard-delete swept it. The UI, executions endpoints, and any Postgres/SQL inspection therefore showed finished sub-workflows as still running.

Root cause lives in ExecutionPersistence.deleteInFlightExecution (packages/cli/src/executions/execution-persistence.ts). The soft-delete branch only wrote a backdated deletedAt:

await this.executionRepository.update(target.executionId, { deletedAt });

fullRunData.status had already been finalized by hookFunctionsFinalizeExecutionStatus before this call, but it was being discarded. The row retained the 'running' status it had when the execution started.

This PR threads the terminal status, finished flag, and stoppedAt from the completed run through deleteInFlightExecution and into the UPDATE, so the row immediately reflects the real outcome:

await this.executionRepository.update(target.executionId, {
  deletedAt,
  status,
  finished,
  stoppedAt,
});

Both call sites in execution-lifecycle-hooks.ts (hookFunctionsSave and the delete branch in getLifecycleHooksForScalingMain) forward those fields from fullRunData.

Scope of the change

• Touched only packages/cli/src/executions/ and packages/cli/src/execution-lifecycle/ — no changes to packages/core, no frontend, no node changes.
• 2 production files, 2 test files, +108 / -30 LOC.
• No new public API or new package dependencies.
• Pruning schedule, hard-delete path, and metadata-on-keep guard are unchanged.

Testing

• packages/cli/src/executions/__tests__/execution-persistence.test.ts — the existing "soft-delete with backdated deletedAt" test now asserts the full UPDATE payload including terminal status, a new 'error'-status variant covers the error path, and the hard-delete test supplies the now-required run-status argument.
• packages/cli/src/execution-lifecycle/__tests__/execution-lifecycle-hooks.test.ts — the three deleteInFlightExecution call-site assertions in getLifecycleHooksForScalingMain verify the new second argument is forwarded from fullRunData.

Local run:

pnpm jest src/executions src/execution-lifecycle
Test Suites: 17 passed, 17 total
Tests:       246 passed, 246 total

Related Linear tickets, Github issues, and Community forum posts

Fixes #28867

Review / Merge checklist

• PR title and summary are descriptive
• Docs updated (N/A — internal persistence helper, no public docs or node surface)
• Tests included
• Backport label if urgent fix

Changed files

• packages/cli/src/execution-lifecycle/__tests__/execution-lifecycle-hooks.test.ts (modified, +41/-15)
• packages/cli/src/execution-lifecycle/execution-lifecycle-hooks.ts (modified, +24/-10)
• packages/cli/src/executions/__tests__/execution-persistence.test.ts (modified, +29/-3)
• packages/cli/src/executions/execution-persistence.ts (modified, +14/-2)