openclaw - 💡(How to fix) Fix Telegram: duplicate session race condition when messages arrive during session initialization [2 comments, 3 participants]

12:54:48 WARN tools.profile (coding) allowlist contains unknown entries...

Fix Plan

To prevent duplicate sessions, we need to implement a locking mechanism for chat sessions. Here are the steps:

• Introduce a sessionLocks map to store chat IDs as keys and a boolean indicating whether a session is being initialized.
• When a new message arrives, check the sessionLocks map for an existing lock for the chat ID.
• If a lock is found, queue the new message to the existing session.
• If no lock is found, create a new lock, initialize a new session, and queue the message.

Example code snippet:

const sessionLocks = new Map();

// When a new message arrives
if (sessionLocks.has(chatId)) {
  // Queue the message to the existing session
  const session = getSession(chatId);
  session.queueMessage(message);
} else {
  // Create a new lock and initialize a new session
  sessionLocks.set(chatId, true);
  const session = initializeSession(chatId);
  session.queueMessage(message);
  // Remove the lock when the session is fully initialized
  session.once('initialized', () => {
    sessionLocks.delete(chatId);
  });
}

Verification

To verify the fix, test the following scenarios:

• Send two messages in quick succession (within 2-3 seconds) and check that only one response is sent.
• Send multiple messages in a row and check that the responses are not duplicated.
• Check the gateway logs for any errors or warnings related to session initialization or message queuing.

Extra Tips

• Consider implementing a timeout for session initialization to prevent locks from being held indefinitely.
• Review the tools.profile warning and ensure that the allowlist is properly configured to prevent any issues with session initialization.