PR #25232: fix(gateway): route conflict-retry start_polling failure to reconnect ladder

• Repository: NousResearch/hermes-agent
• Author: liuhao1024
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/25232

Description (problem / solution / changelog)

Summary

When start_polling() raises during a conflict retry in _handle_polling_conflict, the exception was logged and swallowed. Polling stayed dead with no further error callbacks, leaving the gateway "alive but deaf" until manual restart.

Root Cause

In gateway/platforms/telegram.py, _handle_polling_conflict retries start_polling() after a 409 Conflict. If that retry call itself fails (timeout, network error), the except block logged the error and returned — without routing the failure into the existing reconnect ladder.

The _handle_polling_network_error handler already has the correct pattern: when start_polling() fails in its retry path, it self-schedules a new _handle_polling_network_error task via asyncio.ensure_future (lines 814-823). The conflict-retry path was missing this.

Fix

Route conflict-retry start_polling() failures into _handle_polling_network_error, which handles retries with exponential back-off (5s, 10s, 20s, 40s, 60s cap) and eventual escalation to retryable-fatal so the supervisor can restart the gateway.

Code Intelligence

• Analyzed: _handle_polling_conflict (callers: 2, callees: 3, flows: 0)
• Blast radius: LOW — change is inside an exception handler on a rarely-triggered retry path
• Related patterns: _handle_polling_network_error already uses the same asyncio.ensure_future self-scheduling pattern (lines 814-823)

Regression Coverage

New test test_conflict_retry_routes_to_reconnect_on_start_polling_failure in tests/gateway/test_telegram_network_reconnect.py:

• Mocks start_polling to raise during conflict retry
• Asserts that a reconnect task is scheduled in _background_tasks
• Mirrors the existing test_reconnect_self_schedules_on_start_polling_failure which covers the network-error path

Testing

tests/gateway/test_telegram_network_reconnect.py — 16 passed
tests/gateway/test_telegram_conflict.py — 6 passed

Fixes Telegram gateway can stay alive with dead polling after conflict retry start_polling failure #25221

Changed files

• gateway/platforms/telegram.py (modified, +10/-2)
• tests/gateway/test_telegram_network_reconnect.py (modified, +42/-0)

PR #25285: fix(telegram): route conflict-retry start_polling failure into network reconnect ladder

• Repository: NousResearch/hermes-agent
• Author: shanewas
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/25285

Description (problem / solution / changelog)

Summary

Fixes #25221 — Telegram gateway stays alive with dead polling after the conflict-retry start_polling call fails.

The Bug

In _handle_polling_conflict(), when the retry start_polling call (line 896) raises an exception, the handler only logged the error and returned silently — no reconnect was scheduled, no further retry was triggered. This left the gateway process alive but with dead Telegram polling, requiring a manual restart.

The Fix

The fix mirrors what _handle_polling_network_error already does for network failures (lines 814-823): when start_polling fails in the conflict-retry path, schedule a background task that calls _handle_polling_network_error(retry_err). This routes the failure through the exponential-backoff reconnect ladder so the adapter recovers automatically instead of going silent.

Changed file: gateway/platforms/telegram.py (lines 904-916)

except Exception as retry_err:
    logger.warning("[%s] Telegram polling retry failed: %s", self.name, retry_err)
    # start_polling failed — polling is dead and no further error
    # callbacks will fire, so schedule the network reconnect handler
    # ourselves, routing the retry failure through the exponential-
    # backoff reconnect ladder so the adapter doesn't go silent.
    if not self.has_fatal_error:
        task = asyncio.ensure_future(
            self._handle_polling_network_error(retry_err)
        )
        self._background_tasks.add(task)
        task.add_done_callback(self._background_tasks.discard)
    return

Tests

tests/gateway/test_telegram_polling_conflict_retry.py — 4 regression tests:

• test_conflict_retry_start_polling_failure_schedules_network_reconnect — core fix validation
• test_conflict_retry_start_polling_failure_does_not_set_fatal_immediately — confirms transient path
• test_conflict_retry_start_polling_failure_leaves_adapter_alive — adapter stays running
• test_successful_conflict_retry_resets_conflict_count — conflict count resets on success

All 4 pass. Run: pytest tests/gateway/test_telegram_polling_conflict_retry.py -v

Changed files

• gateway/platforms/telegram.py (modified, +10/-2)
• tests/gateway/test_telegram_polling_conflict_retry.py (added, +177/-0)