hermes - 💡(How to fix) Fix terminal.docker_extra_args in config.yaml not being applied to Docker sandbox [1 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

Root Cause

In gateway/run.py, the _terminal_env_map dictionary maps config keys to environment variables but is missing the entry for docker_extra_args:

"docker_env": "TERMINAL_DOCKER_ENV",
# docker_extra_args is NOT mapped
"docker_mount_cwd_to_workspace": "TERMINAL_DOCKER_MOUNT_CWD_TO_WORKSPACE",

Without this mapping, config.docker_extra_args is never bridged to TERMINAL_DOCKER_EXTRA_ARGS and is therefore not read by terminal_tool.py.

Fix Action

Fixed

Code Example

"docker_env": "TERMINAL_DOCKER_ENV",
# docker_extra_args is NOT mapped
"docker_mount_cwd_to_workspace": "TERMINAL_DOCKER_MOUNT_CWD_TO_WORKSPACE",

---

terminal:
  backend: docker
  docker_extra_args:
    - -v
    - /path/to/hostdir:/path/to/container

---

"docker_extra_args": "TERMINAL_DOCKER_EXTRA_ARGS",
RAW_BUFFERClick to expand / collapse

Problem

When configuring terminal.docker_extra_args in ~/.hermes/config.yaml, the setting is not being passed to the Docker environment. Users cannot configure additional volume mounts via this option.

Root Cause

In gateway/run.py, the _terminal_env_map dictionary maps config keys to environment variables but is missing the entry for docker_extra_args:

"docker_env": "TERMINAL_DOCKER_ENV",
# docker_extra_args is NOT mapped
"docker_mount_cwd_to_workspace": "TERMINAL_DOCKER_MOUNT_CWD_TO_WORKSPACE",

Without this mapping, config.docker_extra_args is never bridged to TERMINAL_DOCKER_EXTRA_ARGS and is therefore not read by terminal_tool.py.

Expected Behavior

Users should be able to configure Docker extra arguments (such as additional volume mounts) via config.yaml:

terminal:
  backend: docker
  docker_extra_args:
    - -v
    - /path/to/hostdir:/path/to/container

Proposed Fix

Add docker_extra_args to the _terminal_env_map in gateway/run.py:

"docker_extra_args": "TERMINAL_DOCKER_EXTRA_ARGS",
```"

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

hermes - 💡(How to fix) Fix terminal.docker_extra_args in config.yaml not being applied to Docker sandbox [1 pull requests]