Fix Plan

To expand the scope of the existing linter, we will modify the test_device_bias_linter.py to check for hardcoded 'cuda' strings unless specific criteria are met.

Steps

• Update the test_device_bias_linter.py to include a check for 'cuda' strings
• Add an escape hatch using # noqa comments
• Modify the linter to ignore files or directories with 'cuda' in their name

Example Code

import re

# ...

def _check_cuda_hardcoding(node):
    # Check if node contains hardcoded 'cuda' string
    if re.search(r'\bcuda\b', node.s):
        # Check if file or directory has 'cuda' in name
        if 'cuda' not in node.file.name and 'cuda' not in node.file.dirname:
            # Check for escape hatch
            if not _has_noqa_comment(node):
                yield Error(node, "Hardcoded 'cuda' string found")

def _has_noqa_comment(node):
    # Check if node has a # noqa comment
    for comment in node.comments:
        if '# noqa' in comment.s:
            return True
    return False

Verification

To verify the fix, run the updated linter on the PyTorch codebase and check for errors related to hardcoded 'cuda' strings.

Extra Tips

• Make sure to test the updated linter thoroughly to avoid false positives or negatives.
• Consider adding more specific criteria for ignoring files or directories with 'cuda' in their name.