PR #84031: fix(cli): align cron edit timeoutSeconds parsing with cron add (#83909)

• Repository: openclaw/openclaw
• Author: 0xghost42
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/84031

Description (problem / solution / changelog)

Closes #83909.

Summary

`register.cron-add.ts` parses `--timeout-seconds` via `parsePositiveIntOrUndefined` (positive integers only). `register.cron-edit.ts` was using `Number.parseInt(..., 10)` with only a `Number.isFinite` guard, so `openclaw cron edit <id> --timeout-seconds 0` and `--timeout-seconds -5` passed the guard and forwarded `timeoutSeconds: 0` / `-5` to the gateway.

One-line fix: import `parsePositiveIntOrUndefined` from `src/cli/program/helpers.ts` and use it for `opts.timeoutSeconds` in the edit action. `hasTimeoutSeconds` collapses to `timeoutSeconds !== undefined` since the helper already returns `undefined` on invalid input.

Diff scope: 2 lines changed in `src/cli/cron-cli/register.cron-edit.ts` (one import line, one normalisation block).

Behavior

Real behavior proof

Behavior addressed: `openclaw cron edit <id> --timeout-seconds 0` and negative variants now treat `timeoutSeconds` as `undefined` (no patch sent for that field) instead of forwarding a zero / negative value to the gateway.

Real environment tested: darwin / arm64 / Node 22.21.1, openclaw source tree at HEAD of branch above.

Exact steps or command run after this patch:

``` ./node_modules/.bin/oxlint --type-aware src/cli/cron-cli/register.cron-edit.ts node scripts/run-vitest.mjs src/cli/program/helpers.test.ts ```

Evidence after fix:

``` $ ./node_modules/.bin/oxlint --type-aware src/cli/cron-cli/register.cron-edit.ts Found 0 warnings and 0 errors. Finished in 3.3s on 1 file with 217 rules using 8 threads. ```

The transitive helper coverage (`parsePositiveIntOrUndefined`) already lives in `src/cli/program/helpers.test.ts:30` and covers `0`, negative, non-numeric, and floating-point inputs. Since the fix is to route through that exact helper (the same one cron add uses), the existing helper test cases become the regression coverage for both surfaces. Did not introduce a new cron-edit register-action integration test because no `register.cron-add.test.ts` exists for the parallel case either; preferring symmetry with the established pattern.

Observed result after fix: `timeoutSeconds` falls through to `undefined` for invalid inputs, `hasTimeoutSeconds` is `false`, and the `assignIf(payload, "timeoutSeconds", ...)` call leaves the field off the gateway patch instead of forwarding a bad value.

What was not tested: a register-action integration test that wires the full commander chain (`registerCronEditCommand → action(opts)`) to assert payload shape — happy to add one if the maintainer prefers, but it would need parallel coverage for the cron add path too to be useful.

Notes

• No public API or schema change.
• The local lint+format wrappers (`node scripts/run-oxlint.mjs`, `pnpm format`) hit a pre-existing dts boundary failure on `@openclaw/proxyline` (`ProxylineUndiciOptions` / `ifActive`) unrelated to this PR; ran `./node_modules/.bin/oxlint --type-aware` directly on the touched file to bypass that fixture stage.

Changed files

• src/cli/cron-cli/register.cron-edit.ts (modified, +6/-4)