hermes - 💡(How to fix) Fix Tirith approval buttons misleading: "permanently" is actually session-scoped [1 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

Root Cause

In tools/approval.py line 1344, Tirith warnings explicitly reject permanent approval: python if choice == "session" or (choice == "always" and is_tirith): approve_session(session_key, key) # session only Comment at line 1421 confirms: # tirith: session only (no permanent broad allowlisting)

This is a reasonable security policy, but the Telegram button label and confirmation message both say "permanently" — the user expects the approval to survive restart but it doesn't.

Fix Action

Fixed

RAW_BUFFERClick to expand / collapse

Bug

When a Tirith security scan triggers an approval prompt in the Telegram gateway, the "Approve permanently" button says "permanently" but is actually downgraded to session-scoped.

Root Cause

In tools/approval.py line 1344, Tirith warnings explicitly reject permanent approval: python if choice == "session" or (choice == "always" and is_tirith): approve_session(session_key, key) # session only Comment at line 1421 confirms: # tirith: session only (no permanent broad allowlisting)

This is a reasonable security policy, but the Telegram button label and confirmation message both say "permanently" — the user expects the approval to survive restart but it doesn't.

Suggested Fix

For Tirith warnings, replace "permanently" with "this session" in the button label, or add a note explaining Tirith approvals are always session-scoped.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING