PR #74578: fix(pi-embedded): strip [tool calls omitted] from user-facing text

• Repository: openclaw/openclaw
• Author: blaspat
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/74578

Description (problem / solution / changelog)

The internal replay placeholder '[tool calls omitted]' was leaking into channel output (e.g. Telegram) after aborted tool calls.

Fix: strip the placeholder early in sanitizeUserFacingText so all channels are protected by default. The replay transcript path in turns.ts is unaffected — it uses the placeholder internally.

Fixes #74573.

Summary

Describe the problem and fix in 2–5 bullets:

If this PR fixes a plugin beta-release blocker, title it fix(<plugin-id>): beta blocker - <summary> and link the matching Beta blocker: <plugin-name> - <summary> issue labeled beta-blocker. Contributors cannot label PRs, so the title is the PR-side signal for maintainers and automation.

• Problem:
• Why it matters:
• What changed:
• What did NOT change (scope boundary):

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #
• Related #
• This PR fixes a bug or regression

Root Cause (if applicable)

For bug fixes or regressions, explain why this happened, not just what changed. Otherwise write N/A. If the cause is unclear, write Unknown.

• Root cause:
• Missing detection / guardrail:
• Contributing context (if known):

Regression Test Plan (if applicable)

For bug fixes or regressions, name the smallest reliable test coverage that should catch this. Otherwise write N/A.

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file:
• Scenario the test should lock in:
• Why this is the smallest reliable guardrail:
• Existing test that already covers this (if any):
• If no new test is added, why not:

User-visible / Behavior Changes

List user-visible changes (including defaults/config).
If none, write None.

Diagram (if applicable)

For UI changes or non-trivial logic flows, include a small ASCII diagram reviewers can scan quickly. Otherwise write N/A.

Before:
[user action] -> [old state]

After:
[user action] -> [new state] -> [result]

Security Impact (required)

• New permissions/capabilities? (Yes/No)
• Secrets/tokens handling changed? (Yes/No)
• New/changed network calls? (Yes/No)
• Command/tool execution surface changed? (Yes/No)
• Data access scope changed? (Yes/No)
• If any Yes, explain risk + mitigation:

Repro + Verification

Environment

• OS:
• Runtime/container:
• Model/provider:
• Integration/channel (if any):
• Relevant config (redacted):

Steps

Expected

Actual

Evidence

Attach at least one:

• Failing test/log before + passing after
• Trace/log snippets
• Screenshot/recording
• Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

• Verified scenarios:
• Edge cases checked:
• What you did not verify:

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.

Compatibility / Migration

• Backward compatible? (Yes/No)
• Config/env changes? (Yes/No)
• Migration needed? (Yes/No)
• If yes, exact upgrade steps:

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

• Risk:
  • Mitigation:

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/agents/pi-embedded-helpers.sanitizeuserfacingtext.test.ts (modified, +15/-0)
• src/agents/pi-embedded-helpers/sanitize-user-facing-text.ts (modified, +23/-7)

PR #74785: fix(pi-embedded): strip [assistant copied inbound metadata omitted] placeholder from delivery

• Repository: openclaw/openclaw
• Author: hclsys
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/74785

Description (problem / solution / changelog)

Problem

The internal replay placeholder [assistant copied inbound metadata omitted] is leaking into outbound Telegram (and other channel) messages after the 2026.4.27 update, appearing as the entire message body instead of the actual assistant reply.

Fixes #74745.

Root cause

sanitize-user-facing-text.ts already strips [tool calls omitted] from user-facing output (landed in d30b8dccfd, fixing #74573). The same sentinel pattern OMITTED_INBOUND_METADATA_TEXT = "[assistant copied inbound metadata omitted]" synthesized by normalizeAssistantReplayContent in replay-history.ts was not covered by the stripping regex.

Solution

Extend TOOL_CALLS_OMITTED_PLACEHOLDER_LINE_RE to cover both placeholder variants using an alternation group:

-const TOOL_CALLS_OMITTED_PLACEHOLDER_LINE_RE = /^[ \t]*\[tool calls omitted\][ \t]*$/i;
+const TOOL_CALLS_OMITTED_PLACEHOLDER_LINE_RE =
+  /^[ \t]*\[(?:tool calls omitted|assistant copied inbound metadata omitted)\][ \t]*$/i;

Same standalone-line logic applies: only strip when the placeholder is the entire line content, so ordinary user discussion of the placeholder text is preserved.

Tests

Added 4 test assertions mirroring the existing [tool calls omitted] coverage — standalone strip, whitespace strip, mid-text strip, and inline-mention preservation. All 90/90 tests pass.

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/agents/pi-embedded-helpers.sanitizeuserfacingtext.test.ts (modified, +19/-0)
• src/agents/pi-embedded-helpers/sanitize-user-facing-text.ts (modified, +4/-3)