auxiliary:
    vision:
      model: hermes-aux-vision
      base_url: http://127.0.0.1:4000/v1

---

# tools/vision_tools.py (before fix)
def _handle_vision_analyze(args, **kw):
    model = os.getenv("AUXILIARY_VISION_MODEL", "").strip() or None
    return vision_analyze_tool(image_url, full_prompt, model)  # explicit override

# tools/browser_tool.py (before fix)
def _get_vision_model() -> Optional[str]:
    return os.getenv("AUXILIARY_VISION_MODEL", "").strip() or None

def _get_extraction_model() -> Optional[str]:
    return os.getenv("AUXILIARY_WEB_EXTRACT_MODEL", "").strip() or None

---

def _resolve_vision_model_for_handler() -> Optional[str]:
    try:
        cfg = read_raw_config()
        vision_cfg = cfg.get("auxiliary", {}).get("vision", {}) if isinstance(cfg, dict) else {}
        cfg_model = str(vision_cfg.get("model", "")).strip() if isinstance(vision_cfg, dict) else ""
    except Exception:
        cfg_model = ""
    if cfg_model:
        return None  # let aux client resolve from config.yaml
    return os.getenv("AUXILIARY_VISION_MODEL", "").strip() or None

---

def _get_vision_model() -> Optional[str]:
    try:
        cfg = read_raw_config()
        vision_cfg = cfg.get("auxiliary", {}).get("vision", {}) if isinstance(cfg, dict) else {}
        cfg_model = str(vision_cfg.get("model", "")).strip() if isinstance(vision_cfg, dict) else ""
    except Exception:
        cfg_model = ""
    if cfg_model:
        return None
    return os.getenv("AUXILIARY_VISION_MODEL", "").strip() or None

def _get_extraction_model() -> Optional[str]:
    try:
        cfg = read_raw_config()
        we_cfg = cfg.get("auxiliary", {}).get("web_extract", {}) if isinstance(cfg, dict) else {}
        cfg_model = str(we_cfg.get("model", "")).strip() if isinstance(we_cfg, dict) else ""
    except Exception:
        cfg_model = ""
    if cfg_model:
        return None
    return os.getenv("AUXILIARY_WEB_EXTRACT_MODEL", "").strip() or None

---

"""Tests for browser_tool model resolution: config.yaml > env var precedence."""

import os
from unittest.mock import patch

from tools.browser_tool import _get_vision_model, _get_extraction_model


class TestGetVisionModel:
    def test_config_yaml_vision_model_beats_env_var(self):
        """Regression: stale AUXILIARY_VISION_MODEL must NOT override config.yaml."""
        with (
            patch.dict(os.environ, {"AUXILIARY_VISION_MODEL": "stale-env-model"}),
            patch(
                "tools.browser_tool.read_raw_config",
                return_value={"auxiliary": {"vision": {"model": "hermes-aux-vision"}}},
            ),
        ):
            result = _get_vision_model()
        assert result != "stale-env-model"
        assert result in (None, "hermes-aux-vision")

    def test_env_var_used_when_config_empty(self):
        with (
            patch.dict(os.environ, {"AUXILIARY_VISION_MODEL": "env-only/model"}),
            patch("tools.browser_tool.read_raw_config", return_value={"auxiliary": {"vision": {}}}),
        ):
            assert _get_vision_model() == "env-only/model"

    def test_returns_none_when_both_empty(self):
        with (
            patch.dict(os.environ, {}, clear=False),
            patch("tools.browser_tool.read_raw_config", return_value={"auxiliary": {"vision": {}}}),
        ):
            os.environ.pop("AUXILIARY_VISION_MODEL", None)
            assert _get_vision_model() is None

    def test_config_read_failure_falls_back_to_env(self):
        with (
            patch.dict(os.environ, {"AUXILIARY_VISION_MODEL": "env-fallback"}),
            patch("tools.browser_tool.read_raw_config", side_effect=RuntimeError("config broken")),
        ):
            assert _get_vision_model() == "env-fallback"


class TestGetExtractionModel:
    def test_config_yaml_extraction_model_beats_env_var(self):
        with (
            patch.dict(os.environ, {"AUXILIARY_WEB_EXTRACT_MODEL": "stale-env-model"}),
            patch(
                "tools.browser_tool.read_raw_config",
                return_value={"auxiliary": {"web_extract": {"model": "hermes-aux-web-extract"}}},
            ),
        ):
            result = _get_extraction_model()
        assert result != "stale-env-model"
        assert result in (None, "hermes-aux-web-extract")

    def test_env_var_used_when_config_empty(self):
        with (
            patch.dict(os.environ, {"AUXILIARY_WEB_EXTRACT_MODEL": "env-only/extract"}),
            patch("tools.browser_tool.read_raw_config", return_value={"auxiliary": {"web_extract": {}}}),
        ):
            assert _get_extraction_model() == "env-only/extract"

    def test_returns_none_when_both_empty(self):
        with (
            patch.dict(os.environ, {}, clear=False),
            patch("tools.browser_tool.read_raw_config", return_value={"auxiliary": {"web_extract": {}}}),
        ):
            os.environ.pop("AUXILIARY_WEB_EXTRACT_MODEL", None)
            assert _get_extraction_model() is None

    def test_config_read_failure_falls_back_to_env(self):
        with (
            patch.dict(os.environ, {"AUXILIARY_WEB_EXTRACT_MODEL": "env-fallback"}),
            patch("tools.browser_tool.read_raw_config", side_effect=RuntimeError("config broken")),
        ):
            assert _get_extraction_model() == "env-fallback"

---

$ pytest tests/tools/test_browser_tool_model_resolution.py tests/tools/test_vision_tools.py -q
113 passed

$ pytest tests/agent/test_auxiliary_config_bridge.py tests/agent/test_vision_resolved_args.py -q
20 passed