hermes - 💡(How to fix) Fix tools/skills_sync.py sync mechanism has no dedicated test file

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
RAW_BUFFERClick to expand / collapse

Problem

tools/skills_sync.py contains the bundled skills sync mechanism (sync_skills, _discover_bundled_skills, _compute_relative_dest, _read_manifest, _write_manifest) — production code that manages skill synchronization between a bundled directory and the user profile skills directory. No dedicated test file exists for it.

Expected Outcome

sync_skills and its helper functions have unit tests covering: manifest read/write round-trip, bundled skill discovery, relative path computation, and the sync operation itself.

Suggested Approach

Create tests/tools/test_skills_sync.py:

  • test_get_bundled_dir_returns_path — verifies bundled skills directory is found
  • test_read_manifest_nonexistent — returns empty set when manifest missing
  • test_discover_bundled_skills — finds skills in bundled dir
  • test_compute_relative_dest — correctly computes relative paths
  • test_sync_skills_dry_logic — mock filesystem, verify correct copy/link behavior
  • test_write_manifest_persists — manifest is written and re-readable

Suggested Files

  • tools/skills_sync.py (source)
  • tests/tools/test_skills_sync.py (new test file)

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

hermes - 💡(How to fix) Fix tools/skills_sync.py sync mechanism has no dedicated test file