codex - 💡(How to fix) Fix Treat git global pager options as unsafe for auto-approval

TL;DR

Reject pager-forcing options when they appear before the matched git subcommand to maintain the security of read-only git commands.

Guidance

• Update the codex-shell-command to distinguish between pager-forcing global options and normal read-only git output flags.
• Implement a position-aware check to allow -p as a subcommand flag (e.g., git log -p) while rejecting it as a global option (e.g., git -p status).
• Ensure the check covers both direct argv and parsed bash -lc invocations to handle different command formats.
• Review the suggested fix in the provided GitHub comparison to understand the proposed changes.

Example

No code snippet is provided as the issue does not contain explicit code, but the suggested fix link offers a comparison of the proposed changes.

Notes

The current implementation may not cover all edge cases, and the suggested fix aims to address the specific vulnerability related to pager-forcing options. Further testing and review may be necessary to ensure the updated codex-shell-command handles all possible command formats and options correctly.

Recommendation

Apply the workaround by implementing the position-aware check for pager-forcing options, as it directly addresses the identified security concern and allows for the continued safe use of read-only git commands with specific flags like -p in subcommands.