hermes - 💡(How to fix) Fix TUI: thinking content leaks through when show_reasoning=false

Description

When display.show_reasoning is set to false in config.yaml, the TUI (hermes --tui) still renders a collapsed thinking block after the turn completes:

▾ Thinking  ~358 tokens
The user is waiting for my response. Let me now compile...

The reasoning content is correctly hidden during streaming (via recordReasoningAvailable / recordReasoningDelta which check getUiState().showReasoning), but two other code paths bypass that gate and inject thinking into the segment store after the fact.

Root Cause

In ui-tui/src/app/turnController.ts:

Path 1 — flushStreamingSegment() (line ~283):

if (split.reasoning && !this.reasoningText.trim()) {
  this.reasoningText = split.reasoning
  // ... pushes thinking segment without checking showReasoning
}

Path 2 — recordMessageComplete() (line ~474):

const finalThinking = hasReasoningSegment ?  : savedReasoning.trim()
// savedReasoning is populated regardless of showReasoning

Both paths write thinking content into segmentMessages / turn state even when showReasoning is false.

Proposed Fix

1. flushStreamingSegment(): Gate the reasoning extraction with getUiState().showReasoning:

   if (split.reasoning && getUiState().showReasoning && !this.reasoningText.trim()) {

2. recordMessageComplete(): Clear finalThinking when reasoning display is off:

   const show = getUiState().showReasoning
   const finalThinking = (show && !hasReasoningSegment) ? savedReasoning.trim() :

Environment

• Hermes version: latest (main branch)
• Platform: macOS
• Entry point: hermes --tui
• Config: display.show_reasoning: false