dify - 💡(How to fix) Fix Unused and broken query param `datasource_parameters` in `/console/api/notion/pre-import/pages` [1 pull requests]

Self Checks

• I have read the Contributing Guide and Language Policy.
• This is only for bug report, if you would like to ask a question, please head to Discussions.
• I have searched for existing issues search for existing issues, including closed ones.
• I confirm that I am using English to submit this report, otherwise it will be closed.
• 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
• Please do not modify this template :) and fill in all the required fields.

Dify version

main

Cloud or Self Hosted

Self Hosted (Source), Self Hosted (Docker)

Steps to reproduce

N/A

✔️ Expected Behavior

N/A

❌ Actual Behavior

In api/controllers/console/datasets/data_source.py there is the following:

class DataSourceNotionListQuery(BaseModel):
    dataset_id: str | None = Field(default=None, description="Dataset ID")
    credential_id: str = Field(..., description="Credential ID", min_length=1)
    datasource_parameters: dict[str, Any] | None = Field(default=None, description="Datasource parameters JSON string")

However, the datasource_parameters comes from query params, so it would be a string, failing the parse to {}. More weirdly, I didn't find any frontend code filling in this param.

Can we safely delete this?