hermes - 💡(How to fix) Fix url_safety.py incorrectly blocks RFC 2544 (198.18.0.0/15) used by Clash TUN Fake IP [2 comments, 2 participants]

TL;DR

The issue can be fixed by modifying the _is_blocked_ip function in tools/url_safety.py to correctly handle the RFC 2544 benchmarking range.

Guidance

• Modify the _is_blocked_ip function to check if the IP is within the RFC 2544 range and return False if it is, as this range is not private.
• Verify that the modified function correctly allows access to Vercel-hosted sites via web_extract() when Clash TUN mode is enabled.
• Consider adding a comment to the code to explain why the RFC 2544 range is handled as a special case.
• Test the modified function with different IP addresses to ensure it is working as expected.

Example

_RFC2544_NETWORK = ipaddress.ip_network("198.18.0.0/15")

def _is_blocked_ip(ip):
    if ip in _RFC2544_NETWORK:  # RFC 2544 is NOT private
        return False
    if ip.is_private or ip.is_loopback or ip.is_link_local or ip.is_reserved:
        return True
    # ... rest of function

Notes

This fix assumes that the only issue is with the RFC 2544 range being incorrectly marked as reserved. If there are other ranges that need to be handled similarly, additional modifications may be necessary.

Recommendation

Apply workaround: Modify the _is_blocked_ip function as described above to correctly handle the RFC 2544 range, as this is a specific and targeted fix for the issue at hand.